add golangci-lint

Author: dmacvicar

.github/workflows/test.yml

@@ -10,7 +10,20 @@ on:
     paths-ignore:
       - '*.md'
       - 'website/*'
+permissions:
+  contents: read
+  pull-requests: read
 jobs:
+  golangci:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v2
+        with:
+          version: v1.43.0
+          only-new-issues: true
   build:
     name: Build
     runs-on: ${{ matrix.os }}

.golangci.yaml

@@ -0,0 +1,27 @@
+linters-settings:
+  lll:
+    line-length: 140
+  gosec:
+    # complains that we allow to bypass checking certificates/keys
+    excludes:
+      - G402
+      - G106
+
+linters:
+  enable-all: false
+  enable:
+    - ifshort
+    - unparam
+    - exhaustive
+    - godot
+    - nilerr
+    - gosec
+    - revive
+    - gocritic
+    - misspell
+    - depguard
+    - lll
+    - errorlint
+    - errcheck
+issues:
+  new-from-rev: HEAD~

Makefile

@@ -20,6 +20,10 @@ install:
 test:
 	go test -v $(TEST_ARGS_DEF) $(TEST_ARGS) ./libvirt
 
+lint:
+	golangci-lint run
+	terraform fmt -write=false -check=true -diff=true examples/
+
 # acceptance tests
 # usage:
 #