Force removal of domains with snapshots or checkpoints (#899)

Cedric Bosdonnat · web-flow · commit 74035f205ebb · 2021-12-05T23:51:51.000+01:00
Libvirt needs special flags to actually delete a virtual machine if
that one has a snapshot or a checkpoint.

Use these flags when removing the domain resource to avoid any error
if the VM has snapshots or checkpoints even added manually by the user.
diff --git a/libvirt/resource_libvirt_domain.go b/libvirt/resource_libvirt_domain.go
@@ -1073,7 +1073,7 @@ func resourceLibvirtDomainDelete(d *schema.ResourceData, meta interface{}) error
 		}
 	}
 
-	if err := virConn.DomainUndefineFlags(domain, libvirt.DomainUndefineNvram); err != nil {
+	if err := virConn.DomainUndefineFlags(domain, libvirt.DomainUndefineNvram|libvirt.DomainUndefineSnapshotsMetadata|libvirt.DomainUndefineManagedSave|libvirt.DomainUndefineCheckpointsMetadata); err != nil {
 		if e := err.(libvirt.Error); e.Code == uint32(libvirt.ErrNoSupport) || e.Code == uint32(libvirt.ErrInvalidArg) {
 			log.Printf("libvirt does not support undefine flags: will try again without flags")
 			if err := virConn.DomainUndefine(domain); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -1073,7 +1073,7 @@ func resourceLibvirtDomainDelete(d *schema.ResourceData, meta interface{}) error`
`1073`	`1073`	`}`
`1074`	`1074`	`}`
`1075`	`1075`
`1076`		`- if err := virConn.DomainUndefineFlags(domain, libvirt.DomainUndefineNvram); err != nil {`
	`1076`	`+ if err := virConn.DomainUndefineFlags(domain, libvirt.DomainUndefineNvram\|libvirt.DomainUndefineSnapshotsMetadata\|libvirt.DomainUndefineManagedSave\|libvirt.DomainUndefineCheckpointsMetadata); err != nil {`
`1077`	`1077`	`if e := err.(libvirt.Error); e.Code == uint32(libvirt.ErrNoSupport) \|\| e.Code == uint32(libvirt.ErrInvalidArg) {`
`1078`	`1078`	`log.Printf("libvirt does not support undefine flags: will try again without flags")`
`1079`	`1079`	`if err := virConn.DomainUndefine(domain); err != nil {`