Reduce memory footprint of printDebug

This splits the sprintf output into three sections, so the buffer only needs to be 34 bytes large instead of 88.

Author: dmadison

src/XInput.cpp

@@ -570,8 +570,26 @@ static void fillBuffer(char* buff, const char fill) {
 
 void XInputController::printDebug(Print &output) const {
 	const char fillCharacter = '_';
+	char buffer[34];
 
-	char buffer[88];
+	output.print("XInput Debug: ");
+
+	// Left Side Controls
+	char leftBumper[3] = "LB";
+	char leftJoyBtn[3] = "L3";
+
+	if (!getButton(BUTTON_LB)) fillBuffer(leftBumper, fillCharacter);
+	if (!getButton(BUTTON_L3)) fillBuffer(leftJoyBtn, fillCharacter);
+
+	sprintf(buffer,
+		"LT: %3u %s L:(%6d, %6d, %s)",
+
+		getTrigger(TRIGGER_LEFT),
+		leftBumper,
+		getJoystickX(JOY_LEFT), getJoystickY(JOY_LEFT),
+		leftJoyBtn
+	);
+	output.print(buffer);
 
 	// Face Buttons
 	const char dpadLPrint = getButton(DPAD_LEFT)  ? '<' : fillCharacter;
@@ -589,36 +607,25 @@ void XInputController::printDebug(Print &output) const {
 
 	const char logoPrint = getButton(BUTTON_LOGO) ? 'X' : fillCharacter;
 
-	// Bumpers
-	char leftBumper[3]  = "LB";
-	char rightBumper[3] = "RB";
+	sprintf(buffer,
+		" %c%c%c%c | %c%c%c | %c%c%c%c ",
 
-	if (!getButton(BUTTON_LB)) fillBuffer(leftBumper,  fillCharacter);
-	if (!getButton(BUTTON_RB)) fillBuffer(rightBumper, fillCharacter);
+		dpadLPrint, dpadUPrint, dpadDPrint, dpadRPrint,
+		backPrint, logoPrint, startPrint,
+		aButtonPrint, bButtonPrint, xButtonPrint, yButtonPrint
+	);
+	output.print(buffer);
 
-	// Joystick Buttons
-	char leftJoyBtn[3]  = "L3";
+	// Right Side Controls
+	char rightBumper[3] = "RB";
 	char rightJoyBtn[3] = "R3";
 
-	if (!getButton(BUTTON_L3)) fillBuffer(leftJoyBtn,  fillCharacter);
+	if (!getButton(BUTTON_RB)) fillBuffer(rightBumper, fillCharacter);
 	if (!getButton(BUTTON_R3)) fillBuffer(rightJoyBtn, fillCharacter);
 
-	output.print("XInput Debug: ");
 	sprintf(buffer,
-		"LT: %3u %s L:(%6d, %6d, %s) %c%c%c%c | %c%c%c | %c%c%c%c R:(%6d, %6d, %s) %s RT: %3u",
+		"R:(%6d, %6d, %s) %s RT: %3u",
 
-		// Left side controls
-		getTrigger(TRIGGER_LEFT),
-		leftBumper,
-		getJoystickX(JOY_LEFT), getJoystickY(JOY_LEFT),
-		leftJoyBtn,
-
-		// Buttons
-		dpadLPrint, dpadUPrint, dpadDPrint, dpadRPrint,
-		backPrint, logoPrint, startPrint,
-		aButtonPrint, bButtonPrint, xButtonPrint, yButtonPrint,
-
-		// Right side controls
 		getJoystickX(JOY_RIGHT), getJoystickY(JOY_RIGHT),
 		rightJoyBtn,
 		rightBumper,