Skip to content

Commit 00db3a5

Browse files
committed
Change resistor comments for power LED
The resistor is not strictly necessary, although it does make a lot of sense on the G25 to match brightness between the two indicator LEDs.
1 parent d06390b commit 00db3a5

File tree

6 files changed

+44
-20
lines changed

6 files changed

+44
-20
lines changed

examples/Shifter/LogitechShifterG25/LogitechShifterG25_Joystick/LogitechShifterG25_Joystick.ino

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,17 @@ const int Pin_ShifterLatch = 5; // DE-9 pin 3
4040
const int Pin_ShifterClock = 6; // DE-9 pin 7
4141
const int Pin_ShifterData = 7; // DE-9 pin 2
4242

43-
// These pins require extra resistors! If you have made the proper
44-
// connections, change the pin numbers to the ones you're using
45-
const int Pin_ShifterDetect = SimRacing::UnusedPin; // DE-9 pin 1, requires pull-down resistor
46-
const int Pin_ShifterLED = SimRacing::UnusedPin; // DE-9 pin 5, requires 100-120 Ohm series resistor
43+
// This pin is optional! You do not need to connect it in order
44+
// to read data from the shifter. Connecting it and changing the
45+
// pin number below will light the power LED. On the G25, I
46+
// recommend using a 100 Ohm resistor in series to match the
47+
// brightness of the sequential mode LED.
48+
const int Pin_ShifterLED = SimRacing::UnusedPin; // DE-9 pin 5
49+
50+
// This pin requies a pull-down resistor! If you have made the proper
51+
// connections, change the pin number to the one you're using. Setting
52+
// it will zero data when the shifter is disconnected.
53+
const int Pin_ShifterDetect = SimRacing::UnusedPin; // DE-9 pin 1
4754

4855
SimRacing::LogitechShifterG25 shifter(
4956
Pin_ShifterX, Pin_ShifterY,

examples/Shifter/LogitechShifterG25/LogitechShifterG25_Print/LogitechShifterG25_Print.ino

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,17 @@ const int Pin_ShifterLatch = 5; // DE-9 pin 3
3636
const int Pin_ShifterClock = 6; // DE-9 pin 7
3737
const int Pin_ShifterData = 7; // DE-9 pin 2
3838

39-
// These pins require extra resistors! If you have made the proper
40-
// connections, change the pin numbers to the ones you're using
41-
const int Pin_ShifterDetect = SimRacing::UnusedPin; // DE-9 pin 1, requires pull-down resistor
42-
const int Pin_ShifterLED = SimRacing::UnusedPin; // DE-9 pin 5, requires 100-120 Ohm series resistor
39+
// This pin is optional! You do not need to connect it in order
40+
// to read data from the shifter. Connecting it and changing the
41+
// pin number below will light the power LED. On the G25, I
42+
// recommend using a 100 Ohm resistor in series to match the
43+
// brightness of the sequential mode LED.
44+
const int Pin_ShifterLED = SimRacing::UnusedPin; // DE-9 pin 5
45+
46+
// This pin requies a pull-down resistor! If you have made the proper
47+
// connections, change the pin number to the one you're using. Setting
48+
// it will zero data when the shifter is disconnected.
49+
const int Pin_ShifterDetect = SimRacing::UnusedPin; // DE-9 pin 1
4350

4451
SimRacing::LogitechShifterG25 shifter(
4552
Pin_ShifterX, Pin_ShifterY,

examples/Shifter/LogitechShifterG27/LogitechShifterG27_Joystick/LogitechShifterG27_Joystick.ino

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,15 @@ const int Pin_ShifterLatch = 5; // DE-9 pin 3
4040
const int Pin_ShifterClock = 6; // DE-9 pin 1
4141
const int Pin_ShifterData = 7; // DE-9 pin 2
4242

43-
// These pins require extra resistors! If you have made the proper
44-
// connections, change the pin numbers to the ones you're using
45-
const int Pin_ShifterDetect = SimRacing::UnusedPin; // DE-9 pin 7, requires pull-down resistor
46-
const int Pin_ShifterLED = SimRacing::UnusedPin; // DE-9 pin 5, requires 100-120 Ohm series resistor
43+
// This pin is optional! You do not need to connect it in order
44+
// to read data from the shifter. Connecting it and changing the
45+
// pin number below will light the power LED.
46+
const int Pin_ShifterLED = SimRacing::UnusedPin; // DE-9 pin 5
47+
48+
// This pin requies a pull-down resistor! If you have made the proper
49+
// connections, change the pin number to the one you're using. Setting
50+
// it will zero data when the shifter is disconnected.
51+
const int Pin_ShifterDetect = SimRacing::UnusedPin; // DE-9 pin 7
4752

4853
SimRacing::LogitechShifterG27 shifter(
4954
Pin_ShifterX, Pin_ShifterY,

examples/Shifter/LogitechShifterG27/LogitechShifterG27_Print/LogitechShifterG27_Print.ino

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,15 @@ const int Pin_ShifterLatch = 5; // DE-9 pin 3
3636
const int Pin_ShifterClock = 6; // DE-9 pin 1
3737
const int Pin_ShifterData = 7; // DE-9 pin 2
3838

39-
// These pins require extra resistors! If you have made the proper
40-
// connections, change the pin numbers to the ones you're using
41-
const int Pin_ShifterDetect = SimRacing::UnusedPin; // DE-9 pin 7, requires pull-down resistor
42-
const int Pin_ShifterLED = SimRacing::UnusedPin; // DE-9 pin 5, requires 100-120 Ohm series resistor
39+
// This pin is optional! You do not need to connect it in order
40+
// to read data from the shifter. Connecting it and changing the
41+
// pin number below will light the power LED.
42+
const int Pin_ShifterLED = SimRacing::UnusedPin; // DE-9 pin 5
43+
44+
// This pin requies a pull-down resistor! If you have made the proper
45+
// connections, change the pin number to the one you're using. Setting
46+
// it will zero data when the shifter is disconnected.
47+
const int Pin_ShifterDetect = SimRacing::UnusedPin; // DE-9 pin 7
4348

4449
SimRacing::LogitechShifterG27 shifter(
4550
Pin_ShifterX, Pin_ShifterY,

src/SimRacing.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ LogitechShifterG27 CreateShieldObject<LogitechShifterG27, 2>() {
8585
const PinNum Pin_Clock = 15; // DE-9 pin 1, should have 470 Ohm resistor to prevent shorts
8686

8787
const PinNum Pin_Detect = A2; // DE-9 pin 7, requires 10k Ohm pull-down
88-
const PinNum Pin_LED = 16; // DE-9 pin 5, requires 100-120 Ohm series resistor
88+
const PinNum Pin_LED = 16; // DE-9 pin 5, has a 100-120 Ohm series resistor
8989

9090
return LogitechShifterG27(Pin_X_Wiper, Pin_Y_Wiper, Pin_Latch, Pin_Clock, Pin_DataOut, Pin_Detect, Pin_LED);
9191
}
@@ -103,7 +103,7 @@ LogitechShifterG25 CreateShieldObject<LogitechShifterG25, 2>() {
103103
const PinNum Pin_Clock = A2; // DE-9 pin 7, should have 470 Ohm resistor to prevent shorts
104104

105105
const PinNum Pin_Detect = 15; // DE-9 pin 1, requires 10k Ohm pull-down
106-
const PinNum Pin_LED = 16; // DE-9 pin 5, requires 100-120 Ohm series resistor
106+
const PinNum Pin_LED = 16; // DE-9 pin 5, has a 100-120 Ohm series resistor
107107

108108
return LogitechShifterG25(Pin_X_Wiper, Pin_Y_Wiper, Pin_Latch, Pin_Clock, Pin_DataOut, Pin_Detect, Pin_LED);
109109
}

src/SimRacing.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -976,7 +976,7 @@ namespace SimRacing {
976976
* @param pinDetect the digital input pin for device detection, DE-9 pin 7.
977977
* Requires a pull-down resistor.
978978
* @param pinLed digital output pin to light the power LED on connection,
979-
* DE-9 pin 5. Requires a 100 Ohm series resistor.
979+
* DE-9 pin 5
980980
*/
981981
LogitechShifterG27(
982982
PinNum pinX, PinNum pinY,
@@ -1109,7 +1109,7 @@ namespace SimRacing {
11091109
* @param pinDetect the digital input pin for device detection, DE-9 pin 1.
11101110
* Requires a pull-down resistor.
11111111
* @param pinLed digital output pin to light the power LED on connection,
1112-
* DE-9 pin 5. Requires a 100 Ohm series resistor.
1112+
* DE-9 pin 5
11131113
*/
11141114
LogitechShifterG25(
11151115
PinNum pinX, PinNum pinY,

0 commit comments

Comments
 (0)