[chore]: fix staticcheck rules (exporter) (open-telemetry#39192)

#### Description

This fixes staticcheck issues in exporter discovered after
golangci-lint@v2 upgrade

Signed-off-by: Matthieu MOREL <[email protected]>

Author: mmorel-35

exporter/alertmanagerexporter/alertmanager_exporter.go

@@ -189,7 +189,7 @@ func (s *alertmanagerExporter) pushTraces(ctx context.Context, td ptrace.Traces)
 }
 
 func (s *alertmanagerExporter) start(ctx context.Context, host component.Host) error {
-	client, err := s.config.ClientConfig.ToClient(ctx, host, s.settings)
+	client, err := s.config.ToClient(ctx, host, s.settings)
 	if err != nil {
 		return fmt.Errorf("failed to create HTTP Client: %w", err)
 	}
@@ -209,7 +209,7 @@ func newAlertManagerExporter(cfg *Config, set component.TelemetrySettings) *aler
 		config:            cfg,
 		settings:          set,
 		tracesMarshaler:   &ptrace.JSONMarshaler{},
-		endpoint:          fmt.Sprintf("%s/api/%s/alerts", cfg.ClientConfig.Endpoint, cfg.APIVersion),
+		endpoint:          fmt.Sprintf("%s/api/%s/alerts", cfg.Endpoint, cfg.APIVersion),
 		generatorURL:      cfg.GeneratorURL,
 		defaultSeverity:   cfg.DefaultSeverity,
 		severityAttribute: cfg.SeverityAttribute,

exporter/alertmanagerexporter/config.go

@@ -30,7 +30,7 @@ var _ component.Config = (*Config)(nil)
 
 // Validate checks if the exporter configuration is valid
 func (cfg *Config) Validate() error {
-	if cfg.ClientConfig.Endpoint == "" {
+	if cfg.Endpoint == "" {
 		return errors.New("endpoint must be non-empty")
 	}
 	if cfg.DefaultSeverity == "" {

exporter/alertmanagerexporter/config_test.go

@@ -112,7 +112,7 @@ func TestConfig_Validate(t *testing.T) {
 			name: "NoEndpoint",
 			cfg: func() *Config {
 				cfg := createDefaultConfig().(*Config)
-				cfg.ClientConfig.Endpoint = ""
+				cfg.Endpoint = ""
 				return cfg
 			}(),
 			wantErr: "endpoint must be non-empty",

exporter/awsemfexporter/datapoint.go

@@ -138,7 +138,7 @@ func (split *dataPointSplit) appendMetricData(metricVal float64, count uint64) {
 
 // CalculateDeltaDatapoints retrieves the NumberDataPoint at the given index and performs rate/delta calculation if necessary.
 func (dps numberDataPointSlice) CalculateDeltaDatapoints(i int, instrumentationScopeName string, _ bool, calculators *emfCalculators) ([]dataPoint, bool) {
-	metric := dps.NumberDataPointSlice.At(i)
+	metric := dps.At(i)
 	labels := createLabels(metric.Attributes(), instrumentationScopeName)
 	timestampMs := unixNanoToMilliseconds(metric.Timestamp())
 
@@ -177,7 +177,7 @@ func (dps numberDataPointSlice) CalculateDeltaDatapoints(i int, instrumentationS
 }
 
 func (dps numberDataPointSlice) IsStaleNaNInf(i int) (bool, pcommon.Map) {
-	metric := dps.NumberDataPointSlice.At(i)
+	metric := dps.At(i)
 	if metric.Flags().NoRecordedValue() {
 		return true, metric.Attributes()
 	}
@@ -189,7 +189,7 @@ func (dps numberDataPointSlice) IsStaleNaNInf(i int) (bool, pcommon.Map) {
 
 // CalculateDeltaDatapoints retrieves the HistogramDataPoint at the given index.
 func (dps histogramDataPointSlice) CalculateDeltaDatapoints(i int, instrumentationScopeName string, _ bool, _ *emfCalculators) ([]dataPoint, bool) {
-	metric := dps.HistogramDataPointSlice.At(i)
+	metric := dps.At(i)
 	labels := createLabels(metric.Attributes(), instrumentationScopeName)
 	timestamp := unixNanoToMilliseconds(metric.Timestamp())
 
@@ -207,7 +207,7 @@ func (dps histogramDataPointSlice) CalculateDeltaDatapoints(i int, instrumentati
 }
 
 func (dps histogramDataPointSlice) IsStaleNaNInf(i int) (bool, pcommon.Map) {
-	metric := dps.HistogramDataPointSlice.At(i)
+	metric := dps.At(i)
 	if metric.Flags().NoRecordedValue() {
 		return true, metric.Attributes()
 	}
@@ -229,7 +229,7 @@ func (dps histogramDataPointSlice) IsStaleNaNInf(i int) (bool, pcommon.Map) {
 // - Sum is only assigned to the first split to ensure the total sum of the datapoints after aggregation is correct.
 // - Count is accumulated based on the bucket counts within each split.
 func (dps exponentialHistogramDataPointSlice) CalculateDeltaDatapoints(idx int, instrumentationScopeName string, _ bool, _ *emfCalculators) ([]dataPoint, bool) {
-	metric := dps.ExponentialHistogramDataPointSlice.At(idx)
+	metric := dps.At(idx)
 
 	const splitThreshold = 100
 	currentBucketIndex := 0
@@ -412,7 +412,7 @@ func collectDatapointsWithNegativeBuckets(split *dataPointSplit, metric pmetric.
 }
 
 func (dps exponentialHistogramDataPointSlice) IsStaleNaNInf(i int) (bool, pcommon.Map) {
-	metric := dps.ExponentialHistogramDataPointSlice.At(i)
+	metric := dps.At(i)
 	if metric.Flags().NoRecordedValue() {
 		return true, metric.Attributes()
 	}
@@ -430,7 +430,7 @@ func (dps exponentialHistogramDataPointSlice) IsStaleNaNInf(i int) (bool, pcommo
 
 // CalculateDeltaDatapoints retrieves the SummaryDataPoint at the given index and perform calculation with sum and count while retain the quantile value.
 func (dps summaryDataPointSlice) CalculateDeltaDatapoints(i int, instrumentationScopeName string, detailedMetrics bool, calculators *emfCalculators) ([]dataPoint, bool) {
-	metric := dps.SummaryDataPointSlice.At(i)
+	metric := dps.At(i)
 	labels := createLabels(metric.Attributes(), instrumentationScopeName)
 	timestampMs := unixNanoToMilliseconds(metric.Timestamp())
 
@@ -485,7 +485,7 @@ func (dps summaryDataPointSlice) CalculateDeltaDatapoints(i int, instrumentation
 }
 
 func (dps summaryDataPointSlice) IsStaleNaNInf(i int) (bool, pcommon.Map) {
-	metric := dps.SummaryDataPointSlice.At(i)
+	metric := dps.At(i)
 	if metric.Flags().NoRecordedValue() {
 		return true, metric.Attributes()
 	}

exporter/awsemfexporter/datapoint_test.go

@@ -2052,7 +2052,7 @@ func TestGetDataPoints(t *testing.T) {
 				expectedDPS := tc.expectedDatapointSlice.(numberDataPointSlice)
 				assert.Equal(t, expectedDPS.deltaMetricMetadata, convertedDPS.deltaMetricMetadata)
 				assert.Equal(t, 1, convertedDPS.Len())
-				dp := convertedDPS.NumberDataPointSlice.At(0)
+				dp := convertedDPS.At(0)
 				switch dp.ValueType() {
 				case pmetric.NumberDataPointValueTypeDouble:
 					assert.Equal(t, 0.1, dp.DoubleValue())
@@ -2062,14 +2062,14 @@ func TestGetDataPoints(t *testing.T) {
 				assert.Equal(t, tc.expectedAttributes, dp.Attributes().AsRaw())
 			case histogramDataPointSlice:
 				assert.Equal(t, 1, convertedDPS.Len())
-				dp := convertedDPS.HistogramDataPointSlice.At(0)
+				dp := convertedDPS.At(0)
 				assert.Equal(t, 35.0, dp.Sum())
 				assert.Equal(t, uint64(18), dp.Count())
 				assert.Equal(t, []float64{0, 10}, dp.ExplicitBounds().AsRaw())
 				assert.Equal(t, tc.expectedAttributes, dp.Attributes().AsRaw())
 			case exponentialHistogramDataPointSlice:
 				assert.Equal(t, 1, convertedDPS.Len())
-				dp := convertedDPS.ExponentialHistogramDataPointSlice.At(0)
+				dp := convertedDPS.At(0)
 				assert.Equal(t, float64(0), dp.Sum())
 				assert.Equal(t, uint64(4), dp.Count())
 				assert.Equal(t, []uint64{1, 0, 1}, dp.Positive().BucketCounts().AsRaw())
@@ -2080,7 +2080,7 @@ func TestGetDataPoints(t *testing.T) {
 				expectedDPS := tc.expectedDatapointSlice.(summaryDataPointSlice)
 				assert.Equal(t, expectedDPS.deltaMetricMetadata, convertedDPS.deltaMetricMetadata)
 				assert.Equal(t, 1, convertedDPS.Len())
-				dp := convertedDPS.SummaryDataPointSlice.At(0)
+				dp := convertedDPS.At(0)
 				assert.Equal(t, 15.0, dp.Sum())
 				assert.Equal(t, uint64(5), dp.Count())
 				assert.Equal(t, 2, dp.QuantileValues().Len())

exporter/awsemfexporter/grouped_metric.go

@@ -86,7 +86,7 @@ func addToGroupedMetric(
 			}
 
 			// Extra params to use when grouping metrics
-			metadata.groupedMetricMetadata.batchIndex = i
+			metadata.batchIndex = i
 			groupKey := aws.NewKey(metadata.groupedMetricMetadata, labels)
 			if _, ok := groupedMetrics[groupKey]; ok {
 				// if MetricName already exists in metrics map, print warning log

exporter/awsemfexporter/grouped_metric_test.go

@@ -309,9 +309,10 @@ func TestAddToGroupedMetric(t *testing.T) {
 			}
 			assert.Equal(t, expectedLabels, group.labels)
 
-			if group.metadata.logGroup == "log-group-2" {
+			switch group.metadata.logGroup {
+			case "log-group-2":
 				seenLogGroup2 = true
-			} else if group.metadata.logGroup == "log-group-1" {
+			case "log-group-1":
 				seenLogGroup1 = true
 			}
 		}
@@ -441,10 +442,10 @@ func TestAddToGroupedMetric(t *testing.T) {
 		for _, v := range groupedMetrics {
 			assert.Len(t, v.metrics, 1)
 			assert.Len(t, v.labels, 2)
-			assert.Contains(t, expectedMetadata, v.metadata.groupedMetricMetadata.batchIndex)
-			assert.Equal(t, expectedMetadata[v.metadata.groupedMetricMetadata.batchIndex], v.metadata)
+			assert.Contains(t, expectedMetadata, v.metadata.batchIndex)
+			assert.Equal(t, expectedMetadata[v.metadata.batchIndex], v.metadata)
 			assert.Equal(t, expectedLabels, v.labels)
-			delete(expectedMetadata, v.metadata.groupedMetricMetadata.batchIndex)
+			delete(expectedMetadata, v.metadata.batchIndex)
 		}
 	})
 }

exporter/awsemfexporter/metric_translator_test.go

@@ -348,16 +348,16 @@ func TestTranslateOtToGroupedMetric(t *testing.T) {
 
 			for _, v := range groupedMetrics {
 				assert.Equal(t, tc.expectedNamespace, v.metadata.namespace)
-				switch {
-				case v.metadata.metricDataType == pmetric.MetricTypeSum:
+				switch v.metadata.metricDataType {
+				case pmetric.MetricTypeSum:
 					assert.Len(t, v.metrics, 2)
 					assert.Equal(t, tc.counterLabels, v.labels)
 					assert.Equal(t, counterSumMetrics, v.metrics)
-				case v.metadata.metricDataType == pmetric.MetricTypeGauge:
+				case pmetric.MetricTypeGauge:
 					assert.Len(t, v.metrics, 2)
 					assert.Equal(t, tc.counterLabels, v.labels)
 					assert.Equal(t, counterGaugeMetrics, v.metrics)
-				case v.metadata.metricDataType == pmetric.MetricTypeHistogram:
+				case pmetric.MetricTypeHistogram:
 					assert.Len(t, v.metrics, 1)
 					assert.Equal(t, tc.timerLabels, v.labels)
 					assert.Equal(t, timerMetrics, v.metrics)

exporter/awskinesisexporter/exporter.go

@@ -90,7 +90,7 @@ func createExporter(ctx context.Context, c component.Config, log *zap.Logger, op
 	}
 
 	encoder, err := batch.NewEncoder(
-		conf.Encoding.Name,
+		conf.Name,
 		batch.WithMaxRecordSize(conf.MaxRecordSize),
 		batch.WithMaxRecordsPerBatch(conf.MaxRecordsPerBatch),
 		batch.WithCompressionType(conf.Compression),
@@ -99,7 +99,7 @@ func createExporter(ctx context.Context, c component.Config, log *zap.Logger, op
 		return nil, err
 	}
 
-	if conf.Encoding.Name == "otlp_json" {
+	if conf.Name == "otlp_json" {
 		log.Info("otlp_json is considered experimental and should not be used in a production environment")
 	}
 

exporter/awss3exporter/sumo_marshaler.go

@@ -32,7 +32,7 @@ func newSumoICMarshaler() sumoMarshaler {
 }
 
 func logEntry(buf *bytes.Buffer, format string, a ...any) {
-	buf.WriteString(fmt.Sprintf(format, a...))
+	fmt.Fprintf(buf, format, a...)
 	buf.WriteString("\n")
 }