fix tests warnings

Author: dmitrkozlovsk

src/services/analytics/stat_functions.py

@@ -8,7 +8,7 @@
 Key features:
 - Welch's t-test for comparing means with unequal variances.
 - Z-test for comparing proportions.
-- Ratio metric analysis using the delta method.
+- Ratio metric anaysis using the delta method.
 - Sample size calculations for various test types.
 - Support for both scalar and vectorized operations.
 """
@@ -106,8 +106,7 @@ def ttest_welch(
     ci_upper = t_diff + t_se * stat_ppf
     ci = ConfidenceInterval(ci_lower, ci_upper)
 
-    # Handle division by zero for diff_ratio
-    diff_ratio = np.where(mean_1 != 0, t_diff / mean_1, np.inf)
+    diff_ratio = np.divide(t_diff, mean_1, out=np.full_like(t_diff, np.inf, dtype=float), where=mean_1 != 0)
 
     return TestResult(statistic=t_stat, p_value=p_value, ci=ci, diff_abs=t_diff, diff_ratio=diff_ratio)
 

src/ui/results/elements.py

@@ -409,7 +409,7 @@ def render(cls, precomputes: pd.DataFrame | None) -> SettingsColumnLayout | None
         p_value_threshold_filter = PValueThresholdFilter.render().threshold
         metric_filters = MetricsFilters.render()
 
-        observations_cnt = precomputes.groupby("group_name")["observation_cnt"].unique().to_dict()
+        observations_cnt = precomputes.groupby("group_name")["observation_cnt"].max().astype(int).to_dict()
         SampleRatioMismatchCheckExpander.render(observations_cnt)
 
         return cls(

tests/assistant/test_app.py

@@ -6,6 +6,7 @@
 
 from __future__ import annotations
 
+from types import SimpleNamespace
 from typing import Any
 from unittest.mock import AsyncMock, MagicMock, patch
 
@@ -36,60 +37,63 @@ def user_payload() -> dict[str, Any]:
 # ---------------------------------- Happy‑path test ----------------------------------
 
 
+@patch("assistant.app.logger.instrument_requests", lambda *a, **k: None)
+@patch("assistant.app.logger.instrument_sqlalchemy", lambda *a, **k: None)
 @patch("assistant.app.init_assistant_service")
 @patch("assistant.app.init_engine")
 @patch("assistant.app.init_vdb")
 def test_invoke_success(mock_vdb, mock_engine, mock_service, user_payload, dummy_usage, patch_configs):
-    """/invoke returns AgentResponse and disposes engine on shutdown."""
-
     fake_response = AssistantResponse(output="hi!", usage=dummy_usage, thinking="thinking")
-    # assistant_service is async, so we need an AsyncMock
+
+    # assistant_service — async
     mock_service_instance = AsyncMock()
     mock_service_instance.process_request.return_value = fake_response
     mock_service.return_value = mock_service_instance
 
-    # Mock DB engine + vdb
-    mock_engine_instance = AsyncMock()
-    mock_engine_instance.dispose = AsyncMock()
-    mock_engine.return_value = mock_engine_instance
+    # Engine — объект с async dispose()
+    engine = MagicMock()
+    engine.dispose = AsyncMock()
+    mock_engine.return_value = engine
+
+    # vdb — любой sync мок
     mock_vdb_instance = MagicMock()
     mock_vdb.return_value = mock_vdb_instance
 
     with TestClient(app) as client:
-        # --- request ---
         resp = client.post("/invoke", json=user_payload)
         assert resp.status_code == 200
         assert resp.json()["output"] == "hi!"
 
-    # After exiting TestClient, shutdown event has run
-    mock_engine_instance.dispose.assert_awaited_once()
+    engine.dispose.assert_awaited_once()
     mock_service_instance.process_request.assert_awaited_once()
 
 
 # ------------------------ Validation error (missing chat_uid) ------------------------
 
 
+@patch("assistant.app.logger.instrument_requests", lambda *a, **k: None)
+@patch("assistant.app.logger.instrument_sqlalchemy", lambda *a, **k: None)
 @patch("assistant.app.init_assistant_service", lambda *a, **kw: AsyncMock())
-@patch("assistant.app.init_engine", lambda *a, **kw: AsyncMock())
+@patch("assistant.app.init_engine", lambda *a, **kw: SimpleNamespace(dispose=AsyncMock()))
 @patch("assistant.app.init_vdb", lambda *a, **kw: MagicMock())
 def test_invoke_validation_error(user_payload, patch_configs):
-    """Test validation error when chat_uid is missing."""
     payload = user_payload.copy()
     payload.pop("chat_uid")
     with TestClient(app) as client:
         resp = client.post("/invoke", json=payload)
-        assert resp.status_code == 422  # FastAPI validation error
+        assert resp.status_code == 422
 
 
 #
 # ---------------------------- Error path: assistant raises ----------------------------
 
 
+@patch("assistant.app.logger.instrument_requests", lambda *a, **k: None)
+@patch("assistant.app.logger.instrument_sqlalchemy", lambda *a, **k: None)
 @patch("assistant.app.init_assistant_service")
-@patch("assistant.app.init_engine", lambda *a, **kw: AsyncMock())
+@patch("assistant.app.init_engine", lambda *a, **kw: SimpleNamespace(dispose=AsyncMock()))
 @patch("assistant.app.init_vdb", lambda *a, **kw: MagicMock())
 def test_invoke_service_error(mock_service, user_payload, patch_configs):
-    """Test error handling when assistant service raises exception."""
     err = RuntimeError("model crashed")
     mock_service_instance = AsyncMock()
     mock_service_instance.process_request.side_effect = err

tests/services/analytics/stat_functions/test_ttest_welch.py

@@ -171,3 +171,22 @@ def test_sample_size_t_test_edge_cases():
             alpha=0.05,
             beta=0.2,
         )
+
+
+def test_ttest_welch_zero_division_no_warning(recwarn):
+    """Tests that no RuntimeWarning is raised for 0/0 division with np.divide."""
+    mean_1 = np.array([10, 0])
+    var_1 = np.array([1, 1])
+    n_1 = np.array([100, 100])
+    mean_2 = np.array([12, 0])
+    var_2 = np.array([1, 1])
+    n_2 = np.array([100, 100])
+
+    result = ttest_welch(mean_1, var_1, n_1, mean_2, var_2, n_2)
+
+    # Check that no warnings were issued
+    assert len(recwarn) == 0
+
+    # The result for the 0/0 case should be np.inf with the np.divide fix
+    expected_diff_ratio = np.array([0.2, np.inf])
+    assert np.allclose(result.diff_ratio, expected_diff_ratio, equal_nan=True)