Skip to content

Commit fa01820

Browse files
author
Florian Meriaux
committed
add documentation notes
1 parent 3e3d8c4 commit fa01820

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

dist/cleanup/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65449,8 +65449,8 @@ const supportedPackageManager = [
6544965449
path_1.join(os_1.default.homedir(), '.ivy2', 'cache'),
6545065450
path_1.join(os_1.default.homedir(), '.sbt'),
6545165451
getCoursierCachePath(),
65452-
//TODO: comment the reason of exclusions
6545365452
'!' + path_1.join(os_1.default.homedir(), '.sbt', '*.lock'),
65453+
// Avoid SNAPSHOT resolution problems by forcing the deletion of these files (due to ideological gaps in maven/ivy).
6545465454
'!' + path_1.join(os_1.default.homedir(), '**', 'ivydata-*.properties')
6545565455
],
6545665456
pattern: ['**/*.sbt', '**/project/build.properties', '**/project/**.{scala,sbt}']

dist/setup/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100654,8 +100654,8 @@ const supportedPackageManager = [
100654100654
path_1.join(os_1.default.homedir(), '.ivy2', 'cache'),
100655100655
path_1.join(os_1.default.homedir(), '.sbt'),
100656100656
getCoursierCachePath(),
100657-
//TODO: comment the reason of exclusions
100658100657
'!' + path_1.join(os_1.default.homedir(), '.sbt', '*.lock'),
100658+
// Avoid SNAPSHOT resolution problems by forcing the deletion of these files (due to ideological gaps in maven/ivy).
100659100659
'!' + path_1.join(os_1.default.homedir(), '**', 'ivydata-*.properties')
100660100660
],
100661100661
pattern: ['**/*.sbt', '**/project/build.properties', '**/project/**.{scala,sbt}']

src/cache.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ const supportedPackageManager: PackageManager[] = [
3939
join(os.homedir(), '.ivy2', 'cache'),
4040
join(os.homedir(), '.sbt'),
4141
getCoursierCachePath(),
42-
//TODO: comment the reason of exclusions
42+
// Some files should not be cached to avoid resolution problems.
43+
// In particular the resolution of snapshots (ideological gap between maven/ivy).
4344
'!' + join(os.homedir(), '.sbt', '*.lock'),
4445
'!' + join(os.homedir(), '**', 'ivydata-*.properties')
4546
],
@@ -84,8 +85,7 @@ export async function restore(id: string) {
8485
core.saveState(STATE_CACHE_PRIMARY_KEY, primaryKey);
8586
if (primaryKey.endsWith('-')) {
8687
throw new Error(
87-
`No file in ${process.cwd()} matched to [${
88-
packageManager.pattern
88+
`No file in ${process.cwd()} matched to [${packageManager.pattern
8989
}], make sure you have checked out the target repository`
9090
);
9191
}

0 commit comments

Comments
 (0)