deep link: support HTML content type #129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianp
force-pushed
the
deep_link_html
branch
from
4fcbf58 to
d7f5a82
Compare
christianp
force-pushed
the
deep_link_html
branch
from
d7f5a82 to
5f810d8
Compare
They're automatically generated, so I don't think we need to lint them.
Apparently pylint wants you to get BaseException and Exception from builtins
As well as formatting changes, there are a few methods which pylint said had too many positional arguments, so I've changed them to keyword arguments. Anything using those methods will have to make sure the keyword arguments are named.
christianp
force-pushed
the
deep_link_html
branch
from
5f810d8 to
7109b6a
Compare
The DeepLink object now has a `get_accept_types` method which will return the list of content types that the platform will accept for this launch. The DeepLinkResource object now has `get_html` and `set_html` methods, which are used when the type is `"html"`.
christianp
force-pushed
the
deep_link_html
branch
from
7109b6a to
a4b4cee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DeepLink object now has a
get_accept_typesmethod which will return the list of content types that the platform will accept for this launch.The DeepLinkResource object now has
get_htmlandset_htmlmethods, which are used when the type is"html".