Skip to content

Commit 8127776

Browse files
committed
Take access timestamp from arg provider
Signed-off-by: Dmitry Sulman <[email protected]>
1 parent 07e52c4 commit 8127776

File tree

2 files changed

+8
-2
lines changed
  • logback-access-reactor-netty/src

2 files changed

+8
-2
lines changed

logback-access-reactor-netty/src/main/kotlin/io/github/dmitrysulman/logback/access/reactor/netty/AccessEvent.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class AccessEvent(
3737
context: AccessContext,
3838
) : IAccessEvent,
3939
Serializable {
40-
private val _timeStamp = System.currentTimeMillis()
40+
private val _timeStamp by lazy { _serverAdapter.requestTimestamp }
4141
private val _sequenceNumber = context.sequenceNumberGenerator?.nextSequenceNumber() ?: 0
4242
private val _elapsedTime = argProvider.duration()
4343
private val _elapsedTimeSeconds = _elapsedTime / 1000
@@ -152,7 +152,7 @@ class AccessEvent(
152152
responseHeaderMap
153153
requestHeaderMap
154154
threadName
155-
serverAdapter.requestTimestamp
155+
timeStamp
156156
}
157157

158158
override fun getRequest(): HttpServletRequest? = null

logback-access-reactor-netty/src/test/kotlin/io/github/dmitrysulman/logback/access/reactor/netty/AccessEventTests.kt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ class AccessEventTests {
5454

5555
verify(exactly = 1) { mockContext.sequenceNumberGenerator }
5656
verify(exactly = 1) { mockArgProvider.duration() }
57+
verify(exactly = 0) { mockArgProvider.accessDateTime() }
5758
verify(exactly = 0) { mockArgProvider.method() }
5859
verify(exactly = 0) { mockArgProvider.uri() }
5960
verify(exactly = 0) { mockArgProvider.protocol() }
@@ -68,6 +69,7 @@ class AccessEventTests {
6869
verify(exactly = 0) { mockConnectionInformation.hostPort() }
6970

7071
repeat(2) {
72+
accessEvent.timeStamp
7173
accessEvent.method
7274
accessEvent.requestURI
7375
accessEvent.queryString
@@ -117,6 +119,7 @@ class AccessEventTests {
117119
mockArgProvider: AccessLogArgProvider,
118120
mockConnectionInformation: ConnectionInformation,
119121
) {
122+
verify(exactly = 1) { mockArgProvider.accessDateTime() }
120123
verify(exactly = 1) { mockArgProvider.method() }
121124
verify(exactly = 3) { mockArgProvider.uri() }
122125
verify(exactly = 1) { mockArgProvider.protocol() }
@@ -300,6 +303,7 @@ class AccessEventTests {
300303
every { mockConnectionInformation.connectionRemoteAddress() } returns null
301304
val mockArgProvider = mockk<AccessLogArgProvider>()
302305
every { mockArgProvider.duration() } returns 0
306+
every { mockArgProvider.accessDateTime() } returns null
303307
every { mockArgProvider.method() } returns null
304308
every { mockArgProvider.uri() } returns null
305309
every { mockArgProvider.protocol() } returns null
@@ -312,6 +316,7 @@ class AccessEventTests {
312316

313317
val accessEvent = AccessEvent(mockArgProvider, mockContext)
314318

319+
accessEvent.timeStamp.shouldBeZero()
315320
accessEvent.method shouldBe NA
316321
accessEvent.requestURI shouldBe NA
317322
accessEvent.queryString shouldBe NA
@@ -489,6 +494,7 @@ class AccessEventTests {
489494
accessEvent.getAttribute(ATTRIBUTE) shouldBe NA
490495
accessEvent.requestContent.shouldBeEmpty()
491496
accessEvent.responseContent.shouldBeEmpty()
497+
accessEvent.timeStamp shouldBe TIMESTAMP
492498
accessEvent.serverAdapter.shouldNotBeNull()
493499
accessEvent.serverAdapter.requestTimestamp shouldBe TIMESTAMP
494500
accessEvent.serverAdapter.contentLength shouldBe CONTENT_LENGTH

0 commit comments

Comments
 (0)