Skip to content

[Code Issue] Unnecessary assignment? #164

@microwish

Description

@microwish

Looks like sometimes this assignment env->kvs = envs; in the body of Environment::Init method in env.h (

env->kvs = envs;
) is not necessary.

Assume we don't expect to re-assign new environment variables once we already assigned non-empty values, it might be better if we first check whetherEnvironment::kvs is empty, if it's empty, we can do this assignment, otherwise, we won't.

If I'm on the track, would like to make a PR.

Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions