Fix undefined behavior in base_score (#646)

hcho3 · web-flow · commit dd1562cd574b · 2025-11-12T13:52:24.000-08:00
diff --git a/src/model_loader/detail/xgboost.cc b/src/model_loader/detail/xgboost.cc
@@ -73,7 +73,7 @@ std::vector<float> ParseBaseScore(std::string const& str) {
     }
   } else {
     // Scalar base_score (from XGBoost <3.1)
-    parsed_base_score = {std::stof(str)};
+    parsed_base_score = std::vector<float>{std::stof(str)};
   }
   return parsed_base_score;
 }

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ std::vector<float> ParseBaseScore(std::string const& str) {`
`73`	`73`	`}`
`74`	`74`	`} else {`
`75`	`75`	`// Scalar base_score (from XGBoost <3.1)`
`76`		`- parsed_base_score = {std::stof(str)};`
	`76`	`+ parsed_base_score = std::vector<float>{std::stof(str)};`
`77`	`77`	`}`
`78`	`78`	`return parsed_base_score;`
`79`	`79`	`}`