Merge pull request #101 from dmoliveira/my_opencode-e20-budget-verification

Complete E20-T4 budget verification coverage

Author: dmoliveira

CHANGELOG.md

@@ -132,6 +132,8 @@ All notable changes to this project are documented in this file.
 - Integrated budget runtime evaluation into `/start-work` and `/start-work recover`, including `budget_stopped` hard-stop behavior and actionable continuation recommendations.
 - Integrated budget diagnostics into unified `/doctor` summary checks and expanded selftest/install smoke coverage for budget profile+override workflows.
 - Updated README and roadmap notes to document budget workload tuning commands and Epic 20 Task 20.3 completion.
+- Expanded budget verification coverage for invalid override input handling and usage guidance in selftest.
+- Marked Epic 20 Task 20.4 complete and promoted Epic 20 status to done in the roadmap.
 
 ## v0.2.0 - 2026-02-12
 

IMPLEMENTATION_ROADMAP.md

@@ -734,7 +734,7 @@ Every command-oriented epic must ship all of the following:
 
 ## Epic 20 - Execution Budget Guardrails
 
-**Status:** `in_progress`
+**Status:** `done`
 **Priority:** High
 **Goal:** Prevent runaway autonomous runs by enforcing configurable limits for time, tool calls, and token usage.
 **Depends on:** Epic 2, Epic 11
@@ -754,12 +754,13 @@ Every command-oriented epic must ship all of the following:
   - [x] Subtask 20.3.2: Expose budget consumption in doctor/debug outputs
   - [x] Subtask 20.3.3: Document budget tuning by workload type
   - [x] Notes: Added `scripts/budget_command.py`, wired `/budget*` aliases in `opencode.json`, integrated budget checks into unified `/doctor`, and expanded README/install/selftest flows for profile+override diagnostics.
-- [ ] Task 20.4: Verification
-  - [ ] Subtask 20.4.1: Add tests for threshold crossings and stop behavior
-  - [ ] Subtask 20.4.2: Add tests for override and reset flows
-  - [ ] Subtask 20.4.3: Add install-test smoke checks
-- [ ] Exit criteria: runaway loops are prevented by hard and soft limits
-- [ ] Exit criteria: budget stops provide actionable continuation guidance
+- [x] Task 20.4: Verification
+  - [x] Subtask 20.4.1: Add tests for threshold crossings and stop behavior
+  - [x] Subtask 20.4.2: Add tests for override and reset flows
+  - [x] Subtask 20.4.3: Add install-test smoke checks
+  - [x] Notes: Expanded `scripts/selftest.py` with threshold-stop, override/reset, and invalid-override checks; install smoke now exercises `/budget status|override|doctor|override --clear` flows.
+- [x] Exit criteria: runaway loops are prevented by hard and soft limits
+- [x] Exit criteria: budget stops provide actionable continuation guidance
 
 ---
 

README.md

@@ -158,6 +158,12 @@ Examples:
 /budget doctor --json
 ```
 
+Task 20.4 verification notes:
+
+- selftest covers PASS/WARN/FAIL budget threshold evaluation and `budget_stopped` hard-stop behavior in `/start-work`.
+- selftest covers override apply/clear paths plus invalid override input rejection with deterministic usage guidance.
+- install smoke includes `/budget status`, `/budget override`, `/budget doctor`, and `/budget override --clear` checks.
+
 ## Installed plugin stack 🔌
 
 - `@mohak34/opencode-notifier@latest` - desktop and sound alerts for completion, errors, and permission prompts.

scripts/selftest.py

@@ -2223,6 +2223,30 @@ def run_bg(*args: str) -> subprocess.CompletedProcess[str]:
             "budget override should persist explicit limits and reason",
         )
 
+        budget_override_invalid = subprocess.run(
+            [
+                sys.executable,
+                str(BUDGET_SCRIPT),
+                "override",
+                "--tool-call-count",
+                "0",
+                "--json",
+            ],
+            capture_output=True,
+            text=True,
+            env=refactor_env,
+            check=False,
+            cwd=REPO_ROOT,
+        )
+        expect(
+            budget_override_invalid.returncode == 2,
+            "budget override should reject non-positive numeric values",
+        )
+        expect(
+            "usage: /budget" in budget_override_invalid.stdout,
+            "budget override invalid path should emit usage guidance",
+        )
+
         budget_doctor = subprocess.run(
             [sys.executable, str(BUDGET_SCRIPT), "doctor", "--json"],
             capture_output=True,