Merge pull request #492 from dmoliveira/chore/pr-guard-lint-evidence

Recognize uvx lint evidence for PR guards

Author: dmoliveira

plugin/gateway-core/dist/hooks/shared/validation-command-matcher.js

@@ -1,5 +1,6 @@
 const LEADING_ENV_ASSIGNMENTS = /^(?:[A-Za-z_][A-Za-z0-9_]*=(?:"[^"]*"|'[^']*'|\S+)\s+)*/;
-const LINT_COMMAND = /^(eslint\b|ruff\s+check\b|ruff\s+format\s+--check\b|npm(?:\s+--prefix\s+\S+)?\s+run\s+lint\b|pnpm(?:\s+(?:--filter\s+\S+)*)?\s+(?:run\s+)?lint\b|yarn\s+(?:run\s+)?lint\b|biome\s+check\b|golangci-lint\b|cargo\s+clippy\b|make\s+validate\b)/i;
+const UV_WRAPPER = "(?:uvx|uv\\s+run)\\s+";
+const LINT_COMMAND = new RegExp(`^(?:${UV_WRAPPER})?(?:eslint\\b|ruff\\s+check\\b|ruff\\s+format\\s+--check\\b|npm(?:\\s+--prefix\\s+\\S+)?\\s+run\\s+lint\\b|pnpm(?:\\s+(?:--filter\\s+\\S+)*)?\\s+(?:run\\s+)?lint\\b|yarn\\s+(?:run\\s+)?lint\\b|biome\\s+check\\b|golangci-lint\\b|cargo\\s+clippy\\b|make\\s+validate\\b)`, "i");
 const TEST_COMMAND = /^(npm(?:\s+--prefix\s+\S+)?\s+(run\s+)?test\b|pnpm(?:\s+(?:--filter\s+\S+)*)?\s+(?:run\s+)?test\b|yarn\s+(?:run\s+)?test\b|bun\s+test\b|node\s+--test\b|(?:npm|pnpm)\s+exec\s+vitest\b|npx\s+vitest\b|python\d?\s+-m\s+pytest\b|python\d?\s+-m\s+unittest\b|uv\s+run\s+pytest\b|pytest\b|vitest\b|jest\b|go\s+test\b|cargo\s+test\b|pre-commit\s+run\b|make\s+selftest\b|make\s+install-test\b|python\d?\s+scripts\/selftest\.py\b|\.\/scripts\/ci-check\b.*\btest[s]?\b)/i;
 const TYPECHECK_COMMAND = /^(tsc\b|npm(?:\s+--prefix\s+\S+)?\s+run\s+typecheck\b|pnpm(?:\s+(?:--filter\s+\S+)*)?\s+(?:run\s+)?typecheck\b|yarn\s+(?:run\s+)?typecheck\b|pyright\b|mypy\b|cargo\s+check\b|go\s+vet\b)/i;
 const BUILD_COMMAND = /^(npm(?:\s+--prefix\s+\S+)?\s+run\s+build\b|pnpm(?:\s+(?:--filter\s+\S+)*)?\s+(?:run\s+)?build\b|yarn\s+(?:run\s+)?build\b|vite\s+build\b|next\s+build\b|cargo\s+build\b|go\s+build\b)/i;

plugin/gateway-core/src/hooks/shared/validation-command-matcher.ts

@@ -1,7 +1,11 @@
 import type { ValidationEvidenceCategory } from "../validation-evidence-ledger/evidence.js"
 
 const LEADING_ENV_ASSIGNMENTS = /^(?:[A-Za-z_][A-Za-z0-9_]*=(?:"[^"]*"|'[^']*'|\S+)\s+)*/
-const LINT_COMMAND = /^(eslint\b|ruff\s+check\b|ruff\s+format\s+--check\b|npm(?:\s+--prefix\s+\S+)?\s+run\s+lint\b|pnpm(?:\s+(?:--filter\s+\S+)*)?\s+(?:run\s+)?lint\b|yarn\s+(?:run\s+)?lint\b|biome\s+check\b|golangci-lint\b|cargo\s+clippy\b|make\s+validate\b)/i
+const UV_WRAPPER = "(?:uvx|uv\\s+run)\\s+"
+const LINT_COMMAND = new RegExp(
+  `^(?:${UV_WRAPPER})?(?:eslint\\b|ruff\\s+check\\b|ruff\\s+format\\s+--check\\b|npm(?:\\s+--prefix\\s+\\S+)?\\s+run\\s+lint\\b|pnpm(?:\\s+(?:--filter\\s+\\S+)*)?\\s+(?:run\\s+)?lint\\b|yarn\\s+(?:run\\s+)?lint\\b|biome\\s+check\\b|golangci-lint\\b|cargo\\s+clippy\\b|make\\s+validate\\b)`,
+  "i",
+)
 const TEST_COMMAND = /^(npm(?:\s+--prefix\s+\S+)?\s+(run\s+)?test\b|pnpm(?:\s+(?:--filter\s+\S+)*)?\s+(?:run\s+)?test\b|yarn\s+(?:run\s+)?test\b|bun\s+test\b|node\s+--test\b|(?:npm|pnpm)\s+exec\s+vitest\b|npx\s+vitest\b|python\d?\s+-m\s+pytest\b|python\d?\s+-m\s+unittest\b|uv\s+run\s+pytest\b|pytest\b|vitest\b|jest\b|go\s+test\b|cargo\s+test\b|pre-commit\s+run\b|make\s+selftest\b|make\s+install-test\b|python\d?\s+scripts\/selftest\.py\b|\.\/scripts\/ci-check\b.*\btest[s]?\b)/i
 const TYPECHECK_COMMAND = /^(tsc\b|npm(?:\s+--prefix\s+\S+)?\s+run\s+typecheck\b|pnpm(?:\s+(?:--filter\s+\S+)*)?\s+(?:run\s+)?typecheck\b|yarn\s+(?:run\s+)?typecheck\b|pyright\b|mypy\b|cargo\s+check\b|go\s+vet\b)/i
 const BUILD_COMMAND = /^(npm(?:\s+--prefix\s+\S+)?\s+run\s+build\b|pnpm(?:\s+(?:--filter\s+\S+)*)?\s+(?:run\s+)?build\b|yarn\s+(?:run\s+)?build\b|vite\s+build\b|next\s+build\b|cargo\s+build\b|go\s+build\b)/i

plugin/gateway-core/test/event-audit.test.mjs

@@ -18,10 +18,10 @@ test("gateway event audit writes dispatch entries when enabled", async () => {
     const lines = readFileSync(auditPath, "utf-8")
       .split(/\r?\n/)
       .filter(Boolean)
+      .map((line) => JSON.parse(line))
     assert.ok(lines.length >= 1)
-    const first = JSON.parse(lines[0])
-    assert.equal(first.reason_code, "event_dispatch")
-    assert.equal(first.event_type, "session.idle")
+    const dispatch = lines.find((entry) => entry.reason_code === "event_dispatch")
+    assert.equal(dispatch?.event_type, "session.idle")
   } finally {
     if (previous === undefined) {
       delete process.env.MY_OPENCODE_GATEWAY_EVENT_AUDIT

plugin/gateway-core/test/pr-body-evidence-guard-hook.test.mjs

@@ -338,6 +338,54 @@ test("pr-body-evidence-guard accepts make validate lint evidence from structured
   }
 })
 
+test("pr-body-evidence-guard accepts uvx ruff lint evidence from structured bash output", async () => {
+  const directory = mkdtempSync(join(tmpdir(), "gateway-pr-body-"))
+  try {
+    const plugin = GatewayCorePlugin({
+      directory,
+      config: {
+        hooks: {
+          enabled: true,
+          order: ["validation-evidence-ledger", "pr-body-evidence-guard"],
+          disabled: ["pr-readiness-guard"],
+        },
+        validationEvidenceLedger: {
+          enabled: true,
+        },
+        doneProofEnforcer: {
+          enabled: true,
+          requiredMarkers: ["lint"],
+          requireLedgerEvidence: true,
+          allowTextFallback: false,
+        },
+        prBodyEvidenceGuard: {
+          enabled: true,
+          requireSummarySection: true,
+          requireValidationSection: true,
+          requireValidationEvidence: true,
+          allowUninspectableBody: false,
+        },
+      },
+    })
+
+    await plugin["tool.execute.before"](
+      { tool: "bash", sessionID: "session-pr-body-uvx-ruff" },
+      { args: { command: "uvx ruff check ." } },
+    )
+    await plugin["tool.execute.after"](
+      { tool: "bash", sessionID: "session-pr-body-uvx-ruff" },
+      { output: { stdout: "All checks passed!", stderr: "" } },
+    )
+
+    await plugin["tool.execute.before"](
+      { tool: "bash", sessionID: "session-pr-body-uvx-ruff" },
+      { args: { command: 'gh pr create --title "x" --body "## Summary\n- item\n## Validation\n- uvx ruff check ."' } },
+    )
+  } finally {
+    rmSync(directory, { recursive: true, force: true })
+  }
+})
+
 test("pr-body-evidence-guard uses LLM fallback for semantic summary and validation sections", async () => {
   const hook = createPrBodyEvidenceGuardHook({
     directory: process.cwd(),

plugin/gateway-core/test/validation-command-matcher.test.mjs

@@ -20,6 +20,8 @@ test("validation-command-matcher covers run and prefix package-manager forms", (
 test("validation-command-matcher exposes validation truthiness", () => {
   assert.equal(isValidationCommand("make validate"), true)
   assert.deepEqual(classifyValidationCommand("make validate"), ["lint"])
+  assert.deepEqual(classifyValidationCommand("uvx ruff check ."), ["lint"])
+  assert.deepEqual(classifyValidationCommand("uv run ruff check src"), ["lint"])
   assert.equal(isValidationCommand("git status --short"), false)
 })