Add FLYING packet back for backwards compat

Fixes #1275

Author: dmulloy2

src/main/java/com/comphenix/protocol/PacketType.java

@@ -351,7 +351,7 @@ public static class Client extends PacketTypeEnum {
 			public static final PacketType POSITION =                     new PacketType(PROTOCOL, SENDER, 0x11, "Flying$PacketPlayInPosition", "Flying$Position", "CPacketPlayer$Position");
 			public static final PacketType POSITION_LOOK =                new PacketType(PROTOCOL, SENDER, 0x12, "Flying$PacketPlayInPositionLook", "Flying$PositionLook", "CPacketPlayer$PositionRotation");
 			public static final PacketType LOOK =                         new PacketType(PROTOCOL, SENDER, 0x13, "Flying$PacketPlayInLook", "Flying$Look", "CPacketPlayer$Rotation");
-			public static final PacketType GROUND =                       new PacketType(PROTOCOL, SENDER, 0x14, "Flying$d", "Flying", "CPacketPlayer");
+			public static final PacketType GROUND =                       new PacketType(PROTOCOL, SENDER, 0x14, "Flying$d");
 			public static final PacketType VEHICLE_MOVE =                 new PacketType(PROTOCOL, SENDER, 0x15, "VehicleMove", "CPacketVehicleMove");
 			public static final PacketType BOAT_MOVE =                    new PacketType(PROTOCOL, SENDER, 0x16, "BoatMove", "CPacketSteerBoat");
 			public static final PacketType PICK_ITEM =                    new PacketType(PROTOCOL, SENDER, 0x17, "PickItem");
@@ -386,6 +386,12 @@ public static class Client extends PacketTypeEnum {
 			@Deprecated
 			public static final PacketType TRANSACTION =                  new PacketType(PROTOCOL, SENDER, 255, "Transaction", "CPacketConfirmTransaction");
 
+			/**
+			 * @deprecated Removed in 1.17
+			 */
+			@Deprecated
+			public static final PacketType FLYING = 					  new PacketType(PROTOCOL, SENDER, 254, "Flying", "CPacketPlayer");
+
 			private final static Client INSTANCE = new Client();
 
 			// Prevent accidental construction

src/main/java/com/comphenix/protocol/ProtocolLogger.java

@@ -20,6 +20,7 @@
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
+import com.comphenix.protocol.utility.MinecraftVersion;
 import org.bukkit.plugin.Plugin;
 
 /**
@@ -82,4 +83,10 @@ public static void debug(String message, Throwable ex) {
 			logger.log(Level.WARNING, "[Debug] " + message, ex);
 		}
 	}
+
+	public static void warnAbove(MinecraftVersion version, String message, Object... args) {
+		if (version.atOrAbove()) {
+			log(Level.WARNING, message, args);
+		}
+	}
 }

src/main/java/com/comphenix/protocol/injector/packet/PacketRegistry.java

@@ -358,6 +358,10 @@ public static Optional<Class<?>> tryGetPacketClass(PacketType type) {
 
 		// Then try looking up the class names
 		Class<?> clazz = searchForPacket(type.getClassNames());
+		if (clazz != null) {
+			// we'd like for it to be associated correctly from the get-go; this is OK on older versions though
+			ProtocolLogger.warnAbove(type.getCurrentVersion(), "Updating associated class for {0} to {1}", type.name(), clazz);
+		}
 
 		// cache it for next time
 		associate(type, clazz);

src/main/java/com/comphenix/protocol/wrappers/EnumWrappers.java

@@ -565,6 +565,7 @@ private static Class<?> getEnum(Class<?> clazz, int index) {
 		List<Field> enumFields = FuzzyReflection.fromClass(clazz, true).getFieldListByType(Enum.class);
 		if (enumFields.size() <= index) {
 			// also probably not supported
+			ProtocolLogger.debug("Enum field not found at index {0} of {1}", index, clazz);
 			return null;
 		}