Fix a few issues with debug logging

Also add a warning if the updater section is missing

Author: dmulloy2

modules/API/src/main/java/com/comphenix/protocol/ProtocolConfig.java

@@ -157,6 +157,9 @@ private void loadSections(boolean copyDefaults) {
 		}
 		if (global != null) {
 			updater = global.getConfigurationSection(SECTION_AUTOUPDATER);
+			if (updater.getValues(true).isEmpty()) {
+				plugin.getLogger().warning("Updater section is missing, regenerate your config!");
+			}
 		}
 
 		// Automatically copy defaults

modules/API/src/main/java/com/comphenix/protocol/ProtocolLibrary.java

@@ -71,7 +71,6 @@ protected static void init(Plugin plugin, ProtocolConfig config, ProtocolManager
 		ProtocolLibrary.reporter = reporter;
 		ProtocolLibrary.executorAsync = executorAsync;
 		ProtocolLibrary.executorSync = executorSync;
-		ProtocolLogger.init(plugin);
 		initialized = true;
 	}
 

modules/API/src/main/java/com/comphenix/protocol/ProtocolLogger.java

@@ -18,25 +18,24 @@
 
 import java.text.MessageFormat;
 import java.util.logging.Level;
-import java.util.logging.Logger;
 
 import org.bukkit.plugin.Plugin;
 
 /**
  * @author dmulloy2
  */
 public class ProtocolLogger {
-	private static Logger logger;
+	private static Plugin plugin;
 
 	protected static void init(Plugin plugin) {
-		ProtocolLogger.logger = plugin.getLogger();
+		ProtocolLogger.plugin = plugin;
 	}
 
 	private static boolean isDebugEnabled() {
 		try {
-			return ProtocolLibrary.getConfig().isDebug();
-		} catch (Throwable ex) {
-			return true; // For testing
+			return plugin.getConfig().getBoolean("global.debug", false);
+		} catch (Throwable ex) { // Maybe we're testing or something
+			return false;
 		}
 	}
 
@@ -47,7 +46,7 @@ private static boolean isDebugEnabled() {
 	 * @param args Arguments to format in
 	 */
 	public static void log(Level level, String message, Object... args) {
-		logger.log(level, MessageFormat.format(message, args));
+		plugin.getLogger().log(level, MessageFormat.format(message, args));
 	}
 
 	/**
@@ -66,16 +65,12 @@ public static void log(String message, Object... args) {
 	 * @param ex Exception to log
 	 */
 	public static void log(Level level, String message, Throwable ex) {
-		logger.log(level, message, ex);
+		plugin.getLogger().log(level, message, ex);
 	}
 
 	public static void debug(String message, Object... args) {
 		if (isDebugEnabled()) {
-			if (logger != null) {
-				log("[Debug] " + message, args);
-			} else {
-				System.out.println("[Debug] " + MessageFormat.format(message, args));
-			}
+			log("[Debug] " + message, args);
 		}
 	}
 }

modules/ProtocolLib/src/main/java/com/comphenix/protocol/ProtocolLib.java

@@ -148,8 +148,10 @@ private enum ProtocolCommand {
 
 	@Override
 	public void onLoad() {
-		// Load configuration
+		// Logging
 		logger = getLoggerSafely();
+		ProtocolLogger.init(this);
+
 		Application.registerPrimaryThread();
 
 		// Initialize enhancer factory