Skip to content

Commit 76432f9

Browse files
committed
Well, it works for Mojang mapped anyways
1 parent f0468e0 commit 76432f9

File tree

2 files changed

+26
-31
lines changed

2 files changed

+26
-31
lines changed

src/main/java/com/comphenix/protocol/PacketType.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import com.google.common.base.Preconditions;
2727
import com.google.common.collect.ComparisonChain;
2828
import com.google.common.collect.Iterables;
29-
3029
/**
3130
* Represents the type of a packet in a specific protocol.
3231
* <p>
@@ -478,8 +477,8 @@ public static class Client extends PacketTypeEnum {
478477
public static final PacketType UPDATE_SIGN = new PacketType(PROTOCOL, SENDER, 0x35, "SignUpdate", "UpdateSign", "CPacketUpdateSign");
479478
public static final PacketType ARM_ANIMATION = new PacketType(PROTOCOL, SENDER, 0x36, "Swing", "ArmAnimation", "CPacketAnimation");
480479
public static final PacketType SPECTATE = new PacketType(PROTOCOL, SENDER, 0x37, "TeleportToEntity", "Spectate", "CPacketSpectate");
481-
public static final PacketType USE_ITEM = new PacketType(PROTOCOL, SENDER, 0x38, "UseItemOn", "CPacketPlayerTryUseItemOnBlock");
482-
public static final PacketType BLOCK_PLACE = new PacketType(PROTOCOL, SENDER, 0x39, "UseItem", "BlockPlace", "CPacketPlayerTryUseItem");
480+
public static final PacketType USE_ITEM = new PacketType(PROTOCOL, SENDER, 0x38, "UseItemOn", "UseItem", "CPacketPlayerTryUseItemOnBlock");
481+
public static final PacketType BLOCK_PLACE = new PacketType(PROTOCOL, SENDER, 0x39, "BlockPlace", "CPacketPlayerTryUseItem");
483482

484483
/**
485484
* @deprecated Removed in 1.17

src/test/java/com/comphenix/protocol/wrappers/WrappedDataWatcherTest.java

Lines changed: 24 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,11 @@
1818
import com.comphenix.protocol.wrappers.WrappedDataWatcher.Registry;
1919
import com.comphenix.protocol.wrappers.WrappedDataWatcher.Serializer;
2020
import com.comphenix.protocol.wrappers.WrappedDataWatcher.WrappedDataWatcherObject;
21+
2122
import net.minecraft.world.entity.projectile.EntityEgg;
2223
import org.bukkit.craftbukkit.v1_20_R4.entity.CraftEgg;
2324
import org.bukkit.craftbukkit.v1_20_R4.entity.CraftEntity;
25+
import org.bukkit.entity.Entity;
2426
import org.junit.jupiter.api.BeforeAll;
2527
import org.junit.jupiter.api.Disabled;
2628
import org.junit.jupiter.api.Test;
@@ -33,46 +35,47 @@
3335
* @author dmulloy2
3436
*/
3537
public class WrappedDataWatcherTest {
38+
private static Entity mockEntity;
3639

3740
@BeforeAll
3841
public static void prepare() {
3942
BukkitInitialization.initializeAll();
43+
44+
EntityEgg nmsEgg = new EntityEgg(null, 0, 0, 0);
45+
mockEntity = new CraftEgg(null, nmsEgg);
4046
}
4147

4248
@Test
43-
@Disabled // TODO -- need to fix data watchers
49+
@Disabled // TODO -- SETTER is null
4450
public void testBytes() {
45-
// Create a fake lightning strike and get its watcher
46-
EntityEgg nmsEgg = new EntityEgg(null, 0, 0, 0);
47-
CraftEntity craftEgg = new CraftEgg(null, nmsEgg);
48-
WrappedDataWatcher wrapper = WrappedDataWatcher.getEntityWatcher(craftEgg);
51+
WrappedDataWatcher watcher = WrappedDataWatcher.getEntityWatcher(mockEntity);
4952

50-
WrappedWatchableObject watchable = wrapper.getWatchableObject(0);
53+
WrappedWatchableObject watchable = watcher.getWatchableObject(0);
5154
WrappedDataWatcherObject object = watchable.getWatcherObject();
5255

5356
// Make sure the serializers work
5457
assertEquals(object.getSerializer(), Registry.get(Byte.class));
5558

5659
// Make sure we can set existing objects
57-
wrapper.setObject(0, (byte) 21);
58-
assertEquals(21, (byte) wrapper.getByte(0));
60+
watcher.setObject(0, (byte) 21);
61+
assertEquals(21, (byte) watcher.getByte(0));
5962
}
6063

6164
@Test
62-
@Disabled // TODO -- need to fix data watchers
65+
@Disabled // TODO -- SETTER is null
6366
public void testStrings() {
64-
WrappedDataWatcher wrapper = new WrappedDataWatcher();
67+
WrappedDataWatcher watcher = WrappedDataWatcher.getEntityWatcher(mockEntity);
6568

6669
// Make sure we can create watcher objects
6770
Serializer serializer = Registry.get(String.class);
6871
WrappedDataWatcherObject object = new WrappedDataWatcherObject(3, serializer);
69-
wrapper.setObject(object, "Test");
72+
watcher.setObject(object, "Test");
7073

71-
assertEquals(wrapper.getString(3), "Test");
74+
assertEquals(watcher.getString(3), "Test");
7275
}
7376

7477
@Test
75-
@Disabled // TODO -- need to fix data watchers
78+
@Disabled // TODO -- need a better example for floats
7679
public void testFloats() {
7780
WrappedDataWatcher wrapper = new WrappedDataWatcher();
7881

@@ -85,35 +88,28 @@ public void testFloats() {
8588
}
8689

8790
@Test
88-
@Disabled // TODO -- need to fix data watchers
8991
public void testSerializers() {
9092
Serializer blockPos = Registry.get(net.minecraft.core.BlockPosition.class, false);
9193
Serializer optionalBlockPos = Registry.get(net.minecraft.core.BlockPosition.class, true);
9294
assertNotSame(blockPos, optionalBlockPos);
9395

94-
// assertNull(Registry.get(ItemStack.class, false));
96+
// assertNull(Registry.get(ItemStack.class, false)); // TODO
9597
assertNotNull(Registry.get(UUID.class, true));
9698
}
9799

98100
@Test
99-
@Disabled // TODO -- need to fix data watchers
100101
public void testHasIndex() {
101-
WrappedDataWatcher watcher = new WrappedDataWatcher();
102-
Serializer serializer = Registry.get(Integer.class);
103-
104-
assertFalse(watcher.hasIndex(0));
105-
watcher.setObject(0, serializer, 1);
106-
assertTrue(watcher.hasIndex(0));
102+
WrappedDataWatcher watcher = WrappedDataWatcher.getEntityWatcher(mockEntity);
103+
assertTrue(watcher.hasIndex(1));
104+
assertFalse(watcher.hasIndex(9999));
107105
}
108106

109107
@Test
110-
@Disabled // TODO -- need to fix data watchers
111108
public void testDeepClone() {
112-
WrappedDataWatcher watcher = new WrappedDataWatcher();
113-
watcher.setObject(0, Registry.get(Integer.class), 1);
114-
109+
WrappedDataWatcher watcher = WrappedDataWatcher.getEntityWatcher(mockEntity);
115110
WrappedDataWatcher cloned = watcher.deepClone();
116-
assertEquals(1, cloned.asMap().size());
117-
assertEquals(1, (Object) cloned.getInteger(0));
111+
112+
assertEquals(watcher.size(), cloned.size());
113+
assertEquals(watcher.getObject(1), cloned.getObject(1));
118114
}
119115
}

0 commit comments

Comments
 (0)