Skip to content

Commit d83dd9a

Browse files
authored
Get around expensive validate calls (#2318)
1 parent ab32f93 commit d83dd9a

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/main/java/com/comphenix/protocol/injector/EntityUtilities.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,9 @@ private Collection<?> getTrackedPlayers(Entity entity) {
178178
Validate.notNull(entity, "entity cannot be null");
179179

180180
Object trackerEntry = this.getEntityTrackerEntry(entity.getWorld(), entity.getEntityId());
181-
Validate.notNull(trackerEntry, "Could not find entity trackers for " + entity);
181+
if (trackerEntry == null) { //entity.toString() is too expensive to be called every time
182+
throw new IllegalArgumentException("Could not find entity trackers for " + entity);
183+
}
182184

183185
if (this.trackedPlayersField == null) {
184186
this.trackedPlayersField = Accessors.getFieldAccessor(

0 commit comments

Comments
 (0)