little cleanup

Author: davidatsurge

shared/src/sync_engine/new_defn.rs

@@ -58,12 +58,12 @@ impl<W: TypedTransportTrait, GithubApi> SyncEngine<W, GithubApi> {
             .with_store::<IssueCommentsInitialSyncStatus>()
             .with_store::<RepositoryInitialSyncStatus>();
 
-        let db_change_notifiers: Rc<Registry<DbSubscription>> = Default::default();
-        let db_change_notifiers2 = db_change_notifiers.clone();
+        let db_subscriptions: Rc<Registry<DbSubscription>> = Default::default();
+        let db_subscriptions2 = db_subscriptions.clone();
         let db = DbWithOptimisticChanges::new(
             db,
             Rc::new(move |reactivity_trackers| {
-                let orig_trackers = db_change_notifiers2.get();
+                let orig_trackers = db_subscriptions2.get();
                 orig_trackers
                     .iter()
                     .filter(|sub| {
@@ -76,7 +76,7 @@ impl<W: TypedTransportTrait, GithubApi> SyncEngine<W, GithubApi> {
 
         Ok(Self {
             db: Rc::new(db),
-            db_subscriptions: SendWrapper::new(db_change_notifiers),
+            db_subscriptions: SendWrapper::new(db_subscriptions),
             endpoint_client,
             _transport: PhantomData,
         })

shared/src/sync_engine/registry.rs

@@ -8,6 +8,9 @@ struct Inner<T> {
     map: HashMap<u32, T>,
 }
 
+/// The idea is that one calls `.add()` to add an object to the registry, and it
+/// will return a function that will remove it from the registry when called.
+/// And then one can do `registry.get()` to get all the objects in the registry.
 pub struct Registry<T> {
     inner: SendWrapper<Rc<RefCell<Inner<T>>>>,
 }