refactor: no need for a callback after optimistic change succeeds

The updating from optimistic => realistic should happen when the webhook confirming it comes in

Author: davidatsurge

shared/src/sync_engine/mutations/issues.rs

@@ -57,9 +57,6 @@ impl<T: TransportTrait, GithubApi: GithubApiTrait> SyncEngine<T, GithubApi> {
                     .map(|i| IssueId::from(i.id))
                     .map_err(|_| ())
             },
-            |id| {
-                tracing::info!("issue created: {:?}", id);
-            },
         );
 
         Ok(issue_id)

shared/src/sync_engine/optimistic/db/object_store.rs

@@ -167,13 +167,12 @@ where
         &self,
         row: S,
         create_fut: impl Future<Output = Result<S::Id, ()>> + 'static,
-        callback: impl FnOnce(S::Id) + 'static,
     ) {
         self.reactivity_trackers
             .borrow_mut()
             .add_modification(S::NAME, SerializedId::new_from_row(&row));
         let id = row.id().clone();
-        self.optimistic_changes.create(row, create_fut, callback);
+        self.optimistic_changes.create(row, create_fut);
 
         tracing::info!("did self.optimistic_changes.create for row with id: {:?}", id);
         if let Some(commit_listener) = self.commit_listener.as_ref() {

shared/src/sync_engine/optimistic/db/tests.rs

@@ -263,7 +263,7 @@ pub async fn get_all_no_optimisim_create_overlapping() {
         .with_txn_2(async |txn| {
             txn.object_store::<Issue>()
                 .unwrap()
-                .create(Default::default(), async {Ok( Default::default()) }, |_| ());
+                .create(Default::default(), async {Ok( Default::default()) });
         })
         .should_overlap(true)
         .call()
@@ -286,7 +286,7 @@ pub async fn get_all_no_optimisim_create_non_overlapping() {
         .with_txn_2(async |txn| {
             txn.object_store::<Repository>()
                 .unwrap()
-                .create(Default::default(), async { Ok(Default::default()) }, |_| ());
+                .create(Default::default(), async { Ok(Default::default()) });
         })
         .should_overlap(false)
         .call()

shared/src/sync_engine/optimistic/optimistic_changes.rs

@@ -58,8 +58,6 @@ impl OptimisticChanges {
         row: S,
         // The future must resolve to the id of whatever is created.
         create_fut: impl Future<Output = Result<S::Id, ()>> + 'static,
-        callback: impl FnOnce(S::Id) + 'static,
-
     ) {
         let id = row.id().clone();
         let creations = self.creations.clone();
@@ -73,7 +71,6 @@ impl OptimisticChanges {
                         &time,
                         SerializedId::new_from_id::<S>(&actual_id),
                     );
-                    callback(actual_id);
                 }
                 Err(_) => {
                     creations.remove_pending::<S>(&id, &time);

web/src/app/repository/issues_tab/new_issue.rs

@@ -26,6 +26,7 @@ pub fn NewIssue(
     move || {
         let sync_engine = use_sync_engine();
         let on_create = move |_| {
+            let sync_engine = sync_engine.clone();
             let RepositoryPageContextInner {
                 user: owner,
                 repository,
@@ -35,10 +36,10 @@ pub fn NewIssue(
                 body: Some(body.get()),
                 ..Default::default()
             };
-            let sync_engine = sync_engine.clone();
-            let repo_name = repository.name.clone();
+
+            let owner_login = owner.login.clone();
             spawn_local(async move {
-                let issue_id = sync_engine
+                let optimistic_issue_id = sync_engine
                     .create_issue(
                         &repository.installation_id,
                         &owner,
@@ -48,18 +49,19 @@ pub fn NewIssue(
                     .await
                     .log_err();
 
-                if let Ok(issue_id) = issue_id {
+                if let Ok(optimistic_issue_id) = optimistic_issue_id {
                     let txn = sync_engine.db.txn().with_store::<Issue>().build();
                     let issue_number = txn
                         .object_store::<Issue>()
                         .unwrap()
-                        .get(&issue_id)
+                        .get(&optimistic_issue_id)
                         .await
                         .unwrap()
                         .unwrap()
                         .number;
-                    let owner_login = &repository_page_context.get().user.login;
+                    let owner_login = owner_login.clone();
                     let issue_number = issue_number.to_string();
+                    let repo_name = repository.name.clone();
                     set_pathname(zwang_url!("/owner_name={owner_login}/repo_name={repo_name}/issues/issue_number={issue_number}"));
                 }
             });