.

Author: davidatsurge

.vscode/launch.json

@@ -0,0 +1,16 @@
+{
+    "configurations": [
+        {
+            "name": "Launch Browser Chrome",
+            "request": "launch",
+            "type": "chrome",
+            "url": "http://localhost:3000",
+            "webRoot": "${workspaceFolder}/web/dist",
+            "cwd": "${workspaceFolder}/web",
+            "userDataDir": true,
+            "runtimeArgs": [
+                "--remote-debugging-port=9222"
+            ]
+        }
+    ]
+}

shared/src/sync_engine/mod.rs

@@ -7,6 +7,7 @@ pub use websocket_updates::transport::*;
 mod conversions;
 mod initial_sync;
 
+mod new_defn;
 pub mod changes;
 pub mod error;
 pub mod mutations;
@@ -36,7 +37,15 @@ pub struct DbSubscription {
     pub original_reactivity_trackers: ReactivityTrackers,
     pub func: Arc<dyn Fn()>,
 }
-mod new_defn;
+
+impl std::fmt::Debug for DbSubscription {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        f.debug_struct("DbSubscription")
+            .field("original_reactivity_trackers", &self.original_reactivity_trackers)
+            .field("func", &"some func yo")
+            .finish()
+    }
+}
 
 pub use new_defn::DbStoreMarkers;
 

shared/src/sync_engine/new_defn.rs

@@ -79,24 +79,11 @@ impl<BackendApi: BackendApiTrait, Transport: TransportTrait, GithubApi>
                 let matching_trackers = orig_trackers
                     .iter()
                     .filter(|sub| {
-                        tracing::trace!(
-                            "checking if {:?} is affected by {:?}",
-                            sub.original_reactivity_trackers,
-                            reactivity_trackers
-                        );
                         sub.original_reactivity_trackers
                             .is_affected_by_writes_in(reactivity_trackers)
                     })
                     .collect::<Vec<_>>();
 
-                tracing::trace!(
-                    "matching_trackers: {:?}",
-                    matching_trackers
-                        .iter()
-                        .map(|sub| sub.original_reactivity_trackers.clone())
-                        .collect::<Vec<_>>()
-                );
-
                 matching_trackers.into_iter().for_each(|sub| (sub.func)());
             }),
         )

shared/src/sync_engine/registry.rs

@@ -31,7 +31,8 @@ impl<T> Registry<T> {
     pub fn new() -> Self {
         Default::default()
     }
-
+}
+impl<T> Registry<T> {
     /// Will return the function that will remove it from the registry
     pub fn add(&self, t: T) -> impl Fn() + Send + Sync {
         let id = {
@@ -43,7 +44,7 @@ impl<T> Registry<T> {
         let inner = self.inner.clone();
 
         move || {
-            inner.borrow_mut().map.remove(&id);
+            let item = inner.borrow_mut().map.remove(&id);
         }
     }
 }

typesafe_idb/src/store.rs

@@ -1,10 +1,11 @@
+use std::fmt::Debug;
 use serde::{de::DeserializeOwned, Serialize};
 use std::hash::Hash;
 
 use crate::StoreName;
 
 #[allow(async_fn_in_trait)]
-pub trait Store: Serialize + DeserializeOwned + Clone + 'static {
+pub trait Store: Serialize + DeserializeOwned + Clone + 'static + Debug {
     const NAME: StoreName;
     type Marker: Default;
 

web/src/app/flowbite/button.rs

@@ -28,6 +28,24 @@ impl ButtonColor {
         }
     }
 }
+#[allow(dead_code)]
+#[derive(Default, Clone)]
+pub enum ButtonType {
+    Submit,
+    #[default]
+    Button
+}
+
+impl ButtonType {
+    fn get_type_str(&self) -> &'static str {
+        match self {
+            ButtonType::Submit => "submit",
+            ButtonType::Button => "button"
+        }
+    }
+}
+
+
 
 #[allow(dead_code)]
 #[derive(Default)]
@@ -52,13 +70,18 @@ impl ButtonSize {
     }
 }
 
+
+
 /// https://flowbite.com/docs/components/buttons/#default-button
+#[allow(non_snake_case)]
 #[component]
 pub fn Button(
     #[prop(optional, into)] color: Signal<ButtonColor>,
     #[prop(optional)] children: Option<Children>,
+    #[prop(optional, into)] type_: Signal<ButtonType>,
     #[prop(optional, into)] size: Signal<ButtonSize>,
 ) -> impl IntoView {
+    let type_= move || type_.read().get_type_str();
     let class = move || {
         format!(
             "font-medium rounded-lg me-2 mb-2 focus:outline-none {} {}",
@@ -67,7 +90,7 @@ pub fn Button(
         )
     };
     view! {
-        <button type="button" class=class>
+        <button type=type_ class=class>
             {children.map(|c| c())}
         </button>
     }

web/src/app/repository/issues_tab/list.rs

@@ -1,11 +1,14 @@
 use jiff::{fmt::strtime, Timestamp};
 use leptos::prelude::*;
 use macros::zwang_url;
-use shared::{sync_engine::optimistic::db::MaybeOptimistic, types::{
-    issue::{Issue, RepositoryIdIndex},
-    issue_comment::{IssueComment, IssueIdIndex},
-    user::User,
-}};
+use shared::{
+    sync_engine::optimistic::db::MaybeOptimistic,
+    types::{
+        issue::{Issue, RepositoryIdIndex},
+        issue_comment::{IssueComment, IssueIdIndex},
+        user::User,
+    },
+};
 
 use itertools::Itertools;
 use zwang_router::{ArgFromParent, RouteParams, A};
@@ -33,11 +36,12 @@ pub fn IssuesList(
     let issues = sync_engine.idb_signal(
         |builder| builder.with_store::<Issue>().build(),
         move |txn| async move {
-            Ok(txn
+            let issues = txn
                 .object_store::<Issue>()?
                 .index::<RepositoryIdIndex>()?
                 .get_all_optimistically(Some(&repository_page_context.read().repository.id))
-                .await?)
+                .await?;
+            Ok(issues)
         },
     );
 
@@ -123,7 +127,10 @@ fn IssueRow(
                     Some(u) => u,
                     None => return Ok(None),
                 };
-                Ok(txn.object_store::<User>()?.get_optimistically(&user_id).await?)
+                Ok(txn
+                    .object_store::<User>()?
+                    .get_optimistically(&user_id)
+                    .await?)
             }
         },
     );

web/src/app/repository/issues_tab/new_issue.rs

@@ -1,4 +1,4 @@
-use crate::app::repository::RepositoryPageContextInner;
+use crate::app::{flowbite::button::ButtonType, repository::RepositoryPageContextInner};
 use crate::app::routing::*;
 use github_api::models::IssuesCreateRequestTitle;
 use leptos::{prelude::*, task::spawn_local};
@@ -25,7 +25,7 @@ pub fn NewIssue(
     let body = RwSignal::new(Default::default());
     move || {
         let sync_engine = use_sync_engine();
-        let on_create = move |_| {
+        let on_submit = move |_| {
             let sync_engine = sync_engine.clone();
             let RepositoryPageContextInner {
                 user: owner,
@@ -66,6 +66,7 @@ pub fn NewIssue(
             });
         };
         view! {
+            <form on:submit=on_submit>
             <Thirds
                 two_thirds=view! {
                     <div class="flex flex-nowrap gap-2">
@@ -90,13 +91,14 @@ pub fn NewIssue(
                             <div
                             class="flex gap-2 flex-end justify-end flex-end mb-4">
                             <Button color=ButtonColor::Light>Cancel</Button>
-                            <Button on:click=on_create>Create</Button>
+                            <Button type_=ButtonType::Submit>Create</Button>
                             </div>
                         </div>
                     </div>
                 }
                 one_third=()
             />
+            </form>
         }
     }
 }

web/src/idb_signal_from_sync_engine.rs

@@ -2,17 +2,20 @@ use leptos::prelude::*;
 use std::{future::Future, sync::Arc};
 
 use send_wrapper::SendWrapper;
-use shared::{backend_api_trait::BackendApiTrait, sync_engine::{
-    optimistic::db::{TxnBuilderWithOptimisticChanges, TxnWithOptimisticChanges},
-    DbStoreMarkers, SyncEngine, TransportTrait,
-}};
+use shared::{
+    backend_api_trait::BackendApiTrait,
+    sync_engine::{
+        optimistic::db::{TxnBuilderWithOptimisticChanges, TxnWithOptimisticChanges},
+        DbStoreMarkers, SyncEngine, TransportTrait,
+    },
+};
 use typesafe_idb::{ReadOnly, TxnMode};
 
 use crate::{frontend_error::FrontendError, idb_signal::IdbSignal};
 
 pub trait IdbSignalFromSyncEngine<DbStoreMarkers, TxnStoreMarkers, Mode, Fut, T>
 where
-    T: 'static,
+    T: 'static + std::fmt::Debug,
 {
     /// Will create a signal that will be recomputed every time an indexeddb change is committed by
     /// the sync engine.
@@ -30,12 +33,13 @@ where
 }
 
 impl<BA, TT, GH, TxnStoreMarkers, Mode, Fut, T>
-    IdbSignalFromSyncEngine<DbStoreMarkers, TxnStoreMarkers, Mode, Fut, T> for SyncEngine<BA, TT, GH>
+    IdbSignalFromSyncEngine<DbStoreMarkers, TxnStoreMarkers, Mode, Fut, T>
+    for SyncEngine<BA, TT, GH>
 where
     TxnStoreMarkers: 'static,
     Fut: Future<Output = Result<T, FrontendError>>,
     Mode: TxnMode + 'static,
-    T: 'static,
+    T: 'static + std::fmt::Debug,
     TT: TransportTrait,
     BA: BackendApiTrait,
 {