Merge pull request #83 from dnasir/renderItem-method

Render item method

Author: dnasir

dist/jquery.cascadingdropdown.js

@@ -1,4 +1,4 @@
-/*! jquery-cascading-dropdown 1.2.8 | (c) 2019 Dzulqarnain Nasir <[email protected]> | MIT */
+/*! jquery-cascading-dropdown 1.2.9 | (c) 2019 Dzulqarnain Nasir <[email protected]> | MIT */
 (function ($, undefined) {
     'use strict';
 
@@ -214,27 +214,19 @@
 
             var selected = [];
 
-            // Add all items as dropdown item
-            var getOption = function(item) {
-              var selectedAttr = '';
-              if(item.selected) {
-                selected.push(item.value.toString());
-              }
-
-              return '<option value="' + item.value + '"' + selectedAttr + '>' + item.label + '</option>';
-            };
-
             if ($.isArray(items)) {
               $.each(items, function(index, item) {
-                self.el.append(getOption(item));
+                self.el.append(self._renderItem(item));
+                if (item.selected) selected.push(item.value.toString());
               });
             } else {
               $.each(items, function(key, value) {
                 var itemData = [];
                 itemData.push('<optgroup label="' + key + '">');
                 for (var i = 0; i < value.length; i++) {
                   var item = value[i];
-                  itemData.push(getOption(item));
+                  itemData.push(self._renderItem(item));
+                  if (item.selected) selected.push(item.value.toString());
                 }
                 itemData.push('</optgroup>');
                 self.el.append(itemData.join(''));
@@ -250,6 +242,10 @@
             self._triggerReady();
         },
 
+        _renderItem: function(item) {
+            return '<option value="' + item.value + '"' + (item.selected ? ' selected' : '') + '>' + item.label + '</option>';
+        },
+
         // Trigger the ready event when instance is initialised for the first time
         _triggerReady: function() {
             if(this.initialised) return;

dist/jquery.cascadingdropdown.min.js

@@ -1,6 +1,6 @@
 {
   "name": "jquery-cascading-dropdown",
-  "version": "1.2.8",
+  "version": "1.2.9",
   "description": "A simple and lighweight jQuery plugin for creating cascading dropdowns.",
   "main": "dist/jquery.cascadingdropdown.min.js",
   "scripts": {

dist/jquery.cascadingdropdown.min.js.map

@@ -213,27 +213,19 @@
 
             var selected = [];
 
-            // Add all items as dropdown item
-            var getOption = function(item) {
-              var selectedAttr = '';
-              if(item.selected) {
-                selected.push(item.value.toString());
-              }
-
-              return '<option value="' + item.value + '"' + selectedAttr + '>' + item.label + '</option>';
-            };
-
             if ($.isArray(items)) {
               $.each(items, function(index, item) {
-                self.el.append(getOption(item));
+                self.el.append(self._renderItem(item));
+                if (item.selected) selected.push(item.value.toString());
               });
             } else {
               $.each(items, function(key, value) {
                 var itemData = [];
                 itemData.push('<optgroup label="' + key + '">');
                 for (var i = 0; i < value.length; i++) {
                   var item = value[i];
-                  itemData.push(getOption(item));
+                  itemData.push(self._renderItem(item));
+                  if (item.selected) selected.push(item.value.toString());
                 }
                 itemData.push('</optgroup>');
                 self.el.append(itemData.join(''));
@@ -249,6 +241,10 @@
             self._triggerReady();
         },
 
+        _renderItem: function(item) {
+            return '<option value="' + item.value + '"' + (item.selected ? ' selected' : '') + '>' + item.label + '</option>';
+        },
+
         // Trigger the ready event when instance is initialised for the first time
         _triggerReady: function() {
             if(this.initialised) return;