test script and several tests fail

[joelb123]

Make 4.4.1 puts all the names of tests in a single line, which makes the test script fail.
When this problem is fixed (see revised script below), I get 6 failed tests (bftest, cmtest, divtest, testcontain, testmhmerge, vactest) for various reasons.

#!/bin/bash make setup_tests -j8 1>/dev/null tests=$(cat tmpfiles.txt | tr " " "\n") n_failed=0 n_successes=0 rm -f failed.txt echo "running tests" start_time="$(date -u +%s)" for test_exe in $tests; do echo -n " ${test_exe}..." $(./$test_exe 2>/dev/null) if [ $? -eq 0 ]; then echo "OK" ((n_successes=n_successes+1)) else echo -e "\e[31m\e[1mfailed\e[0m" echo "${test_exe}" >> failed.txt ((n_failed=n_failed+1)) fi done end_time="$(date -u +%s)" elapsed="$(($end_time-$start_time))" echo "Results: ${n_successes} successes, ${n_failed} failures in ${elapsed} s" if [ $n_successes -gt 0 ]; then echo "Failed tests:" cat failed.txt fi rm -f tmpfiles.txt failed.txt

[joelb123]

run_tests.sh.txt

[joelb123]

under 1.8.1 the tests themselves no longer fail, although the test script does. Attached above is a new, improved test script that also does timings.

-O3 and -funroll-loops do not produce any timing improvements on my system over -O2.
Optimizations should be in a "?=" assignment in the Makefile so they may be overridden by the packager, IMO.

[dnbaker]

Thanks for finding this! I've started working on fixing this on a branch.

And fair point on the optimizations. Since it's primarily a header-only library these tests shouldn't affect much, but that's good to know.

I've been able to reproduce the issues and will update you as I make progress. Looking at the runs, we also emit far too much text during the runs.

Again, thanks - it will be good to clean up the codebase, and it should make it more reusable.

[dnbaker]

Checking in on this - I've corrected the issues here, and I've updated the python package name. I have a version on pip now, but I'm working on a conda recipe to make it more stable across platforms.

Again - thanks for the push. Happy to make other improvements - I'll keep you updated.

Best,

Daniel