Fix incomplete regex replacements

Author: bdukes

DNN Platform/JavaScript Libraries/DnnPlugins/dnn.jquery.js

@@ -2683,7 +2683,7 @@
                         var profileImagePath = dnn.getVar("sf_siteRoot", "/") + 'DnnImageHandler.ashx?mode=securefile&fileId=' + data.result.FileId + '&MaxWidth=180&MaxHeight=150';
                         img.src = profileImagePath;
 
-                        var fileName = data.result.FilePath.replace('\\', '/');
+                        var fileName = data.result.FilePath.replace(/\\/g, '/');
                         if (fileName.indexOf('/') > -1) {
                             fileName = fileName.split('/')[fileName.split('/').length - 1];
                         }

DNN Platform/Modules/CoreMessaging/Scripts/CoreMessaging.js

@@ -32,7 +32,7 @@
 
     function getQuerystring(key, default_) {
         if (default_ == null) default_ = "";
-        key = key.replace(/[\[]/, "\\\[").replace(/[\]]/, "\\\]");
+        key = key.replace(/\[/g, "\\\[").replace(/]/g, "\\\]");
         var regex = new RegExp("[\\?&]" + key + "=([^&#]*)");
         var qs = regex.exec(window.location.href);
         if (qs == null)

DNN Platform/Modules/Journal/Scripts/journal.js

@@ -481,13 +481,22 @@ function pluginInit() {
             } else {
                 data.itemData = '';
             }
-            if ((data.text == '' && data.itemData == '') || data.text == '%3Cbr%3E') {
+            if ((!data.text && !data.itemData) || data.text === '%3Cbr%3E') {
                 return false;
             }
             //Check for a value
             var tmpValue = $content.val();
-            tmpValue = tmpValue.replace(/<(?:.|\n)*?>/gm, '').replace(/\s+/g, '').replace(/&nbsp;/g,'');
-            if (tmpValue == '' && data.itemData == '') {
+            while (/<(?:.|\n)*?>/gm.test(tmpValue)) {
+                tmpValue = tmpValue.replace(/<(?:.|\n)*?>/gm, '');
+            }
+            while (/\s+/g.test(tmpValue)) {
+                tmpValue = tmpValue.replace(/\s+/g, '');
+            }
+            while (/&nbsp;/g.test(tmpValue)) {
+                tmpValue = tmpValue.replace(/&nbsp;/g, '');
+            }
+
+            if (tmpValue === '' && data.itemData === '') {
                 return false;
             }
             data.mentions = $content.data("mentions");

DNN Platform/Modules/Journal/Scripts/journalcomments.js

@@ -65,11 +65,19 @@
             data.Comment = encodeURIComponent($textarea.val());
             data.mentions = $textarea.data("mentions");
             var tmpValue = $textarea.val();
-            tmpValue = tmpValue.replace(/<(?:.|\n)*?>/gm, '').replace(/\s+/g, '').replace(/&nbsp;/g, '');
-            if (tmpValue == '') {
+            while (/<(?:.|\n)*?>/gm.test(tmpValue)) {
+                tmpValue = tmpValue.replace(/<(?:.|\n)*?>/gm, '');
+            }
+            while (/\s+/g.test(tmpValue)) {
+                tmpValue = tmpValue.replace(/\s+/g, '');
+            }
+            while (/&nbsp;/g.test(tmpValue)) {
+                tmpValue = tmpValue.replace(/&nbsp;/g, '');
+            }
+            if (tmpValue === '') {
                 return false;
             }
-            if (data.Comment == '' || data.Comment == '%3Cbr%3E') {
+            if (!data.Comment || data.Comment === '%3Cbr%3E') {
                 return false;
             }
             Post('CommentSave', data, commentComplete, jid);

DNN Platform/Providers/HtmlEditorProviders/DNNConnect.CKE/js/ckeditor/4.18.0/plugins/dnnpages/plugin.js

@@ -222,11 +222,11 @@
 	};
 
 	function unescapeSingleQuote( str ) {
-		return str.replace( /\\'/g, '\'' );
+		return str.replace( /\\'/g, '\'' ).replace(/\\\\/g, '\\');
 	}
 
 	function escapeSingleQuote( str ) {
-		return str.replace( /'/g, '\\$&' );
+		return str.replace( /'/g, '\\$&' ).replace(/\\/g, '\\\\');
 	}
 
 	function protectEmailAddressAsEncodedString( address ) {

DNN Platform/Website/Resources/Shared/scripts/dnn.jquery.js

@@ -2677,7 +2677,7 @@
                         var profileImagePath = dnn.getVar("sf_siteRoot", "/") + 'DnnImageHandler.ashx?mode=securefile&fileId=' + data.result.FileId + '&MaxWidth=180&MaxHeight=150';
                         img.src = profileImagePath;
 
-                        var fileName = data.result.FilePath.replace('\\', '/');
+                        var fileName = data.result.FilePath.replace(/\\/g, '/');
                         if (fileName.indexOf('/') > -1) {
                             fileName = fileName.split('/')[fileName.split('/').length - 1];
                         }

Dnn.AdminExperience/ClientSide/Prompt.Web/src/utils/helpers.js

@@ -24,7 +24,7 @@ export function sort(items, column, order) {
 export function formatLabel(input) {
     if (typeof input === "string") {
         // format camelcase and remove Is from labels
-        let output = input.replace("$", "").replace(/^(Is)(.+)/i, "$2");
+        let output = input.replace(/$/g, "").replace(/^(Is)(.+)/i, "$2");
         output = output.match(/[A-Z][a-z]+/g).join(" "); // rudimentary but should handle normal Camelcase
         return output;
     }