[Bug]: Cannot upgrade from 10.1.2 to 10.2.1

[alokagarwal1979]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

Upgrade page doe not comes up when upgrading from 10.1.2 to 10.2.1. Site fails to load.

Steps to reproduce?

Site is recently upgraded from 9.13.9 to 10.1.2 wih all modules working. Web solution already upgrded in .net 4.8 and all its deprecated api changes have been fixed in the upgraded solution.
Trying to do normal upgrade process to upgrade to 10.2.1, as we wish to get the fix html workflow issue in our application.
After dropping the upgrade package the upgrade page does not comes up.
i do not see any log or any thing which suggest what could be the issue.
Please advice.

Current Behavior

No response

Expected Behavior

No response

Relevant log output

Anything else?

No response

Affected Versions

10.2.0 (latest v10 release)

What browsers are you seeing the problem on?

Chrome, Microsoft Edge

Code of Conduct

• I agree to follow this project's Code of Conduct

[bdukes]

What 3rd party extensions are installed?
Is there a log file in /Portals/_default/Logs that has any details?
What sort of error are you seeing when you try to load the page? A timeout?

[alokagarwal1979]

we have following 3rd party modules- Digarticle, but its all code is all working in 10.1.2.
log file is empty nothing comes up there
Yes its a page timeout

[tpperlman]

This sound identical to our issue at #6901

If you can debug with Fusion, you may be able to see a similar log regarding System.Runtime.Loader

[valadas]

Did you upgrade Digarticle before upgrading DNN? They announced DNN10 compatibility recently

[alokagarwal1979]

Yes it is upgraded and module is working fine in 10.1.2.0

[jeremy-farrance]

What Theme is active (and version)?

[alokagarwal1979]

Our own custom theme is active currently. Need to make any change in themes for DNN 10? Theme is currently working fine till getsion DNN 10.1.2. Whatever issues we got in building that theme we already fixed them. And site is loadig properly with that theme.

[jeremy-farrance]

Our own custom theme is active currently. Need to make any change in themes for DNN 10? Theme is currently working fine till getsion DNN 10.1.2. Whatever issues we got in building that theme we already fixed them. And site is loadig properly with that theme.

Ok, DNN v10.02+ introduced the new CDF, so any skinobjects (e.g.<dnn:DnnCssInclude ...) or code calling into ClientResourceManager or related APIs might be the problem. Are you able to share any of that code here? Basically we need to get the actual error being thrown as well as the line of code throwing it.

[valadas]

Since we still go have enough information to make this issue actionable, I`ll move it to a discussion for now.

[alokagarwal1979]

i ll looked into portal logs.. nothing there.. db logs i didnt checked.. but not expecting anything there as portal logs should have shown something... but it is just site goes down with nothing to show on ui... we have used dnnjsinclude in our code in themes will share code in some time...

[alokagarwal1979]

we have added declaration in skin as below
dnnjsinclude id='id1' runat='server' filepath='js/app.js' pathnamealias='SkinPath'
many such declaration as needed. pls tell me what needs to be added in back end code so that following line in DnnJsInclude.cs constructor works, i think this mihht be the reason here why upgrade is not working.
Dependencyinjection.GetCurrentServiceProvider().GetarequiredService()

[alokagarwal1979]

what i could understand is that we need to add depency injection for client resource controller in our skin. now it seems that we have added this class in 10.2.1 only and along with that in your bas constructor we have added line this(null), this is bound to break in upgrade, as during upgrade it wont get the dependency injection of this class. once it is upgraded we can add dependency injection for same, how to do same in upgrade process?

[thienvc]

what i could understand is that we need to add depency injection for client resource controller in our skin. now it seems that we have added this class in 10.2.1 only and along with that in your bas constructor we have added line this(null), this is bound to break in upgrade, as during upgrade it wont get the dependency injection of this class. once it is upgraded we can add dependency injection for same, how to do same in upgrade process?

An error will occur if your code contains a constructor similar to the one below:

var include = new DnnJsInclude 
{
    ForceProvider = DnnProviderName(clientAsset.PosInPage), 
    Priority = clientAsset.Priority, 
    FilePath = clientAsset.Url, 
    AddTag = false
};

I had to fix quite a bit of code in my custom skin object because of this issue.You should review your .cs code and replace it with CRM.Register...()

[valadas]

If you are talking about the asxc file itself, the skinObject is still fine, why do you call Dependencyinjection.GetCurrentServiceProvider().GetarequiredService() is that in the codebehind of that ascx file? Can you provide a complete sample that could be tested?

[alokagarwal1979]

in ascx file we have lines like
dnnjsinclude id='id1' runat='server' filepath='js/app.js' pathnamealias='SkinPath'
and similarly for dnncssinclude as well. in code behind we do not have any code as of now. what i understood from valadas comment that ithis should not be a problem.
Please direct me what else i can look into to find why upgrade page is not working?

[thienvc]

It is likely not an error in your .ascx files, provided they don't contain server-side code. The issue is most likely caused by code in your source that manually instantiates classes like var include = new DnnJsInclude() or new DnnCsInclude(), etc.

This compiles fine (no build errors), but it will throw an error at runtime. If you are the developer, you should switch to using the CRM API. Please find those lines and replace them with: ClientResourceManager.RegisterStyleSheet(this.Page, cssPath, priorityOrder, "DnnPageHeaderProvider");
On the other hand, if you are not a developer, you should ask your module vendors to confirm if their modules are ready to run on DNN 10.2.1

I also had to update my code in several places within my modules a few days ago to ensure compatibility with version 10.2.1, as shown in the attached image:

As shown in the image, I had to comment out the old code and replace it with the ClientResourceManager.Register... API.

[alokagarwal1979]

that is not problem in our case, ok let me retry the upgrde share what else i can find in it

[jeremy-farrance]

If you can isolate the line(s) of code that are throwing the error, please share that code here. Basically we need to get the actual error being thrown as well as the line(s) of code throwing it. That should or could allow us to reproduce the error - which is very often the only way to resolve these types of issues.