Remove record type enumerations (#210)

Author: dallasread

CHANGELOG.md

@@ -4,8 +4,13 @@ This project uses [Semantic Versioning 2.0.0](http://semver.org/).
 
 ## main
 
+### Changed
+
+- `ZoneRecord.Type` and `FilterByType()` changed from enum to `string`
+
 ### Removed
 
+- Removed `ZoneRecordType` enumeration
 - Removed deprecated `GetWhoisPrivacy` (dnsimple/dnsimple-developer#919)
 - Removed deprecated `RenewWhoisPrivacy` (dnsimple/dnsimple-developer#919)
 

src/dnsimple-test/Services/ZoneRecordsTest.cs

@@ -74,7 +74,7 @@ public void ZoneRecordData()
                     record.Content, Is.EqualTo("ns1.dnsimple.com admin.dnsimple.com 1458642070 86400 7200 604800 300"));
                 Assert.That(record.Ttl, Is.EqualTo(3600));
                 Assert.That(record.Priority, Is.Null);
-                Assert.That(record.Type, Is.EqualTo(ZoneRecordType.SOA));
+                Assert.That(record.Type, Is.EqualTo("SOA"));
                 Assert.That(record.Regions, Contains.Item("global"));
                 Assert.That(record.SystemRecord, Is.True);
                 Assert.That(record.CreatedAt, Is.EqualTo(CreatedAt));
@@ -124,7 +124,7 @@ public void ListRecordsWithOptions(long account, string zoneId,
                 }
             }.FilterByName("example")
                 .FilterByExactName("boom")
-                .FilterByType(ZoneRecordType.SOA)
+                .FilterByType("SOA")
                 .SortById(Order.asc)
                 .SortByName(Order.desc)
                 .SortByContent(Order.asc)
@@ -148,7 +148,7 @@ public void CreateZoneRecord(string fixture, long accountId,
             var record = new ZoneRecord
             {
                 Name = name,
-                Type = ZoneRecordType.A,
+                Type = "A",
                 Content = "127.0.0.1",
                 Ttl = 600,
             };
@@ -164,7 +164,7 @@ public void CreateZoneRecord(string fixture, long accountId,
                 Assert.That(created.Name, Is.EqualTo(name));
                 Assert.That(created.Content, Is.EqualTo("127.0.0.1"));
                 Assert.That(created.Ttl, Is.EqualTo(600));
-                Assert.That(created.Type, Is.EqualTo(ZoneRecordType.A));
+                Assert.That(created.Type, Is.EqualTo("A"));
                 Assert.That(created.Regions, Contains.Item("global"));
 
                 Assert.That(client.HttpMethodUsed(), Is.EqualTo(Method.POST));
@@ -191,7 +191,7 @@ public void GetZoneRecord(long accountId, string zoneId, long recordId,
                 Assert.That(record.Content, Is.EqualTo("mxa.example.com"));
                 Assert.That(record.Ttl, Is.EqualTo(600));
                 Assert.That(record.Priority, Is.EqualTo(10));
-                Assert.That(record.Type, Is.EqualTo(ZoneRecordType.MX));
+                Assert.That(record.Type, Is.EqualTo("MX"));
                 Assert.That(record.Regions, Contains.Item("SV1"));
                 Assert.That(record.Regions, Contains.Item("IAD"));
                 Assert.That(record.SystemRecord, Is.False);
@@ -229,7 +229,7 @@ public void UpdateZoneRecord(long accountId, string zoneId,
                 Assert.That(record.Content, Is.EqualTo("mxb.example.com"));
                 Assert.That(record.Ttl, Is.EqualTo(3600));
                 Assert.That(record.Priority, Is.EqualTo(20));
-                Assert.That(record.Type, Is.EqualTo(ZoneRecordType.MX));
+                Assert.That(record.Type, Is.EqualTo("MX"));
                 Assert.That(record.Regions, Contains.Item("global"));
                 Assert.That(record.SystemRecord, Is.False);
 
@@ -339,7 +339,7 @@ public void ZoneRecordsListOptions()
                 }
             }.FilterByName("example")
                 .FilterByExactName("boom")
-                .FilterByType(ZoneRecordType.SOA)
+                .FilterByType("SOA")
                 .SortById(Order.asc)
                 .SortByName(Order.desc)
                 .SortByContent(Order.asc)

src/dnsimple/Services/ListOptions/ZoneRecordsListOptions.cs

@@ -34,9 +34,9 @@ public ZoneRecordsListOptions FilterByExactName(string name)
         /// </summary>
         /// <param name="type">The record type we want to filter by</param>
         /// <returns>The instance of the <c>ZoneRecordsListOptions</c></returns>
-        public ZoneRecordsListOptions FilterByType(ZoneRecordType type)
+        public ZoneRecordsListOptions FilterByType(string type)
         {
-            AddFilter(new Filter { Field = "type", Value = type.ToString() });
+            AddFilter(new Filter { Field = "type", Value = type });
             return this;
         }
 

src/dnsimple/Services/ZoneRecords.cs

@@ -125,34 +125,6 @@ public SimpleResponse<ZoneDistribution> CheckRecordDistribution( long accountId,
         }
     }
 
-    /// <summary>
-    /// Represents a zone record type.
-    /// </summary>
-    public enum ZoneRecordType
-    {
-        A,
-        AAAA,
-        ALIAS,
-        CAA,
-        CDNSKEY,
-        CDS,
-        CNAME,
-        DNSKEY,
-        DS,
-        HINFO,
-        MX,
-        NAPTR,
-        NS,
-        POOL,
-        PTR,
-        SOA,
-        SPF,
-        SRV,
-        SSHFP,
-        TXT,
-        URL
-    }
-
     /// <summary>
     /// Represents a Region.
     ///
@@ -185,7 +157,7 @@ public struct ZoneRecord
         public string Content { get; set; }
         public long Ttl { get; set; }
         public long? Priority { get; set; }
-        public ZoneRecordType Type { get; set; }
+        public string Type { get; set; }
         public List<string> Regions { get; set; }
         public bool SystemRecord { get; set; }
         public DateTime CreatedAt { get; set; }
@@ -211,7 +183,7 @@ internal class ZoneRecordToSend
         internal ZoneRecordToSend(ZoneRecord record)
         {
             Name = record.Name;
-            Type = record.Type.ToString();
+            Type = record.Type;
             Content = record.Content;
             Ttl = record.Ttl;
             Priority = record.Priority;