Merge branch 'main' into deprecation-getDomainPremiumPrice

Author: weppos

.github/scripts/validate-fixtures-json.js

@@ -10,35 +10,35 @@ const path = require('path');
  */
 function extractJsonFromHttpFile(filePath) {
   const content = fs.readFileSync(filePath, 'utf8');
-  
+
   // Split by double newline to separate headers from body
   const parts = content.split(/\n\s*\n/, 2);
-  
-  if (parts.length < 2) {
+
+  if (parts.length < 2)
     return null;
-  }
-  
+
+
   const body = parts[1].trim();
-  if (!body) {
+  if (!body)
     return null;
-  }
-  
+
+
   // Check if content-type indicates JSON
   const headers = parts[0];
-  const isJsonContentType = headers.includes('Content-Type: application/json') || 
+  const isJsonContentType = headers.includes('Content-Type: application/json') ||
                            headers.includes('content-type: application/json');
-  
+
   // If no explicit JSON content-type, try to parse as JSON anyway
   // (some files might have JSON without proper content-type header)
-  if (!isJsonContentType) {
+  if (!isJsonContentType)
     try {
       JSON.parse(body);
       return body;
-    } catch (e) {
+    } catch {
       return null;
     }
-  }
-  
+
+
   return body;
 }
 
@@ -49,22 +49,22 @@ function extractJsonFromHttpFile(filePath) {
  */
 function findHttpFiles(dir) {
   const files = [];
-  
+
   function traverse(currentDir) {
     const items = fs.readdirSync(currentDir);
-    
+
     for (const item of items) {
       const fullPath = path.join(currentDir, item);
       const stat = fs.statSync(fullPath);
-      
-      if (stat.isDirectory()) {
+
+      if (stat.isDirectory())
         traverse(fullPath);
-      } else if (item.endsWith('.http')) {
+       else if (item.endsWith('.http'))
         files.push(fullPath);
-      }
+
     }
   }
-  
+
   traverse(dir);
   return files;
 }
@@ -77,21 +77,21 @@ function validateJsonInFixtures(fixturesDir) {
   const errors = [];
   let filesChecked = 0;
   let jsonFilesFound = 0;
-  
+
   console.log(`🔍 Scanning for HTTP fixtures in: ${fixturesDir}`);
-  
+
   const httpFiles = findHttpFiles(fixturesDir);
-  
+
   for (const filePath of httpFiles) {
     filesChecked++;
     const jsonContent = extractJsonFromHttpFile(filePath);
-    
-    if (!jsonContent) {
+
+    if (!jsonContent)
       continue;
-    }
-    
+
+
     jsonFilesFound++;
-    
+
     try {
       JSON.parse(jsonContent);
       console.log(`✅ ${filePath}`);
@@ -101,12 +101,12 @@ function validateJsonInFixtures(fixturesDir) {
       errors.push(errorMsg);
     }
   }
-  
+
   console.log('\n📊 Summary:');
   console.log(`Files checked: ${filesChecked}`);
   console.log(`JSON files found: ${jsonFilesFound}`);
   console.log(`Validation errors: ${errors.length}`);
-  
+
   if (errors.length > 0) {
     console.log('\n❌ Errors found:');
     errors.forEach(error => console.log(`  ${error}`));

.github/workflows/ci.yml

@@ -12,6 +12,22 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  lint:
+    name: Lint JavaScript
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+    steps:
+      - uses: actions/checkout@v6
+      - name: Install Node
+        uses: actions/setup-node@v6
+        with:
+          node-version-file: '.tool-versions'
+          cache: yarn
+      - name: Install JS Deps
+        run: yarn install --frozen-lockfile
+      - name: Run ESLint
+        run: yarn lint
+
   lint_openapi:
     name: Lint OpenAPI Spec
     runs-on: ubuntu-latest

DEPRECATIONS.md

@@ -80,6 +80,46 @@ The `to` field in Email Forward schema has been renamed to `destination_email` f
 - Python: Complete
 - Rust: Complete
 
+### 2023-05-01 - getWhoisPrivacy endpoint
+
+The endpoint `GET /:account/registrar/domains/:domain/whois_privacy` was used to retrieve the WHOIS privacy status for a domain. The WHOIS privacy state can now be retrieved through the `getDomain` endpoint.
+
+**Removal Date:** N/A
+
+**Replacement:** Use `getDomain` endpoint to retrieve domain WHOIS privacy state.
+
+**Client Status:**
+
+- Ruby: Not started
+- Go: Not started
+- Elixir: Not started
+- Node.js: Not started
+- Java: Not started
+- C#: Not started
+- PHP: Not started
+- Python: Not started
+- Rust: Not started
+
+### 2023-05-01 - renewWhoisPrivacy endpoint
+
+The endpoint `POST /:account/registrar/domains/:domain/whois_privacy/renewals` was used to renew the WHOIS privacy service for a domain. WHOIS privacy no longer needs to be renewed as it stays enabled unless explicitly disabled.
+
+**Removal Date:** N/A
+
+**Replacement:** None. WHOIS privacy no longer requires renewal.
+
+**Client Status:**
+
+- Ruby: Not started
+- Go: Not started
+- Elixir: Not started
+- Node.js: Not started
+- Java: Not started
+- C#: Not started
+- PHP: Not started
+- Python: Not started
+- Rust: Not started
+
 ### 2025-11-13 - Domain push `new_account_email` field
 
 The `new_account_email` field in Domain Push request has been deprecated in favor of `new_account_identifier`, which provides more flexibility in identifying the target account.

content/use-cases/issue-certificates.md

@@ -49,7 +49,7 @@ When your customer registers a domain through your service, or delegates it for
 
 [lib/app/dnsimple.rb](https://github.com/dnsimple/dnsimple-api-examples/blob/main/ruby/use_cases/issue_certificates/lib/app/dnsimple.rb#L16)
 
-> [!WARNING]
+> [!WARNING] Deprecated since 01 June 2022
 > The `contact_id` field in Certificate schema has been deprecated. It is no longer a required field for certificate operations.
 
 ```ruby

content/v2/certificates.md

@@ -11,7 +11,7 @@ excerpt: This page documents the DNSimple certificates API v2.
 
 ## Certificate attributes {#certificate-attributes}
 
-> [!WARNING]
+> [!WARNING] Deprecated since 01 June 2022
 > The `contact_id` field in Certificate schema has been deprecated. It is no longer a required field for certificate operations.
 
 Please refer to the definition of the `Certificate` data type in [our OpenAPI documentation](/v2/openapi.yml).

content/v2/domains/email-forwards.md

@@ -31,7 +31,7 @@ Name | Type | Description
 
 For general information about sorting, please refer to the [main guide](/v2/#sorting).
 
-> [!WARNING]
+> [!WARNING] Deprecated since 25 January 2021
 > The `from` and `to` fields in Email Forward schema have been deprecated. The `from` field has been renamed to `alias_email` and the `to` field has been renamed to `destination_email` for clarity. Use `alias_email` and `destination_email` instead.
 
 Name | Description

content/v2/domains/pushes.md

@@ -33,7 +33,7 @@ Initiate a push from the source account `1010` for the `example.com` domain:
 
 ### Input
 
-> [!WARNING]
+> [!WARNING] Deprecated since 13 November 2025
 > The `new_account_email` field in Domain Push request has been deprecated in favor of `new_account_identifier`, which provides more flexibility in identifying the target account. Use `new_account_identifier` instead.
 
 Name | Type | Description

content/v2/openapi.yml

@@ -1433,27 +1433,18 @@ paths:
       summary: Disable domain auto-renewal
   '/{account}/registrar/domains/{domain}/whois_privacy':
     get:
-      description: Gets the whois privacy status for an existing domain.
+      deprecated: true
+      description: 'This endpoint has been deprecated and removed. Use getDomain instead.'
       parameters:
         - $ref: '#/components/parameters/Account'
         - $ref: '#/components/parameters/Domain'
       operationId: getWhoisPrivacy
       tags:
         - registrar privacy
       responses:
-        '200':
-          description: Successfully retrieved whois privacy details.
-          content:
-            application/json:
-              schema:
-                type: object
-                required: [data]
-                properties:
-                  data:
-                    $ref: '#/components/schemas/WhoisPrivacy'
-        '404':
-          $ref: '#/components/responses/404'
-      summary: WHOIS privacy status
+        '410':
+          description: This endpoint has been removed.
+      summary: WHOIS privacy status (deprecated)
     put:
       description: |-
         Enables the WHOIS privacy for the domain.
@@ -1513,32 +1504,18 @@ paths:
       summary: Disable WHOIS privacy
   '/{account}/registrar/domains/{domain}/whois_privacy/renewals':
     post:
-      description: |-
-        Renews the WHOIS privacy for the domain.
-
-        Note that if the WHOIS privacy was never purchased for the domain or if there is another renewal order in progress, renewing WHOIS privacy will return an error.
+      deprecated: true
+      description: 'This endpoint has been deprecated and removed. WHOIS privacy no longer requires renewal.'
       parameters:
         - $ref: '#/components/parameters/Account'
         - $ref: '#/components/parameters/Domain'
       operationId: renewWhoisPrivacy
       tags:
         - registrar privacy
       responses:
-        '201':
-          description: Successfully renew whois privacy.
-          content:
-            application/json:
-              schema:
-                type: object
-                required: [data]
-                properties:
-                  data:
-                    $ref: '#/components/schemas/WhoisPrivacyRenewal'
-        '400':
-          $ref: '#/components/responses/400'
-        '404':
-          $ref: '#/components/responses/404'
-      summary: Renew WHOIS privacy
+        '410':
+          description: This endpoint has been removed.
+      summary: Renew WHOIS privacy (deprecated)
   '/{account}/secondary_dns/primaries':
     get:
       summary: List primary servers
@@ -6138,43 +6115,6 @@ components:
         enabled: true
         created_at: '2016-02-13T14:34:50Z'
         updated_at: '2016-02-13T14:34:52Z'
-    WhoisPrivacyRenewal:
-      type: object
-      required:
-        - id
-        - domain_id
-        - whois_privacy_id
-        - state
-        - enabled
-        - expires_on
-        - created_at
-        - updated_at
-      properties:
-        id:
-          type: integer
-        domain_id:
-          type: integer
-        whois_privacy_id:
-          type: integer
-        state:
-          type: string
-        enabled:
-          type: boolean
-        expires_on:
-          $ref: '#/components/schemas/Date'
-        created_at:
-          $ref: '#/components/schemas/DateTimeCreatedAt'
-        updated_at:
-          $ref: '#/components/schemas/DateTimeUpdatedAt'
-      example:
-        id: 1
-        domain_id: 100
-        whois_privacy_id: 999
-        state: new
-        enabled: true
-        expires_on: '2020-01-10'
-        created_at: '2019-01-10T12:12:48Z'
-        updated_at: '2019-01-10T12:12:48Z'
     Zone:
       type: object
       description: Represents a DNS zone.

content/v2/registrar.md

@@ -57,7 +57,7 @@ Responds with [HTTP 401](/v2/#unauthorized) in case of authentication issues.
 
 ## Check domain premium price {#getDomainPremiumPrice}
 
-> [!WARNING]
+> [!WARNING] Deprecated since 18 May 2021
 > This endpoint has been deprecated and removed. Use [getDomainPrices](#getDomainPrices) instead.
 
 ## Retrieve domain prices {#getDomainPrices}