Skip to content

Commit d104c5a

Browse files
authored
Key id format (#42)
* Key identifiers may contain . * bump
1 parent e8ca973 commit d104c5a

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

dnstapir/key_resolver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def key_resolver_from_client_database(client_database: str, key_cache: KeyCache
3535
class KeyResolver:
3636
def __init__(self):
3737
self.logger = logging.getLogger(__name__).getChild(self.__class__.__name__)
38-
self.key_id_validator = re.compile(r"^[a-zA-Z0-9_-]+$")
38+
self.key_id_validator = re.compile(r"^[a-zA-Z0-9_\-.]+$")
3939

4040
@abstractmethod
4141
def resolve_public_key(self, key_id: str) -> PublicKey:

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "dnstapir"
3-
version = "1.2.1"
3+
version = "1.2.2"
44
description = "DNS TAPIR Python Library"
55
authors = ["Jakob Schlyter <[email protected]>"]
66
readme = "README.md"

tests/test_key_resolver.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ def test_file_key_resolver(httpx_mock: HTTPXMock):
2525
res = resolver.resolve_public_key(key_id)
2626
assert res == public_key
2727

28+
with pytest.raises(KeyError):
29+
_ = resolver.resolve_public_key("hostname.example.com")
30+
2831
with pytest.raises(ValueError):
2932
_ = resolver.resolve_public_key("🔐")
3033

0 commit comments

Comments
 (0)