Merge pull request #502 from klee-contrib/validite-html

fix(HtmlValidity): 🐛 Correction validité Html

Author: laruiss

src/components/DsfrCheckbox/DsfrCheckbox.e2e.js

@@ -32,7 +32,6 @@ describe('DsfrCheckbox', () => {
       .should('be.visible')
       .find('input')
       .should('have.attr', 'type', 'checkbox')
-      .should('have.attr', 'role', 'checkbox')
       .get('.fr-checkbox-group')
       .find('.fr-label')
       .should('be.visible')
@@ -74,7 +73,6 @@ describe('DsfrCheckbox', () => {
       .should('be.visible')
       .find('input')
       .should('have.attr', 'type', 'checkbox')
-      .should('have.attr', 'role', 'checkbox')
       .get('.fr-checkbox-group')
       .find('.fr-label')
       .should('be.visible')

src/components/DsfrCheckbox/DsfrCheckbox.spec.js

@@ -32,7 +32,6 @@ describe('DsfrCheckbox', () => {
     // Then
     expect(labelEl).toHaveClass('fr-label')
     expect(input.checked).toBe(true)
-    expect(input).toHaveAttribute('aria-checked', 'true')
     expect(inputCheckBox).toBeInTheDocument()
     expect(labelEl.getAttribute('for')).toBe(inputCheckBox.id)
     expect(inputCheckBox.getAttribute('type')).toBe('checkbox')
@@ -70,7 +69,6 @@ describe('DsfrCheckbox', () => {
     expect(labelEl).toHaveClass('fr-label')
     expect(inputCheckBox).toBeInTheDocument()
     expect(input.checked).toBe(false)
-    expect(input).toHaveAttribute('aria-checked', 'false')
     expect(labelEl.getAttribute('for')).toBe(inputCheckBox.id)
     expect(inputCheckBox.getAttribute('type')).toBe('checkbox')
     expect(inputCheckBox).toHaveAttribute('disabled')

src/components/DsfrCheckbox/DsfrCheckbox.vue

@@ -16,6 +16,7 @@ export default defineComponent({
       type: String,
       required: true,
     },
+    required: Boolean,
     modelValue: Boolean,
     label: {
       type: String,
@@ -60,9 +61,7 @@ export default defineComponent({
       :id="id"
       :name="name"
       type="checkbox"
-      role="checkbox"
       :checked="modelValue"
-      :aria-checked="modelValue"
       v-bind="$attrs"
       :data-testid="`input-checkbox-${id}`"
       :data-test="`input-checkbox-${id}`"
@@ -78,7 +77,7 @@ export default defineComponent({
         <!-- @slot Slot pour indiquer que le champ est obligatoire. Par défaut, met une astérisque si `required` est à true (dans un `<span class="required">`) -->
         <slot name="required-tip">
           <span
-            v-if="$attrs.required"
+            v-if="required"
             class="required"
           >&nbsp;*</span>
         </slot>

src/components/DsfrCheckbox/DsfrCheckboxSet.spec.js

@@ -38,7 +38,7 @@ describe('DsfrCheckboxSet', () => {
     const legendText = "Légende de l'ensemble des champs"
 
     // When
-    const { getByText, getAllByTestId } = render(DsfrCheckboxSet, {
+    const { getByText, container } = render(DsfrCheckboxSet, {
       global: {
         components: {
           VIcon,
@@ -53,7 +53,7 @@ describe('DsfrCheckboxSet', () => {
 
     // Then
     expect(getByText(firstLabelText)).toBeInTheDocument()
-    expect(getAllByTestId('t-checkbox')).toHaveLength(3)
+    expect(container.querySelectorAll('.fr-checkbox-group')).toHaveLength(3)
   })
 
   it('should render a group of checkboxes in fieldset', async () => {

src/components/DsfrCheckbox/DsfrCheckboxSet.vue

@@ -101,7 +101,6 @@ export default defineComponent({
           v-for="option in options"
           :id="option.id"
           :key="option.id || option.name"
-          data-testid="t-checkbox"
           :name="option.name"
           :label="option.label"
           :disabled="option.disabled"

src/components/DsfrFooter/DsfrFooter.vue

@@ -258,7 +258,7 @@ export default defineComponent({
             <component
               :is="isExternalLink ? 'a' : 'RouterLink'"
               class="fr-link-licence  no-content-after"
-              :to="isExternalLink ? routerLinkLicenceTo : null"
+              :to="isExternalLink ? null : routerLinkLicenceTo"
               :href="aLicenceHref"
               :target="isExternalLink ? '_blank' : undefined"
               rel="noopener noreferrer"

src/components/DsfrSelect/DsfrSelect.vue

@@ -5,6 +5,7 @@ import { getRandomId } from '../../utils/random-utils.js'
 
 export default defineComponent({
   name: 'DsfrSelect',
+  inheritAttrs: false,
 
   props: {
     required: Boolean,