Skip to content

Commit cd84ff2

Browse files
authored
Merge pull request #456 from ambroisemaupate/fix/radio-checkbox-set
fix(DsfrRadioButtonSet|DsfrCheckboxSet): Wrong fr-fieldset__content class leading to bad items margins
2 parents d716e71 + e4da6d9 commit cd84ff2

File tree

4 files changed

+15
-8
lines changed

4 files changed

+15
-8
lines changed

src/components/DsfrCheckbox/DsfrCheckbox.e2e.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ describe('DsfrCheckboxSet', () => {
143143
.should('be.visible')
144144
.should('contain', legend)
145145
.get('.fr-fieldset')
146-
.find('.fr-fieldset__element')
146+
.find('.fr-fieldset__content')
147147
.should('be.visible')
148148
.get('.fr-fieldset')
149149
.find('fr-message--info')
@@ -238,7 +238,7 @@ describe('DsfrCheckboxSet', () => {
238238
.should('be.visible')
239239
.should('contain', legend)
240240
.get('.fr-fieldset')
241-
.find('.fr-fieldset__element')
241+
.find('.fr-fieldset__content')
242242
.should('be.visible')
243243
.get('.fr-fieldset')
244244
.find('.fr-message--info')
@@ -334,7 +334,7 @@ describe('DsfrCheckboxSet', () => {
334334
.should('be.visible')
335335
.should('contain', legend)
336336
.get('.fr-fieldset')
337-
.find('.fr-fieldset__element')
337+
.find('.fr-fieldset__content')
338338
.should('be.visible')
339339
.get('.fr-fieldset')
340340
.find('.fr-message--info')

src/components/DsfrCheckbox/DsfrCheckboxSet.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ describe('DsfrCheckboxSet', () => {
128128
props: {
129129
},
130130
})
131-
const checkboxes = container.querySelector('.fr-fieldset__element')
131+
const checkboxes = container.querySelector('.fr-fieldset__content')
132132

133133
// Then
134134
expect(checkboxes.firstElementChild).toBe(null)

src/components/DsfrCheckbox/DsfrCheckboxSet.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ export default defineComponent({
9393
</slot>
9494
</legend>
9595
<div
96-
class="fr-fieldset__element"
96+
class="fr-fieldset__content"
9797
role="group"
9898
:aria-labelledby="titleId"
9999
>

src/components/DsfrRadioButton/DsfrRadioButtonSet.vue

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import { defineComponent } from 'vue'
44
55
import DsfrRadioButton from './DsfrRadioButton.vue'
6+
import { getRandomId } from '../../utils/random-utils.js'
67
78
export default defineComponent({
89
name: 'DsfrRadioButtonSet',
@@ -12,6 +13,12 @@ export default defineComponent({
1213
},
1314
1415
props: {
16+
titleId: {
17+
type: String,
18+
default () {
19+
return getRandomId('radio-button', 'group')
20+
},
21+
},
1522
disabled: Boolean,
1623
inline: Boolean,
1724
required: Boolean,
@@ -79,8 +86,8 @@ export default defineComponent({
7986
>
8087
<legend
8188
v-if="legend"
82-
id="radio-legend"
83-
class="fr-fieldset__legend"
89+
:id="titleId"
90+
class="fr-fieldset__legend fr-text--regular"
8491
>
8592
<!-- @slot Slot pour personnaliser tout le contenu de la balise <legend> cf. [DsfrInput](/?path=/story/composants-champ-de-saisie-champ-simple-dsfrinput--champ-avec-label-personnalise). Une **props porte le même nom pour une légende simple** (texte sans mise en forme) -->
8693
<slot name="legend">
@@ -96,7 +103,7 @@ export default defineComponent({
96103
</legend>
97104

98105
<div
99-
class="fr-fieldset__element"
106+
class="fr-fieldset__content"
100107
role="radiogroup"
101108
>
102109
<DsfrRadioButton

0 commit comments

Comments
 (0)