Skip to content

Commit b0c1ad0

Browse files
committed
Revise documentation for clarity and consistency
- Update tone guidelines to avoid using "please" in instructions - Change titles and labels for consistency across documents - Improve examples by replacing "❌" with "⛔" for clarity - Enhance instructions and formatting in various templates
1 parent a35405a commit b0c1ad0

File tree

11 files changed

+145
-92
lines changed

11 files changed

+145
-92
lines changed

AGENTS.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -155,13 +155,13 @@ All documentation must follow the [Google Developer Style Guide](https://develop
155155
**Voice and Tone:**
156156
- Write conversationally and friendly, like a knowledgeable friend, without being frivolous or overly colloquial
157157
- Avoid buzzwords, jargon, exclamation marks (except rare exciting moments), and phrases like "simply" or "it's easy"
158-
- Don't use "please" in instructions: ✅ "Click **View**" not "Please click **View**"
158+
- Don't use "please" in instructions: ✅ "Click **View**" not "Please click **View**"
159159

160160
**Language and Grammar:**
161161
- Use second person ("you") rather than first person ("we")
162-
- Use active voice: ✅ "Click the button" not "The button can be clicked"
163-
- Use present tense: ✅ "The API returns data" not "The API will return data"
164-
- Put conditions before instructions: ✅ "If you want to save, click **Save**" not "Click **Save** if you want to save"
162+
- Use active voice: ✅ "Click the button" not "The button can be clicked"
163+
- Use present tense: ✅ "The API returns data" not "The API will return data"
164+
- Put conditions before instructions: ✅ "If you want to save, click **Save**" not "Click **Save** if you want to save"
165165

166166
**Formatting:**
167167
- Use sentence case for headings (not Title Case)
@@ -173,8 +173,8 @@ All documentation must follow the [Google Developer Style Guide](https://develop
173173

174174
**Examples of Tone:**
175175
- ✅ Good: "To get the user's phone number, call `user.phoneNumber.get`."
176-
- Too casual: "Dude! This API is totally awesome!"
177-
- Too formal: "The telephone number can be retrieved by the developer via the simple expedient of using the get method."
176+
- Too casual: "Dude! This API is totally awesome!"
177+
- Too formal: "The telephone number can be retrieved by the developer via the simple expedient of using the get method."
178178

179179
### The Good Docs Project Templates
180180

docs/contributing/quick-start.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
---
2-
title: Quick Start
2+
title: Quick changes
33
description: Make quick documentation fixes in 2-10 minutes using your browser.
4-
sidebar_label: Quick Start
4+
sidebar_label: Quick changes
55
sidebar_position: 2
66
---
77

8-
# Quick contributions (2-10 minutes)
8+
# Quick changes (2-10 minutes)
99

1010
Fix typos, broken links, and small issues directly in your browser—no setup required.
1111

docs/contributing/review-process.mdx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ Before human review, automated checks verify your contribution.
4444
In your pull request, you'll see status checks:
4545

4646
-**Green check**: Passed
47-
- **Red X**: Failed
47+
- **Red X**: Failed
4848
- 🟡 **Yellow circle**: Running
4949

5050
### If checks fail
@@ -56,15 +56,15 @@ Don't panic! Failed checks are common and usually easy to fix.
5656
Vale checks writing style. Common issues:
5757

5858
**"Use second person instead of first person"**
59-
- `We recommend using...`
59+
- `We recommend using...`
6060
-`Use...` or `You can use...`
6161

6262
**"Avoid using 'please' in instructions"**
63-
- `Please click the button`
63+
- `Please click the button`
6464
-`Click the button`
6565

6666
**"Use active voice"**
67-
- `The file can be uploaded by...`
67+
- `The file can be uploaded by...`
6868
-`Upload the file by...`
6969

7070
**Handling Vale suggestions:**
@@ -158,19 +158,19 @@ Does it match existing documentation?
158158

159159
### What reviewers DON'T block on
160160

161-
#### Perfect prose
161+
#### Perfect prose
162162

163163
We value clear communication over elegant writing. If the meaning is clear, it's good enough.
164164

165-
#### Comprehensive edge cases
165+
#### Comprehensive edge cases
166166

167167
Documentation doesn't need to cover every possible scenario. Focus on common use cases.
168168

169-
#### Advanced formatting
169+
#### Advanced formatting
170170

171171
Basic formatting is sufficient. Fancy design elements are nice-to-have, not required.
172172

173-
#### Minor style issues
173+
#### Minor style issues
174174

175175
If automated tools miss something minor, reviewers won't block on it. We fix small things during review.
176176

docs/contributing/standard-contributions.mdx

Lines changed: 106 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
---
2-
title: Standard Contributions
2+
title: Standard changes
33
description: Add new content, examples, and improvements to Doc Detective documentation.
4-
sidebar_label: Standard Contributions
4+
sidebar_label: Standard changes
55
sidebar_position: 3
66
---
77

8-
# Standard contributions (10-30 minutes)
8+
import Tabs from "@theme/Tabs";
9+
import TabItem from "@theme/TabItem";
10+
11+
# Standard changes (10-30 minutes)
912

1013
Add new content, examples, and improvements to the documentation. You can work in your browser or set up a local development environment.
1114

@@ -14,7 +17,6 @@ Add new content, examples, and improvements to the documentation. You can work i
1417
- Adding missing steps to tutorials
1518
- Providing code examples
1619
- Adding troubleshooting tips
17-
- Creating FAQ entries
1820
- Adding "See also" links
1921
- Expanding brief explanations
2022
- Adding diagrams or screenshots
@@ -25,31 +27,35 @@ Add new content, examples, and improvements to the documentation. You can work i
2527

2628
Use GitHub's web editor for smaller additions:
2729

28-
1. Click "Edit this page" on any doc page
30+
1. Use the **Edit this page** button on any doc page
2931
2. Make your changes using the web editor
3032
3. Commit and create a pull request
3133

32-
**Good for:** Adding a few paragraphs, code examples, or list items
34+
👉 See [Quick changes](quick-start) for detailed instructions.
35+
36+
Good for adding a few paragraphs, code examples, or list items.
3337

3438
### Option 2: Local development (more powerful)
3539

3640
Set up a local environment to preview changes as you write:
3741

38-
👉 See [Local Development Setup](local-development) for detailed instructions
42+
👉 See [Local Development Setup](local-development) for detailed instructions.
3943

40-
**Good for:** Adding multiple sections, working across multiple files, or seeing live previews
44+
Good for adding multiple sections, working across multiple files, or seeing live previews.
4145

4246
## Using content templates
4347

4448
Templates help you structure your contribution and ensure you include all the important information.
4549

4650
Choose the template that matches what you're creating:
4751

48-
- **[How-to guide](templates/how-to)**: Task-focused step-by-step instructions
49-
- **[Tutorial](templates/tutorial)**: Learning-oriented guide through a complete workflow
50-
- **[Troubleshooting entry](templates/troubleshooting)**: Problem-solution format
51-
- **[Reference](templates/reference)**: Technical specifications or API documentation
52-
- **[Feature documentation](templates/feature)**: Document a new or changed feature
52+
| Template | Purpose |
53+
| --- | --- |
54+
| [How-to guide](templates/how-to) | Task-focused step-by-step instructions |
55+
| [Tutorial](templates/tutorial) | Learning-oriented guide through a complete workflow |
56+
| [Troubleshooting entry](templates/troubleshooting) | Problem-solution format |
57+
| [Reference](templates/reference) | Technical specifications or API documentation |
58+
| [Feature documentation](templates/feature) | Document a new or changed feature |
5359

5460
## Content guidelines
5561

@@ -77,14 +83,16 @@ Related topics and next steps
7783

7884
### Write clear instructions
7985

80-
**Do:**
86+
**Do**
87+
8188
- Use second person ("you") and active voice
8289
- Start steps with action verbs: "Click", "Type", "Navigate"
8390
- Put conditions before instructions: "If you want to save, click **Save**"
8491
- Use numbered lists for sequential steps
8592
- Use bulleted lists for non-sequential items
8693

87-
**Don't:**
94+
**Don't**
95+
8896
- Use first person ("we") or passive voice
8997
- Start steps with "Now" or "Then"
9098
- Bury conditions in the middle of instructions
@@ -111,7 +119,8 @@ Always test code examples before submitting:
111119
```
112120
````
113121

114-
Include:
122+
Include
123+
115124
- **Language identifier**: json, bash, typescript, etc.
116125
- **File name** (optional): Use `title="filename.ext"`
117126
- **Context**: Explain what the code does before showing it
@@ -124,30 +133,70 @@ Link to related documentation:
124133
See [Actions](/docs/category/actions) for available test actions.
125134
```
126135

127-
Use:
136+
Use
137+
128138
- **Absolute paths** for internal links: `/docs/path/to/page`
129139
- **HTTPS** for external links: `https://example.com`
130140
- **Descriptive link text**: Not "click here" or "this link"
131141

132142
### Admonitions (callouts)
133143

134-
Highlight important information:
135-
136-
```markdown
137-
:::tip
138-
Doc Detective can automatically detect tests in your documentation!
139-
:::
140-
141-
:::warning
142-
Make sure to close all browser instances before running tests.
143-
:::
144-
145-
:::info
146-
You can use either JSON or YAML format for test specifications.
147-
:::
148-
```
149-
150-
Available types: `note`, `tip`, `info`, `warning`, `danger`
144+
Highlight important information with admonitions. Make sure you use the appropriate type based on the severity and purpose of the message.
145+
146+
<Tabs>
147+
<TabItem label="Note" value="note">
148+
```markdown title="Note syntax"
149+
:::note
150+
`note` is for information that the user should be aware of but isn't critical.
151+
:::
152+
```
153+
154+
:::note
155+
`note` is for information that the user should be aware of but isn't critical.
156+
:::
157+
</TabItem>
158+
<TabItem label="Tip" value="tip">
159+
```markdown title="Tip syntax"
160+
:::tip
161+
`tip` is for useful advice or shortcuts that can help the user.
162+
:::
163+
```
164+
165+
:::tip
166+
`tip` is for useful advice or shortcuts that can help the user.
167+
:::
168+
</TabItem>
169+
<TabItem label="Info" value="info">
170+
```markdown title="Info syntax"
171+
:::info
172+
`info` is for useful information that isn't critical but may help the user.
173+
:::
174+
```
175+
:::info
176+
`info` is for useful information that isn't critical but may help the user.
177+
:::
178+
</TabItem>
179+
<TabItem label="Warning" value="warning">
180+
```markdown title="Warning syntax"
181+
:::warning
182+
`warning` should be used when an action may be difficult to undo or may cost the user unexpected time or resources.
183+
:::
184+
```
185+
:::warning
186+
`warning` should be used when an action may be difficult to undo or may cost the user unexpected time or resources.
187+
:::
188+
</TabItem>
189+
<TabItem label="Danger" value="danger">
190+
```markdown title="Danger syntax"
191+
:::danger
192+
`danger` should be used when there's a risk of data loss, unexpected cost, or harm.
193+
:::
194+
```
195+
:::danger
196+
`danger` should be used when there's a risk of data loss, unexpected cost, or harm.
197+
:::
198+
</TabItem>
199+
</Tabs>
151200

152201
## Before submitting
153202

@@ -169,39 +218,40 @@ Don't worry if you skip these—the CI/CD pipeline runs them automatically.
169218

170219
Before creating a pull request:
171220

172-
1. Read your changes out loud—does it make sense?
173-
2. Test any code examples or commands
174-
3. Check that links work
175-
4. Verify screenshots are clear and relevant
176-
5. Make sure formatting looks correct
221+
1. Read your changes out loud—does it make sense?
222+
2. Test any code examples or commands.
223+
3. Check that links work.
224+
4. Verify screenshots are clear and relevant.
225+
5. Make sure formatting looks correct.
177226

178227
### Create a pull request
179228

180-
1. **Title**: Briefly describe what you added
229+
1. **Title**: Briefly describe what you added. Examples:
230+
181231
-`Add troubleshooting guide for browser detection`
182232
-`Document file upload action with examples`
183-
-`Update docs`
184233

185-
2. **Description**: Use the PR template to provide context
234+
2. **Description**: Use the PR template to provide context:
235+
186236
- What did you add or change?
187237
- Why is this helpful?
188238
- Related issue number (if applicable)
189239

190-
3. **Submit**: Click "Create pull request"
240+
3. **Submit**: Create your pull request.
191241

192242
## What happens during review
193243

194244
1. **Automated checks** run (typically 2-5 minutes)
195245
2. **Maintainer reviews** your contribution (within 5 business days)
196246
3. **Feedback or approval**:
197-
- If changes are needed, update your pull request
247+
- If changes are needed, update your pull request.
198248
- If approved, your contribution is merged!
199249

200250
### Understanding automated checks
201251

202252
#### Vale (style checking)
203253

204-
Vale enforces the Google Developer Style Guide. Common suggestions:
254+
Vale enforces the documentation style guide. Common suggestions include
205255

206256
- Use "you" instead of "the user"
207257
- Avoid "please" in instructions
@@ -212,29 +262,32 @@ Most Vale suggestions are just that—suggestions. Reviewers use judgment.
212262

213263
#### Link validation
214264

215-
Checks that all links work. If this fails:
265+
Checks that all links work. If this fails,
266+
216267
- Verify external URLs are correct
217268
- Check internal link paths (case-sensitive)
218269
- Make sure linked pages exist
219270

220271
#### Build check
221272

222-
Ensures the documentation site builds successfully. Failures usually indicate:
273+
Make sure that the documentation site builds successfully. Failures usually indicate
274+
223275
- Markdown syntax errors
224276
- Missing closing tags
225277
- Invalid front matter
226278

227279
## Need help?
228280

229281
### During writing
230-
- **Not sure about structure?** Check similar pages in the docs
231-
- **Questions about content?** Ask in [Discord](https://discord.gg/2M7wXEThfF)
232-
- **Stuck on technical details?** Reference the [AGENTS.md](https://github.com/doc-detective/doc-detective.github.io/blob/main/AGENTS.md) file
282+
283+
- **Not sure about structure?** Check similar pages in the docs.
284+
- **Questions about content or technical details?** Ask in [Discord](https://discord.gg/2M7wXEThfF).
233285

234286
### After submitting
235-
- **Automated checks failed?** Check the details in the PR—reviewers can help
236-
- **No response yet?** Wait 5 business days, then ping in the PR
237-
- **Need to make changes?** Just commit to the same branch—the PR updates automatically
287+
288+
- **Automated checks failed?** Check the details in the PR—reviewers can help.
289+
- **No response yet?** Wait 5 business days, then ping in the PR.
290+
- **Need to make changes?** Just commit to the same branch—the PR updates automatically.
238291

239292
## Ready for bigger projects?
240293

docs/contributing/substantial-contributions.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
---
2-
title: Substantial Contributions
2+
title: Substantial changes
33
description: Take on major documentation projects with guidance and technical writer support.
4-
sidebar_label: Substantial Contributions
4+
sidebar_label: Substantial changes
55
sidebar_position: 4
66
---
77

8-
# Substantial contributions (30+ minutes)
8+
# Substantial changes (30+ minutes)
99

1010
Major documentation projects that significantly expand or improve the Doc Detective documentation.
1111

0 commit comments

Comments
 (0)