Add a message in case of success for install/uninstall/upgrade actions

Signed-off-by: Silvin Lubecki <[email protected]>

Author: silvin-lubecki

internal/commands/install.go

@@ -131,12 +131,17 @@ func runInstall(dockerCli command.Cli, appname string, opts installOptions) erro
 	inst := &action.Install{
 		Driver: driverImpl,
 	}
-	err = inst.Run(c, creds, dockerCli.Out())
+	err = inst.Run(c, creds, os.Stdout)
 	// Even if the installation failed, the installation is persisted with its failure status,
 	// so any installation needs a clean uninstallation.
 	err2 := installationStore.Store(*c)
 	if err != nil {
-		return fmt.Errorf("install failed: %s", errBuf)
+		return fmt.Errorf("Installation failed: %s", errBuf)
 	}
-	return err2
+	if err2 != nil {
+		return err2
+	}
+
+	fmt.Printf("Application %q installed on context %q\n", installationName, opts.targetContext)
+	return nil
 }

internal/commands/uninstall.go

@@ -2,6 +2,7 @@ package commands
 
 import (
 	"fmt"
+	"os"
 
 	"github.com/deislabs/duffle/pkg/action"
 	"github.com/deislabs/duffle/pkg/credentials"
@@ -58,12 +59,15 @@ func runUninstall(dockerCli command.Cli, installationName string, opts credentia
 	uninst := &action.Uninstall{
 		Driver: driverImpl,
 	}
-	err = uninst.Run(&c, creds, dockerCli.Out())
-	if err == nil {
-		return installationStore.Delete(installationName)
+	if err := uninst.Run(&c, creds, os.Stdout); err != nil {
+		if err2 := installationStore.Store(c); err2 != nil {
+			return fmt.Errorf("%s while %s", err2, errBuf)
+		}
+		return fmt.Errorf("Uninstall failed: %s", errBuf)
 	}
-	if err2 := installationStore.Store(c); err2 != nil {
-		fmt.Fprintf(dockerCli.Err(), "failed to update installation: %s\n", err2)
+	if err := installationStore.Delete(installationName); err != nil {
+		return fmt.Errorf("Failed to delete installation %q from the installation store: %s", installationName, err)
 	}
-	return fmt.Errorf("uninstall failed: %s", errBuf)
+	fmt.Printf("Application %q uninstalled on context %q\n", installationName, opts.targetContext)
+	return nil
 }

internal/commands/upgrade.go

@@ -92,7 +92,11 @@ func runUpgrade(dockerCli command.Cli, installationName string, opts upgradeOpti
 	err = u.Run(&installation, creds, os.Stdout)
 	err2 := installationStore.Store(installation)
 	if err != nil {
-		return fmt.Errorf("upgrade failed: %s", errBuf)
+		return fmt.Errorf("Upgrade failed: %s", errBuf)
 	}
-	return err2
+	if err2 != nil {
+		return err2
+	}
+	fmt.Printf("Application %q upgraded on context %q\n", installationName, opts.targetContext)
+	return nil
 }