Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Commit 4329e70

Browse files
The coverage (and so the unit tests) was running as detached, so if one test fails the target won't fail because of it, but just because it can't find the coverage files.
Fixed this running the tests in attached mode + renaming Coverage step in the jenkinsfile to a more obvious step Unit Coverage. Signed-off-by: Silvin Lubecki <[email protected]>
1 parent 9c72172 commit 4329e70

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

Jenkinsfile.baguette

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ pipeline {
8080
}
8181
stage('Test') {
8282
parallel {
83-
stage("Coverage") {
83+
stage("Unit Coverage") {
8484
environment {
8585
CODECOV_TOKEN = credentials('jenkins-codecov-token')
8686
}

docker.Makefile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,7 @@ test-e2e: build_dev_image invocation-image ## run end-to-end tests
8989
COV_LABEL := com.docker.app.cov-run=$(TAG)
9090
coverage: build_dev_image ## run tests with coverage
9191
@$(call mkdir,_build)
92-
docker run -v /var/run:/var/run:ro --name $(COV_CTNR_NAME) --network="host" -tid $(DEV_IMAGE_NAME) make COMMIT=${COMMIT} TAG=${TAG} EXPERIMENTAL=$(EXPERIMENTAL) coverage
93-
docker logs -f $(COV_CTNR_NAME)
92+
docker run -v /var/run:/var/run:ro --name $(COV_CTNR_NAME) --network="host" -t $(DEV_IMAGE_NAME) make COMMIT=${COMMIT} TAG=${TAG} EXPERIMENTAL=$(EXPERIMENTAL) coverage
9493
docker cp $(COV_CTNR_NAME):$(PKG_PATH)/_build/cov/ ./_build/ci-cov
9594
docker rm $(COV_CTNR_NAME)
9695

0 commit comments

Comments
 (0)