Improved the error reporting when pushing/pulling apps in the e2e tests by printing the registry logs. Fix the HTTP call to the registry by adding the missing Accept header.

Signed-off-by: Jean-Christophe Sirot <[email protected]>

Author: Jean-Christophe Sirot

Makefile

@@ -24,6 +24,11 @@ ifeq ($(OS),Windows_NT)
   EXEC_EXT := .exe
 endif
 
+INCLUDE_E2E :=
+ifneq ($(E2E_TESTS),)
+  INCLUDE_E2E := -run $(E2E_TESTS)
+endif
+
 TEST_RESULTS_DIR = _build/test-results
 STATIC_FLAGS= CGO_ENABLED=0
 GO_BUILD = $(STATIC_FLAGS) go build -tags=$(BUILDTAGS) -ldflags=$(LDFLAGS)
@@ -78,7 +83,7 @@ lint: ## run linter(s)
 test-e2e: bin/$(BIN_NAME) ## run end-to-end tests
 	@echo "Running e2e tests..."
 	@$(call mkdir,$(TEST_RESULTS_DIR))
-	$(call GO_TESTSUM,e2e.xml) -v ./e2e/
+	$(call GO_TESTSUM,e2e.xml) -v ./e2e/ $(INCLUDE_E2E)
 
 test-unit: ## run unit tests
 	@echo "Running unit tests..."

e2e/helper_test.go

@@ -107,3 +107,9 @@ func (c *Container) GetPrivateAddress(t *testing.T) string {
 	result := icmd.RunCommand(dockerCli.path, "inspect", container, "-f", "{{.NetworkSettings.IPAddress}}").Assert(t, icmd.Success)
 	return fmt.Sprintf("%s:%d", strings.TrimSpace(result.Stdout()), c.privatePort)
 }
+
+func (c *Container) Logs(t *testing.T) func() string {
+	return func() string {
+		return icmd.RunCommand(dockerCli.path, "logs", c.container).Assert(t, icmd.Success).Combined()
+	}
+}

e2e/pushpull_test.go

@@ -3,6 +3,7 @@ package e2e
 import (
 	"encoding/json"
 	"fmt"
+	"io/ioutil"
 	"math/rand"
 	"net"
 	"net/http"
@@ -28,6 +29,7 @@ type dindSwarmAndRegistryInfo struct {
 	registryAddress string
 	configuredCmd   icmd.Cmd
 	stopRegistry    func()
+	registryLogs    func() string
 }
 
 func runWithDindSwarmAndRegistry(t *testing.T, todo func(dindSwarmAndRegistryInfo)) {
@@ -88,6 +90,7 @@ func runWithDindSwarmAndRegistry(t *testing.T, todo func(dindSwarmAndRegistryInf
 		registryAddress: registry.GetAddress(t),
 		swarmAddress:    swarm.GetAddress(t),
 		stopRegistry:    registry.StopNoFail,
+		registryLogs:    registry.Logs(t),
 	}
 	todo(info)
 
@@ -165,11 +168,16 @@ func TestPushArchs(t *testing.T) {
 				icmd.RunCmd(cmd).Assert(t, icmd.Success)
 
 				var index v1.Index
-				httpGet(t, "http://"+info.registryAddress+"/v2/test/push-pull/manifests/1", &index)
+				headers := map[string]string{
+					"Accept": "application/vnd.docker.distribution.manifest.list.v2+json",
+				}
+				err := httpGet("http://"+info.registryAddress+"/v2/test/push-pull/manifests/1", headers, &index)
+				assert.NilError(t, err, info.registryLogs())
 				digest, err := getManifestListDigest(index)
-				assert.NilError(t, err)
+				assert.NilError(t, err, info.registryLogs())
 				var manifestList manifestlist.ManifestList
-				httpGet(t, "http://"+info.registryAddress+"/v2/test/push-pull/manifests/"+digest.String(), &manifestList)
+				err = httpGet("http://"+info.registryAddress+"/v2/test/push-pull/manifests/"+digest.String(), headers, &manifestList)
+				assert.NilError(t, err)
 				assert.Equal(t, len(manifestList.Manifests), len(testCase.expectedPlatforms), "Unexpected number of platforms")
 				for _, m := range manifestList.Manifests {
 					assert.Assert(t, cmp.Contains(testCase.expectedPlatforms, m.Platform), "Platform expected but not found: %s", m.Platform)
@@ -312,13 +320,31 @@ func isPortAvailable(port int) bool {
 	return true
 }
 
-func httpGet(t *testing.T, url string, obj interface{}) {
-	r, err := http.Get(url)
-	assert.NilError(t, err)
+func httpGet(url string, headers map[string]string, obj interface{}) error {
+	client := &http.Client{}
+	req, err := http.NewRequest("GET", url, nil)
+	if err != nil {
+		return err
+	}
+	for k, v := range headers {
+		req.Header.Set(k, v)
+	}
+	r, err := client.Do(req)
+	if err != nil {
+		return err
+	}
 	defer r.Body.Close()
-	assert.Equal(t, r.StatusCode, 200)
-	err = json.NewDecoder(r.Body).Decode(obj)
-	assert.NilError(t, err)
+	if r.StatusCode != http.StatusOK {
+		body, err := ioutil.ReadAll(r.Body)
+		if err != nil {
+			return err
+		}
+		return fmt.Errorf("unexpected http error code %d with message %s", r.StatusCode, string(body))
+	}
+	if err := json.NewDecoder(r.Body).Decode(obj); err != nil {
+		return err
+	}
+	return nil
 }
 
 func getManifestListDigest(index v1.Index) (digest.Digest, error) {