Add List command to list all the installations, and their result, made from the host.

Signed-off-by: Silvin Lubecki <[email protected]>

Author: silvin-lubecki

README.md

@@ -351,6 +351,7 @@ Commands:
   init        Initialize Docker Application definition
   inspect     Shows metadata, parameters and a summary of the Compose file for a given application
   install     Install an application
+  list        List the installations and their last known installation result
   merge       Merge a directory format Docker Application definition into a single file
   pull        Pull an application package from a registry
   push        Push an application package to a registry

e2e/commands_test.go

@@ -350,6 +350,14 @@ func testDockerAppLifecycle(t *testing.T, useBindMount bool) {
 			fmt.Sprintf("[[:alnum:]]+        %s_api   replicated          [0-1]/1                 python:3.6", appName),
 		})
 
+	// List the installed applications
+	cmd.Command = dockerCli.Command("app", "list")
+	checkContains(t, icmd.RunCmd(cmd).Assert(t, icmd.Success).Combined(),
+		[]string{
+			`INSTALLATION\s+LAST ACTION\s+RESULT\s+CREATED\s+MODIFIED`,
+			fmt.Sprintf(`%s\s+install\s+success\s+[[:alnum:]]+\ssecond.\s+[[:alnum:]]+\ssecond`, appName),
+		})
+
 	// Installing again the same application is forbidden
 	cmd.Command = dockerCli.Command("app", "install", "testdata/simple/simple.dockerapp", "--name", appName)
 	icmd.RunCmd(cmd).Assert(t, icmd.Expected{
@@ -420,6 +428,6 @@ func initializeDockerAppEnvironment(t *testing.T, cmd *icmd.Cmd, tmpDir *fs.Dir,
 func checkContains(t *testing.T, combined string, expectedLines []string) {
 	for _, expected := range expectedLines {
 		exp := regexp.MustCompile(expected)
-		assert.Assert(t, exp.MatchString(combined), expected, combined)
+		assert.Assert(t, exp.MatchString(combined), "expected %q != actual %q", expected, combined)
 	}
 }

e2e/testdata/plugin-usage-experimental.golden

@@ -9,6 +9,7 @@ Commands:
   init        Initialize Docker Application definition
   inspect     Shows metadata, parameters and a summary of the Compose file for a given application
   install     Install an application
+  list        List the installations and their last known installation result
   merge       Merge a directory format Docker Application definition into a single file
   pull        Pull an application package from a registry
   push        Push an application package to a registry

e2e/testdata/plugin-usage.golden

@@ -9,6 +9,7 @@ Commands:
   init        Initialize Docker Application definition
   inspect     Shows metadata, parameters and a summary of the Compose file for a given application
   install     Install an application
+  list        List the installations and their last known installation result
   merge       Merge a directory format Docker Application definition into a single file
   pull        Pull an application package from a registry
   push        Push an application package to a registry

internal/commands/list.go

@@ -0,0 +1,96 @@
+package commands
+
+import (
+	"fmt"
+	"io"
+	"strings"
+	"text/tabwriter"
+	"time"
+
+	"github.com/deislabs/duffle/pkg/claim"
+
+	"github.com/docker/app/internal/store"
+	"github.com/docker/cli/cli"
+	"github.com/docker/cli/cli/command"
+	"github.com/docker/cli/cli/config"
+	units "github.com/docker/go-units"
+	"github.com/spf13/cobra"
+)
+
+type listOptions struct {
+	targetContext string
+}
+
+var (
+	listColumns = []struct {
+		header string
+		value  func(c *claim.Claim) string
+	}{
+		{"INSTALLATION", func(c *claim.Claim) string { return c.Name }},
+		{"LAST ACTION", func(c *claim.Claim) string { return c.Result.Action }},
+		{"RESULT", func(c *claim.Claim) string { return c.Result.Status }},
+		{"CREATED", func(c *claim.Claim) string { return units.HumanDuration(time.Since(c.Created)) }},
+		{"MODIFIED", func(c *claim.Claim) string { return units.HumanDuration(time.Since(c.Modified)) }}}
+)
+
+func listCmd(dockerCli command.Cli) *cobra.Command {
+	var opts listOptions
+
+	cmd := &cobra.Command{
+		Use:     "list [OPTIONS]",
+		Short:   "List the installations and their last known installation result",
+		Aliases: []string{"ls"},
+		Args:    cli.NoArgs,
+		RunE: func(cmd *cobra.Command, args []string) error {
+			return runList(dockerCli, opts)
+		},
+	}
+	cmd.Flags().StringVar(&opts.targetContext, "target-context", "", "List installations on this context")
+
+	return cmd
+}
+
+func runList(dockerCli command.Cli, opts listOptions) error {
+	targetContext := getTargetContext(opts.targetContext, dockerCli.CurrentContext())
+
+	appstore, err := store.NewApplicationStore(config.Dir())
+	if err != nil {
+		return err
+	}
+	installationStore, err := appstore.InstallationStore(targetContext)
+	if err != nil {
+		return err
+	}
+
+	installations, err := installationStore.List()
+	if err != nil {
+		return err
+	}
+	w := tabwriter.NewWriter(dockerCli.Out(), 0, 0, 1, ' ', 0)
+	printHeaders(w)
+
+	for _, c := range installations {
+		installation, err := installationStore.Read(c)
+		if err != nil {
+			return err
+		}
+		printValues(w, &installation)
+	}
+	return w.Flush()
+}
+
+func printHeaders(w io.Writer) {
+	var headers []string
+	for _, column := range listColumns {
+		headers = append(headers, column.header)
+	}
+	fmt.Fprintln(w, strings.Join(headers, "\t"))
+}
+
+func printValues(w io.Writer, installation *claim.Claim) {
+	var values []string
+	for _, column := range listColumns {
+		values = append(values, column.value(installation))
+	}
+	fmt.Fprintln(w, strings.Join(values, "\t"))
+}

internal/commands/root.go

@@ -26,6 +26,7 @@ func addCommands(cmd *cobra.Command, dockerCli command.Cli) {
 		installCmd(dockerCli),
 		upgradeCmd(dockerCli),
 		uninstallCmd(dockerCli),
+		listCmd(dockerCli),
 		statusCmd(dockerCli),
 		initCmd(dockerCli),
 		inspectCmd(dockerCli),