Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Commit 5d97b59

Browse files
Merge pull request #623 from ndeloof/remove-follow-up
Rename function/struct to match new commande name
2 parents 3baa67c + 3335328 commit 5d97b59

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

internal/commands/remove.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ import (
1111
"github.com/spf13/cobra"
1212
)
1313

14-
type uninstallOptions struct {
14+
type removeOptions struct {
1515
credentialOptions
1616
force bool
1717
}
1818

19-
func uninstallCmd(dockerCli command.Cli) *cobra.Command {
20-
var opts uninstallOptions
19+
func removeCmd(dockerCli command.Cli) *cobra.Command {
20+
var opts removeOptions
2121

2222
cmd := &cobra.Command{
2323
Use: "rm INSTALLATION_NAME [--target-context TARGET_CONTEXT] [OPTIONS]",
@@ -26,7 +26,7 @@ func uninstallCmd(dockerCli command.Cli) *cobra.Command {
2626
Example: `$ docker app rm myinstallation --target-context=mycontext`,
2727
Args: cli.ExactArgs(1),
2828
RunE: func(cmd *cobra.Command, args []string) error {
29-
return runUninstall(dockerCli, args[0], opts)
29+
return runRemove(dockerCli, args[0], opts)
3030
},
3131
}
3232
opts.addFlags(cmd.Flags())
@@ -35,7 +35,7 @@ func uninstallCmd(dockerCli command.Cli) *cobra.Command {
3535
return cmd
3636
}
3737

38-
func runUninstall(dockerCli command.Cli, installationName string, opts uninstallOptions) (mainErr error) {
38+
func runRemove(dockerCli command.Cli, installationName string, opts removeOptions) (mainErr error) {
3939
defer muteDockerCli(dockerCli)()
4040
opts.SetDefaultTargetContext(dockerCli)
4141

@@ -79,7 +79,7 @@ func runUninstall(dockerCli command.Cli, installationName string, opts uninstall
7979
if err2 := installationStore.Store(installation); err2 != nil {
8080
return fmt.Errorf("%s while %s", err2, errBuf)
8181
}
82-
return fmt.Errorf("Uninstall failed: %s\n%s", err, errBuf)
82+
return fmt.Errorf("Remove failed: %s\n%s", err, errBuf)
8383
}
8484
if err := installationStore.Delete(installationName); err != nil {
8585
return fmt.Errorf("Failed to delete installation %q from the installation store: %s", installationName, err)

internal/commands/root.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ func addCommands(cmd *cobra.Command, dockerCli command.Cli) {
6161
cmd.AddCommand(
6262
installCmd(dockerCli),
6363
upgradeCmd(dockerCli),
64-
uninstallCmd(dockerCli),
64+
removeCmd(dockerCli),
6565
listCmd(dockerCli),
6666
statusCmd(dockerCli),
6767
initCmd(dockerCli),

0 commit comments

Comments
 (0)