Handle images without an explicit tag

Signed-off-by: Nicolas De Loof <[email protected]>

Author: ndeloof

e2e/images_test.go

@@ -14,11 +14,11 @@ import (
 
 func insertBundles(t *testing.T, cmd icmd.Cmd, info dindSwarmAndRegistryInfo) {
 	// Push an application so that we can later pull it by digest
-	cmd.Command = dockerCli.Command("app", "build", "--tag", info.registryAddress+"/c-myapp", filepath.Join("testdata", "push-pull"))
+	cmd.Command = dockerCli.Command("app", "build", "--no-resolve-image", "--tag", info.registryAddress+"/c-myapp", filepath.Join("testdata", "push-pull"))
 	icmd.RunCmd(cmd).Assert(t, icmd.Success)
-	cmd.Command = dockerCli.Command("app", "build", "--tag", "b-simple-app", filepath.Join("testdata", "simple"))
+	cmd.Command = dockerCli.Command("app", "build", "--no-resolve-image", "--tag", "b-simple-app", filepath.Join("testdata", "simple"))
 	icmd.RunCmd(cmd).Assert(t, icmd.Success)
-	cmd.Command = dockerCli.Command("app", "build", "--tag", "a-simple-app", filepath.Join("testdata", "simple"))
+	cmd.Command = dockerCli.Command("app", "build", "--no-resolve-image", "--tag", "a-simple-app", filepath.Join("testdata", "simple"))
 	icmd.RunCmd(cmd).Assert(t, icmd.Success)
 }
 

e2e/testdata/app-inspect.golden

@@ -27,7 +27,7 @@
         },
         {
             "Name": "web",
-            "Image": "nginx:latest",
+            "Image": "nginx",
             "Replicas": 1,
             "Ports": "8082"
         }

e2e/testdata/expected-json-render.golden

@@ -47,7 +47,7 @@
         "resources": {},
         "placement": {}
       },
-      "image": "nginx:latest",
+      "image": "nginx",
       "networks": {
         "front": null
       },

e2e/testdata/expected-yaml-render.golden

@@ -13,7 +13,7 @@ services:
     networks:
       back: null
   web:
-    image: nginx:latest
+    image: nginx
     networks:
       front: null
     ports:

e2e/testdata/simple/simple.dockerapp/docker-compose.yml

@@ -9,7 +9,7 @@ services:
           - api.example.com
           - ${api_host}
   web:
-    image: nginx:latest
+    image: nginx
     networks:
       - front
     volumes:

internal/commands/build/build.go

@@ -200,7 +200,7 @@ func fixServiceImageReferences(ctx context.Context, dockerCli command.Cli, bundl
 	resolver := remotes.CreateResolver(dockerCli.ConfigFile(), insecureRegistries...)
 	for _, service := range pulledServices {
 		image := bundle.Images[service.Name]
-		ref, err := reference.ParseNormalizedNamed(*service.Image)
+		ref, err := reference.ParseDockerRef(*service.Image)
 		if err != nil {
 			return errors.Wrapf(err, "could not resolve image %s", *service.Image)
 		}