Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Commit 6f81a9a

Browse files
committed
Normalize line endings before testing file contents
This fixes the tests for windows. Signed-off-by: Mathieu Champlon <[email protected]>
1 parent 3ae9b51 commit 6f81a9a

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

e2e/render_test.go

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,19 @@ func TestRender(t *testing.T) {
4545
// run the render
4646
result, resultErr := packager.Render(path.Join("render", app.Name()), overrides, settings, env)
4747
if resultErr != nil {
48-
expectedErr, err := ioutil.ReadFile(path.Join("render", app.Name(), "expectedError.txt"))
49-
assert.NilError(t, err, "unexpected render error: %q", resultErr)
50-
assert.ErrorContains(t, resultErr, string(expectedErr))
48+
expectedErr := readFile(t, path.Join("render", app.Name(), "expectedError.txt"))
49+
assert.ErrorContains(t, resultErr, expectedErr)
5150
} else {
52-
expectedRender, err := ioutil.ReadFile(path.Join("render", app.Name(), "expected.txt"))
53-
assert.NilError(t, err, "missing 'expected.txt' file")
51+
expectedRender := readFile(t, path.Join("render", app.Name(), "expected.txt"))
5452
assert.Equal(t, string(expectedRender), result, "rendering missmatch")
5553
}
5654
}
5755
}
56+
57+
// readFile returns the content of the file at the designated path normalizing
58+
// line endings by removing any \r.
59+
func readFile(t *testing.T, path string) string {
60+
content, err := ioutil.ReadFile(path)
61+
assert.NilError(t, err, "missing '"+path+"' file")
62+
return strings.Replace(string(content), "\r", "", -1)
63+
}

0 commit comments

Comments
 (0)