@@ -103,7 +103,7 @@ func withParameterAndValues(name, typ string, allowedValues []interface{}) bundl
103
103
}
104
104
}
105
105
106
- func mockBundle (ops ... bundleOperator ) * bundle.Bundle {
106
+ func prepareBundle (ops ... bundleOperator ) * bundle.Bundle {
107
107
b := & bundle.Bundle {}
108
108
for _ , op := range ops {
109
109
op (b )
@@ -119,15 +119,15 @@ func TestWithOrchestratorParameters(t *testing.T) {
119
119
}{
120
120
{
121
121
name : "Bundle with orchestrator params" ,
122
- bundle : mockBundle (withParameter (internal .ParameterOrchestratorName , "string" ), withParameter (internal .ParameterKubernetesNamespaceName , "string" )),
122
+ bundle : prepareBundle (withParameter (internal .ParameterOrchestratorName , "string" ), withParameter (internal .ParameterKubernetesNamespaceName , "string" )),
123
123
expected : map [string ]string {
124
124
internal .ParameterOrchestratorName : "kubernetes" ,
125
125
internal .ParameterKubernetesNamespaceName : "my-namespace" ,
126
126
},
127
127
},
128
128
{
129
129
name : "Bundle without orchestrator params" ,
130
- bundle : mockBundle (),
130
+ bundle : prepareBundle (),
131
131
expected : map [string ]string {},
132
132
},
133
133
}
@@ -152,7 +152,7 @@ func TestMergeBundleParameters(t *testing.T) {
152
152
params ["param" ] = "second"
153
153
return nil
154
154
}
155
- bundle := mockBundle (withParameterAndDefault ("param" , "string" , "default" ))
155
+ bundle := prepareBundle (withParameterAndDefault ("param" , "string" , "default" ))
156
156
i := & store.Installation {Claim : claim.Claim {Bundle : bundle }}
157
157
err := mergeBundleParameters (i ,
158
158
first ,
@@ -166,7 +166,7 @@ func TestMergeBundleParameters(t *testing.T) {
166
166
})
167
167
168
168
t .Run ("Default values" , func (t * testing.T ) {
169
- bundle := mockBundle (withParameterAndDefault ("param" , "string" , "default" ))
169
+ bundle := prepareBundle (withParameterAndDefault ("param" , "string" , "default" ))
170
170
i := & store.Installation {Claim : claim.Claim {Bundle : bundle }}
171
171
err := mergeBundleParameters (i )
172
172
assert .NilError (t , err )
@@ -181,7 +181,7 @@ func TestMergeBundleParameters(t *testing.T) {
181
181
params ["param" ] = "1"
182
182
return nil
183
183
}
184
- bundle := mockBundle (withParameter ("param" , "integer" ))
184
+ bundle := prepareBundle (withParameter ("param" , "integer" ))
185
185
i := & store.Installation {Claim : claim.Claim {Bundle : bundle }}
186
186
err := mergeBundleParameters (i , withIntValue )
187
187
assert .NilError (t , err )
@@ -192,7 +192,7 @@ func TestMergeBundleParameters(t *testing.T) {
192
192
})
193
193
194
194
t .Run ("Default values" , func (t * testing.T ) {
195
- bundle := mockBundle (withParameterAndDefault ("param" , "string" , "default" ))
195
+ bundle := prepareBundle (withParameterAndDefault ("param" , "string" , "default" ))
196
196
i := & store.Installation {Claim : claim.Claim {Bundle : bundle }}
197
197
err := mergeBundleParameters (i )
198
198
assert .NilError (t , err )
@@ -207,7 +207,7 @@ func TestMergeBundleParameters(t *testing.T) {
207
207
params ["param" ] = "1"
208
208
return nil
209
209
}
210
- bundle := mockBundle ()
210
+ bundle := prepareBundle ()
211
211
i := & store.Installation {Claim : claim.Claim {Bundle : bundle }}
212
212
err := mergeBundleParameters (i , withUndefined )
213
213
assert .ErrorContains (t , err , "is not defined in the bundle" )
@@ -218,7 +218,7 @@ func TestMergeBundleParameters(t *testing.T) {
218
218
params ["param" ] = "foo"
219
219
return nil
220
220
}
221
- bundle := mockBundle (withParameter ("param" , "integer" ))
221
+ bundle := prepareBundle (withParameter ("param" , "integer" ))
222
222
i := & store.Installation {Claim : claim.Claim {Bundle : bundle }}
223
223
err := mergeBundleParameters (i , withIntValue )
224
224
assert .ErrorContains (t , err , "invalid value for parameter" )
@@ -229,7 +229,7 @@ func TestMergeBundleParameters(t *testing.T) {
229
229
params ["param" ] = "invalid"
230
230
return nil
231
231
}
232
- bundle := mockBundle (withParameterAndValues ("param" , "string" , []interface {}{"valid" }))
232
+ bundle := prepareBundle (withParameterAndValues ("param" , "string" , []interface {}{"valid" }))
233
233
i := & store.Installation {Claim : claim.Claim {Bundle : bundle }}
234
234
err := mergeBundleParameters (i , withInvalidValue )
235
235
assert .ErrorContains (t , err , "invalid value for parameter" )
0 commit comments