Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Commit a7e36bd

Browse files
author
Jean-Christophe Sirot
committed
Bump cnab-to-oci, cnab-go and duffle dependencies
Signed-off-by: Jean-Christophe Sirot <[email protected]>
1 parent de4e7d0 commit a7e36bd

File tree

6 files changed

+61
-69
lines changed

6 files changed

+61
-69
lines changed

Gopkg.lock

Lines changed: 6 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Gopkg.toml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,11 @@ required = ["github.com/wadey/gocovmerge"]
4242

4343
[[override]]
4444
name = "github.com/deislabs/duffle"
45-
branch = "sync-cnab-go-dep"
46-
source = "https://github.com/jcsirot/duffle.git"
45+
revision = "5930527762a46c7adfcfccaec1e6a2ddf5841319"
4746

4847
[[override]]
4948
name = "github.com/deislabs/cnab-go"
50-
branch = "fix-nil-pointer-default-value"
51-
source = "https://github.com/jcsirot/cnab-go.git"
49+
branch = "master"
5250

5351
[[constraint]]
5452
name = "github.com/sirupsen/logrus"

internal/commands/parameters_test.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ func withParameterAndValues(name, typ string, allowedValues []interface{}) bundl
103103
}
104104
}
105105

106-
func mockBundle(ops ...bundleOperator) *bundle.Bundle {
106+
func prepareBundle(ops ...bundleOperator) *bundle.Bundle {
107107
b := &bundle.Bundle{}
108108
for _, op := range ops {
109109
op(b)
@@ -119,15 +119,15 @@ func TestWithOrchestratorParameters(t *testing.T) {
119119
}{
120120
{
121121
name: "Bundle with orchestrator params",
122-
bundle: mockBundle(withParameter(internal.ParameterOrchestratorName, "string"), withParameter(internal.ParameterKubernetesNamespaceName, "string")),
122+
bundle: prepareBundle(withParameter(internal.ParameterOrchestratorName, "string"), withParameter(internal.ParameterKubernetesNamespaceName, "string")),
123123
expected: map[string]string{
124124
internal.ParameterOrchestratorName: "kubernetes",
125125
internal.ParameterKubernetesNamespaceName: "my-namespace",
126126
},
127127
},
128128
{
129129
name: "Bundle without orchestrator params",
130-
bundle: mockBundle(),
130+
bundle: prepareBundle(),
131131
expected: map[string]string{},
132132
},
133133
}
@@ -152,7 +152,7 @@ func TestMergeBundleParameters(t *testing.T) {
152152
params["param"] = "second"
153153
return nil
154154
}
155-
bundle := mockBundle(withParameterAndDefault("param", "string", "default"))
155+
bundle := prepareBundle(withParameterAndDefault("param", "string", "default"))
156156
i := &store.Installation{Claim: claim.Claim{Bundle: bundle}}
157157
err := mergeBundleParameters(i,
158158
first,
@@ -166,7 +166,7 @@ func TestMergeBundleParameters(t *testing.T) {
166166
})
167167

168168
t.Run("Default values", func(t *testing.T) {
169-
bundle := mockBundle(withParameterAndDefault("param", "string", "default"))
169+
bundle := prepareBundle(withParameterAndDefault("param", "string", "default"))
170170
i := &store.Installation{Claim: claim.Claim{Bundle: bundle}}
171171
err := mergeBundleParameters(i)
172172
assert.NilError(t, err)
@@ -181,7 +181,7 @@ func TestMergeBundleParameters(t *testing.T) {
181181
params["param"] = "1"
182182
return nil
183183
}
184-
bundle := mockBundle(withParameter("param", "integer"))
184+
bundle := prepareBundle(withParameter("param", "integer"))
185185
i := &store.Installation{Claim: claim.Claim{Bundle: bundle}}
186186
err := mergeBundleParameters(i, withIntValue)
187187
assert.NilError(t, err)
@@ -192,7 +192,7 @@ func TestMergeBundleParameters(t *testing.T) {
192192
})
193193

194194
t.Run("Default values", func(t *testing.T) {
195-
bundle := mockBundle(withParameterAndDefault("param", "string", "default"))
195+
bundle := prepareBundle(withParameterAndDefault("param", "string", "default"))
196196
i := &store.Installation{Claim: claim.Claim{Bundle: bundle}}
197197
err := mergeBundleParameters(i)
198198
assert.NilError(t, err)
@@ -207,7 +207,7 @@ func TestMergeBundleParameters(t *testing.T) {
207207
params["param"] = "1"
208208
return nil
209209
}
210-
bundle := mockBundle()
210+
bundle := prepareBundle()
211211
i := &store.Installation{Claim: claim.Claim{Bundle: bundle}}
212212
err := mergeBundleParameters(i, withUndefined)
213213
assert.ErrorContains(t, err, "is not defined in the bundle")
@@ -218,7 +218,7 @@ func TestMergeBundleParameters(t *testing.T) {
218218
params["param"] = "foo"
219219
return nil
220220
}
221-
bundle := mockBundle(withParameter("param", "integer"))
221+
bundle := prepareBundle(withParameter("param", "integer"))
222222
i := &store.Installation{Claim: claim.Claim{Bundle: bundle}}
223223
err := mergeBundleParameters(i, withIntValue)
224224
assert.ErrorContains(t, err, "invalid value for parameter")
@@ -229,7 +229,7 @@ func TestMergeBundleParameters(t *testing.T) {
229229
params["param"] = "invalid"
230230
return nil
231231
}
232-
bundle := mockBundle(withParameterAndValues("param", "string", []interface{}{"valid"}))
232+
bundle := prepareBundle(withParameterAndValues("param", "string", []interface{}{"valid"}))
233233
i := &store.Installation{Claim: claim.Claim{Bundle: bundle}}
234234
err := mergeBundleParameters(i, withInvalidValue)
235235
assert.ErrorContains(t, err, "invalid value for parameter")

vendor/github.com/deislabs/cnab-go/bundle/bundle.go

Lines changed: 28 additions & 26 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/docker/cnab-to-oci/converter/convert.go

Lines changed: 14 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/docker/cnab-to-oci/converter/types.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)