Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Commit ab21570

Browse files
authored
Merge pull request #606 from ndeloof/goproxy
Configure GOPROXY
2 parents 83f43bd + 5234af7 commit ab21570

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ WORKDIR /go/src/github.com/docker/cli
1010

1111
RUN git clone https://github.com/docker/cli . && git checkout a1b83ffd2cbeefc0752e5aa7a543d49c1ddfd2cb
1212

13+
ARG GOPROXY
1314
RUN make binary-osx binary-windows binary && \
1415
cp build/docker-linux-amd64 /usr/bin/docker
1516

@@ -22,6 +23,7 @@ ARG DEP_VERSION=v0.5.1
2223
RUN curl -o /usr/bin/dep -L https://github.com/golang/dep/releases/download/${DEP_VERSION}/dep-linux-amd64 && \
2324
chmod +x /usr/bin/dep
2425
ARG GOTESTSUM_VERSION=v0.3.4
26+
ARG GOPROXY
2527
RUN mkdir $GOPATH/src/gotest.tools && \
2628
git clone -q https://github.com/gotestyourself/gotestsum $GOPATH/src/gotest.tools/gotestsum && \
2729
cd $GOPATH/src/gotest.tools/gotestsum && \

Jenkinsfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ pipeline {
99

1010
environment {
1111
TAG = "${env.BUILD_TAG}"
12+
GOPROXY="direct"
1213
}
1314

1415
stages {

docker.Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ E2E_CROSS_CTNR_NAME := $(BIN_NAME)-e2e-cross-$(TAG)
1515
COV_CTNR_NAME := $(BIN_NAME)-cov-$(TAG)
1616
SCHEMAS_CTNR_NAME := $(BIN_NAME)-schemas-$(TAG)
1717

18-
BUILD_ARGS=--build-arg=EXPERIMENTAL=$(EXPERIMENTAL) --build-arg=TAG=$(TAG) --build-arg=COMMIT=$(COMMIT) --build-arg=ALPINE_VERSION=$(ALPINE_VERSION)
18+
BUILD_ARGS=--build-arg=EXPERIMENTAL --build-arg=TAG --build-arg=COMMIT --build-arg=ALPINE_VERSION --build-arg=GOPROXY
1919

2020
PKG_PATH := /go/src/$(PKG_NAME)
2121

@@ -128,7 +128,7 @@ vendor: build_dev_image
128128
# git bash, mingw and msys by default rewrite args that seems to be linux paths and try to expand that to a meaningful windows path
129129
# we don't want that to happen when mounting paths referring to files located in the container. Thus we use the double "//" prefix that works
130130
# both on windows, linux and macos
131-
docker run -it --name docker-app-vendoring -v docker-app-vendor-cache://dep-cache -e DEPCACHEDIR=//dep-cache $(DEV_IMAGE_NAME) sh -c "rm -rf ./vendor && make vendor DEP_ARGS=\"$(DEP_ARGS)\""
131+
docker run -it --name docker-app-vendoring -v docker-app-vendor-cache://dep-cache -e DEPCACHEDIR=//dep-cache $(DEV_IMAGE_NAME) sh -c "rm -rf ./vendor && make vendor DEP_ARGS=\"$(DEP_ARGS)\""
132132
rm -rf ./vendor
133133
docker cp docker-app-vendoring:/go/src/github.com/docker/app/vendor .
134134
docker cp docker-app-vendoring:/go/src/github.com/docker/app/Gopkg.lock .

0 commit comments

Comments
 (0)