Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Commit b53ec2a

Browse files
committed
Push prints error messages correctly
When using docker-app as a plugin, error messages did not appear in the console. This is due to the fact that we did never un-mute the docker CLI structure when Pushing, and that the RunPlugin uses dockerCli.Err() to report error messages to the user. This fixes the issue by using the `defer muteDockerCli(cli)()` pattern that is used everywhere else. Signed-off-by: Simon Ferquel <[email protected]>
1 parent 8b1b2d0 commit b53ec2a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

internal/commands/push.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func pushCmd(dockerCli command.Cli) *cobra.Command {
4848
}
4949

5050
func runPush(dockerCli command.Cli, name string, opts pushOptions) error {
51-
muteDockerCli(dockerCli)
51+
defer muteDockerCli(dockerCli)()
5252
app, err := packager.Extract(name)
5353
if err != nil {
5454
return err

0 commit comments

Comments
 (0)