validate: Output name of validated application

Signed-off-by: Christopher Crone <[email protected]>

Author: chris-crone

e2e/commands_test.go

@@ -145,7 +145,8 @@ maintainers:
 
 	// validate metadata with JSON Schema
 	cmd.Command = dockerCli.Command("app", "validate", testAppName)
-	icmd.RunCmd(cmd).Assert(t, icmd.Success)
+	stdOut = icmd.RunCmd(cmd).Assert(t, icmd.Success).Combined()
+	golden.Assert(t, stdOut, "validate-output.golden")
 
 	// test single-file init
 	cmd.Command = dockerCli.Command("app",

e2e/testdata/validate-output.golden

@@ -0,0 +1 @@
+Validated "app-test.dockerapp"

internal/commands/root.go

@@ -32,7 +32,7 @@ func addCommands(cmd *cobra.Command, dockerCli command.Cli) {
 		mergeCmd(dockerCli),
 		renderCmd(dockerCli),
 		splitCmd(),
-		validateCmd(),
+		validateCmd(dockerCli),
 		versionCmd(dockerCli),
 		completionCmd(dockerCli, cmd),
 		bundleCmd(dockerCli),

internal/commands/validate.go

@@ -1,10 +1,13 @@
 package commands
 
 import (
+	"fmt"
+
 	"github.com/docker/app/internal/packager"
 	"github.com/docker/app/render"
 	"github.com/docker/app/types"
 	"github.com/docker/cli/cli"
+	"github.com/docker/cli/cli/command"
 	cliopts "github.com/docker/cli/opts"
 	"github.com/spf13/cobra"
 )
@@ -13,7 +16,7 @@ type validateOptions struct {
 	parametersOptions
 }
 
-func validateCmd() *cobra.Command {
+func validateCmd(dockerCli command.Cli) *cobra.Command {
 	var opts validateOptions
 	cmd := &cobra.Command{
 		Use:   "validate [APP_NAME] [--set KEY=VALUE ...] [--parameters-file PARAMETERS_FILE]",
@@ -29,7 +32,11 @@ func validateCmd() *cobra.Command {
 			defer app.Cleanup()
 			argParameters := cliopts.ConvertKVStringsToMap(opts.overrides)
 			_, err = render.Render(app, argParameters, nil)
-			return err
+			if err != nil {
+				return err
+			}
+			fmt.Fprintf(dockerCli.Out(), "Validated %q\n", app.Path)
+			return nil
 		},
 	}
 	opts.parametersOptions.addFlags(cmd.Flags())