Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Commit c9c0c02

Browse files
authored
Merge pull request #137 from mnottale/update-yatee
Update yatee, fix type of memory in e2e tests, explicit none renderer for better error checking.
2 parents 3a6e368 + a497678 commit c9c0c02

File tree

6 files changed

+51
-32
lines changed

6 files changed

+51
-32
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ E2E_NAME := $(BIN_NAME)-e2e
66
EXPERIMENTAL := off
77

88
# Comma-separated list of renderers
9-
RENDERERS := ""
9+
RENDERERS := "none"
1010

1111
TAG ?= $(shell git describe --always --dirty)
1212
COMMIT ?= $(shell git rev-parse --short HEAD)

e2e/binary_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -233,9 +233,9 @@ func TestHelmBinary(t *testing.T) {
233233
chart, _ := ioutil.ReadFile("helm.chart/Chart.yaml")
234234
values, _ := ioutil.ReadFile("helm.chart/values.yaml")
235235
stack, _ := ioutil.ReadFile("helm.chart/templates/stack.yaml")
236-
golden.AssertBytes(t, chart, "helm-expected.chart/Chart.yaml")
237-
golden.AssertBytes(t, values, "helm-expected.chart/values.yaml")
238-
golden.AssertBytes(t, stack, "helm-expected.chart/templates/stack.yaml")
236+
golden.Assert(t, string(chart), "helm-expected.chart/Chart.yaml")
237+
golden.Assert(t, string(values), "helm-expected.chart/values.yaml")
238+
golden.Assert(t, string(stack), "helm-expected.chart/templates/stack.yaml")
239239
}
240240

241241
func TestSplitMergeBinary(t *testing.T) {

e2e/helm.dockerapp/settings.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ tty: true
1111
aport: 10000
1212
sport: 11000
1313
dport: 12000
14-
memory: 100000000
14+
memory: '100000000'
1515
timeout: 10s

e2e/testdata/helm-expected.chart/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ app:
33
name: myapp
44
version: 0.1.0
55
dport: 12000
6-
memory: 100000000
6+
memory: "100000000"
77
myapp:
88
debug: false
99
nginx_replicas: 2

renderer/render.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,9 @@ func applyRenderers(data []byte, renderers []string, settings map[string]interfa
139139
return nil, err
140140
}
141141
data = []byte(mdata)
142+
case "none":
143+
default:
144+
return nil, fmt.Errorf("unknown renderer %s", r)
142145
}
143146
}
144147
return data, nil
@@ -197,7 +200,7 @@ func Render(appname string, composeFiles []string, settingsFile []string, env ma
197200
if r, ok := os.LookupEnv("DOCKERAPP_RENDERERS"); ok {
198201
rl := strings.Split(r, ",")
199202
for _, r := range rl {
200-
if !contains(renderers, r) {
203+
if r != "none" && !contains(renderers, r) {
201204
return nil, fmt.Errorf("renderer '%s' not found", r)
202205
}
203206
}

vendor/github.com/docker/yatee/yatee/yatee.go

Lines changed: 41 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)