Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Commit d99ac99

Browse files
author
Anca Iordache
committed
Updated status/list output times (added 'ago' at the end)
Signed-off-by: Anca Iordache <[email protected]>
1 parent 962230a commit d99ac99

File tree

4 files changed

+12
-7
lines changed

4 files changed

+12
-7
lines changed

e2e/commands_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ func testDockerAppLifecycle(t *testing.T, useBindMount bool) {
377377
checkContains(t, icmd.RunCmd(cmd).Assert(t, icmd.Success).Combined(),
378378
[]string{
379379
`INSTALLATION\s+APPLICATION\s+LAST ACTION\s+RESULT\s+CREATED\s+MODIFIED\s+REFERENCE`,
380-
fmt.Sprintf(`%s\s+simple \(1.1.0-beta1\)\s+install\s+failure\s+.+second[s]?\s+.+second[s]?\s+`, appName),
380+
fmt.Sprintf(`%s\s+simple \(1.1.0-beta1\)\s+install\s+failure\s+.+second[s]?\sago\s+.+second[s]?\sago\s+`, appName),
381381
})
382382

383383
// Upgrading a failed installation is not allowed
@@ -437,7 +437,7 @@ STATUS
437437
checkContains(t, icmd.RunCmd(cmd).Assert(t, icmd.Success).Combined(),
438438
[]string{
439439
`INSTALLATION\s+APPLICATION\s+LAST ACTION\s+RESULT\s+CREATED\s+MODIFIED\s+REFERENCE`,
440-
fmt.Sprintf(`%s\s+simple \(1.1.0-beta1\)\s+install\s+success\s+.+second[s]?\s+.+second[s]?\s+`, appName),
440+
fmt.Sprintf(`%s\s+simple \(1.1.0-beta1\)\s+install\s+success\s+.+second[s]?\sago\s+.+second[s]?\sago\s+`, appName),
441441
})
442442

443443
// Installing again the same application is forbidden

e2e/pushpull_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ func TestPushPullInstall(t *testing.T) {
224224
cmd.Command = dockerCli.Command("app", "list")
225225
checkContains(t, icmd.RunCmd(cmd).Assert(t, icmd.Success).Combined(),
226226
[]string{
227-
fmt.Sprintf(`%s\s+push-pull \(1.1.0-beta1\)\s+install\s+success\s+.+second[s]?\s+.+second[s]?\s+%s`, t.Name(), ref+tag),
227+
fmt.Sprintf(`%s\s+push-pull \(1.1.0-beta1\)\s+install\s+success\s+.+second[s]?\sago\s+.+second[s]?\sago\s+%s`, t.Name(), ref+tag),
228228
})
229229

230230
// install with --pull should fail (registry is stopped)

internal/commands/list.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,12 @@ var (
2929
{"APPLICATION", func(i *store.Installation) string { return fmt.Sprintf("%s (%s)", i.Bundle.Name, i.Bundle.Version) }},
3030
{"LAST ACTION", func(i *store.Installation) string { return i.Result.Action }},
3131
{"RESULT", func(i *store.Installation) string { return i.Result.Status }},
32-
{"CREATED", func(i *store.Installation) string { return units.HumanDuration(time.Since(i.Created)) }},
33-
{"MODIFIED", func(i *store.Installation) string { return units.HumanDuration(time.Since(i.Modified)) }},
32+
{"CREATED", func(i *store.Installation) string {
33+
return fmt.Sprintf("%s ago", units.HumanDuration(time.Since(i.Created)))
34+
}},
35+
{"MODIFIED", func(i *store.Installation) string {
36+
return fmt.Sprintf("%s ago", units.HumanDuration(time.Since(i.Modified)))
37+
}},
3438
{"REFERENCE", func(i *store.Installation) string { return i.Reference }},
3539
}
3640
)

internal/commands/status.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,11 @@ func runStatus(dockerCli command.Cli, installationName string, opts credentialOp
9595

9696
func displayInstallationStatus(w io.Writer, installation *store.Installation) {
9797
printHeader(w, "INSTALLATION")
98+
9899
tab := tabwriter.NewWriter(w, 0, 0, 1, ' ', 0)
99100
printValue(tab, "Name", installation.Name)
100-
printValue(tab, "Created", units.HumanDuration(time.Since(installation.Created)))
101-
printValue(tab, "Modified", units.HumanDuration(time.Since(installation.Modified)))
101+
printValue(tab, "Created", fmt.Sprintf("%s ago", units.HumanDuration(time.Since(installation.Created))))
102+
printValue(tab, "Modified", fmt.Sprintf("%s ago", units.HumanDuration(time.Since(installation.Modified))))
102103
printValue(tab, "Revision", installation.Revision)
103104
printValue(tab, "Last Action", installation.Result.Action)
104105
printValue(tab, "Result", strings.ToUpper(installation.Result.Status))

0 commit comments

Comments
 (0)