Merge pull request #646 from glours/cmd_error_message_like_cli

unknow command - use the same error format as the Docker CLI

Author: silvin-lubecki

e2e/commands_test.go

@@ -27,7 +27,7 @@ func TestExitErrorCode(t *testing.T) {
 	cmd.Command = dockerCli.Command("app", "unknown_command")
 	icmd.RunCmd(cmd).Assert(t, icmd.Expected{
 		ExitCode: 1,
-		Out:      "\"unknown_command\" is not a docker app command",
+		Err:      "\"unknown_command\" is not a docker app command\nSee 'docker app --help'",
 	})
 }
 

internal/commands/root.go

@@ -41,16 +41,12 @@ func NewRootCmd(use string, dockerCli command.Cli) *cobra.Command {
 				return cmd.GenZshCompletion(dockerCli.Out())
 			default:
 				if completion != "" {
-					fmt.Printf("%q is not a supported shell", completion)
-					cmd.HelpFunc()(cmd, args)
-					os.Exit(1)
+					return fmt.Errorf("%q is not a supported shell\nSee 'docker app --help'", completion)
 				}
 			}
 
 			if len(args) != 0 {
-				fmt.Printf("%q is not a docker app command", args[0])
-				cmd.HelpFunc()(cmd, args)
-				os.Exit(1)
+				return fmt.Errorf("%q is not a docker app command\nSee 'docker app --help'", args[0])
 			}
 			cmd.HelpFunc()(cmd, args)
 			return nil