Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Commit e93616c

Browse files
author
Ian Campbell
committed
Uses Set.Merge helper from duffle.
Using a temporary fork until the PR is merged. Signed-off-by: Ian Campbell <[email protected]>
1 parent eb7e692 commit e93616c

File tree

4 files changed

+24
-9
lines changed

4 files changed

+24
-9
lines changed

Gopkg.lock

Lines changed: 5 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Gopkg.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,11 @@ required = ["github.com/wadey/gocovmerge"]
4040
name = "github.com/docker/cli"
4141
branch = "master"
4242

43+
# Waiting for https://github.com/deislabs/duffle/pull/682 to be merged
4344
[[override]]
4445
name = "github.com/deislabs/duffle"
45-
branch = "master"
46+
source = "github.com/ijc/duffle"
47+
branch = "set-merge"
4648

4749
[[constraint]]
4850
name = "github.com/sirupsen/logrus"

internal/commands/cnab.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,8 @@ func addNamedCredentialSets(namedCredentialsets []string) credentialSetOpt {
5555
if err != nil {
5656
return err
5757
}
58-
for k, v := range values {
59-
if _, ok := creds[k]; ok {
60-
return fmt.Errorf("ambiguous credential resolution: %q is present in multiple credential sets", k)
61-
}
62-
creds[k] = v
58+
if err := creds.Merge(values); err != nil {
59+
return err
6360
}
6461
}
6562
return nil

vendor/github.com/deislabs/duffle/pkg/credentials/credentialset.go

Lines changed: 14 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)