Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Commit f59c875

Browse files
authored
Merge pull request #18 from mnottale/rename-services-to-docker-compose
Rename services.yml into docker-compose.yml
2 parents eaabaac + ef52589 commit f59c875

File tree

8 files changed

+9
-9
lines changed

8 files changed

+9
-9
lines changed

examples/simple/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,14 +188,14 @@ $ rm -rf simple.docker-app
188188
$ docker-app load simple.docker-app
189189
$ tar -tf simple.docker-app # TODO: should unpack automatically?
190190
metadata.yml
191-
services.yml
191+
docker-compose.yml
192192
settings.yml
193193
$ mv simple.docker-app simple # TODO: fix UX
194194
$ docker-app unpack simple
195195
$ tree simple.docker-app
196196
./simple.docker-app/
197197
├── metadata.yml
198-
├── services.yml
198+
├── docker-compose.yml
199199
└── settings.yml
200200

201201
0 directories, 3 files
@@ -209,7 +209,7 @@ $ tree simple.docker-app
209209
$ docker-app pack simple -o myapp.tar
210210
$ tar -tf myapp.tar
211211
metadata.yml
212-
services.yml
212+
docker-compose.yml
213213
settings.yml
214214
```
215215

packager/init.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ Examples of possible values: java, mysql, redis, ruby, postgres, rabbitmq...`)
5555
}
5656

5757
dirName := utils.DirNameFromAppName(name)
58-
if err := utils.CreateFileWithData(path.Join(dirName, "services.yml"), composeData); err != nil {
58+
if err := utils.CreateFileWithData(path.Join(dirName, "docker-compose.yml"), composeData); err != nil {
5959
return err
6060
}
6161
return utils.CreateFileWithData(path.Join(dirName, "settings.yml"), []byte{'\n'})
@@ -69,7 +69,7 @@ func initFromComposeFiles(name string, composeFiles []string, merger ComposeConf
6969
if err != nil {
7070
return err
7171
}
72-
if err = utils.CreateFileWithData(path.Join(dirName, "services.yml"), composeConfig); err != nil {
72+
if err = utils.CreateFileWithData(path.Join(dirName, "docker-compose.yml"), composeConfig); err != nil {
7373
return err
7474
}
7575
return utils.CreateFileWithData(path.Join(dirName, "settings.yml"), []byte{'\n'})

packager/init_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ func TestInitFromComposeFiles(t *testing.T) {
7878
manifest := fs.Expected(
7979
t,
8080
fs.WithMode(0755),
81-
fs.WithFile("services.yml", dummyComposeData, fs.WithMode(0644)),
81+
fs.WithFile("docker-compose.yml", dummyComposeData, fs.WithMode(0644)),
8282
fs.WithFile("settings.yml", "\n", fs.WithMode(0644)),
8383
)
8484

packager/packing.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ func Pack(appname, output string) error {
6161
}
6262
}
6363
tarout := tar.NewWriter(target)
64-
files := []string{"metadata.yml", "services.yml", "settings.yml"}
64+
files := []string{"metadata.yml", "docker-compose.yml", "settings.yml"}
6565
for _, f := range files {
6666
err = tarAdd(tarout, f, path.Join(appname, f))
6767
if err != nil {

packager/registry.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ func Save(appname, prefix, tag string) error {
2727
defer cleanup()
2828
dockerfile := `
2929
FROM scratch
30-
COPY services.yml settings.yml metadata.yml /
30+
COPY docker-compose.yml settings.yml metadata.yml /
3131
`
3232
df := path.Join(appname, "__Dockerfile-docker-app__")
3333
ioutil.WriteFile(df, []byte(dockerfile), 0644)

renderer/render.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ func Render(appname string, composeFiles []string, settingsFile []string, env ma
119119
finalEnv := make(map[string]string)
120120
flatten(settings, finalEnv, "")
121121
// prepend our app compose file to the list
122-
composes := []string{path.Join(appname, "services.yml")}
122+
composes := []string{path.Join(appname, "docker-compose.yml")}
123123
composes = append(composes, composeFiles...)
124124
// go-template, then parse, then expand the compose files
125125
configFiles := []composetypes.ConfigFile{}

0 commit comments

Comments
 (0)