Fix: no connect & start if not recreated

Signed-off-by: xi.han <[email protected]>

Author: xhanio

docker/service/service.go

@@ -327,25 +327,26 @@ func (s *Service) up(ctx context.Context, imageName string, create bool, options
 
 	return s.eachContainer(ctx, containers, func(c *container.Container) error {
 		var err error
+		oldID := c.ID()
 		if create {
 			c, err = s.recreateIfNeeded(ctx, c, options.NoRecreate, options.ForceRecreate)
 			if err != nil {
 				return err
 			}
 		}
 
-		if err := s.connectContainerToNetworks(ctx, c, false); err != nil {
-			return err
-		}
-
-		err = c.Start(ctx)
+		if c.ID() != oldID {
+			if err := s.connectContainerToNetworks(ctx, c, false); err != nil {
+				return err
+			}
 
-		if err == nil {
-			s.project.Notify(events.ContainerStarted, s.name, map[string]string{
-				"name": c.Name(),
-			})
+			err = c.Start(ctx)
+			if err == nil {
+				s.project.Notify(events.ContainerStarted, s.name, map[string]string{
+					"name": c.Name(),
+				})
+			}
 		}
-
 		return err
 	})
 }