Fix for #2989

olivbour · olivbour · commit 6eaf4fa72c00 · 2019-11-19T17:56:51.000+01:00
For using an SID as parameter - which is better because of potential i18n issue with role name - "isInRole()" expect a "System.Security.Principal.SecurityIdentifier" object instead of a "String".

That's because of this error that isHypervAdministrator() always return false and and consequently  "Administrator" role is requested.

Signed-off-by: Olivier Bourgeat &lt;olivier.bourgeat@laposte.net&gt;
diff --git a/drivers/hyperv/powershell.go b/drivers/hyperv/powershell.go
@@ -85,7 +85,7 @@ func isAdministrator() (bool, error) {
 }
 
 func isHypervAdministrator() bool {
-	stdout, err := cmdOut(`@([Security.Principal.WindowsPrincipal][Security.Principal.WindowsIdentity]::GetCurrent()).IsInRole("S-1-5-32-578")`)
+	stdout, err := cmdOut(`@([Security.Principal.WindowsPrincipal][Security.Principal.WindowsIdentity]::GetCurrent()).IsInRole(([System.Security.Principal.SecurityIdentifier]::new("S-1-5-32-578")))`)
 	if err != nil {
 		log.Debug(err)
 		return false

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ func isAdministrator() (bool, error) {`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`func isHypervAdministrator() bool {`
`88`		- stdout, err := cmdOut(`@([Security.Principal.WindowsPrincipal][Security.Principal.WindowsIdentity]::GetCurrent()).IsInRole("S-1-5-32-578")`)
	`88`	+ stdout, err := cmdOut(`@([Security.Principal.WindowsPrincipal][Security.Principal.WindowsIdentity]::GetCurrent()).IsInRole(([System.Security.Principal.SecurityIdentifier]::new("S-1-5-32-578")))`)
`89`	`89`	`if err != nil {`
`90`	`90`	`log.Debug(err)`
`91`	`91`	`return false`