Merge pull request #1711 from ndeloof/rename_race

ndeloof · web-flow · commit 2605aae33f81 · 2021-05-25T20:53:10.000+02:00
prevent race condition renaming containers
diff --git a/local/compose/convergence.go b/local/compose/convergence.go
@@ -105,6 +105,7 @@ func (s *composeService) ensureService(ctx context.Context, project *types.Proje
 	}
 
 	for _, container := range actual {
+		container := container
 		name := getContainerProgressName(container)
 
 		diverged := container.Labels[configHashLabel] != expected

Original file line number	Diff line number	Diff line change
`@@ -105,6 +105,7 @@ func (s composeService) ensureService(ctx context.Context, project types.Proje`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`for _, container := range actual {`
	`108`	`+ container := container`
`108`	`109`	`name := getContainerProgressName(container)`
`109`	`110`
`110`	`111`	`diverged := container.Labels[configHashLabel] != expected`