Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Commit 4fa4284

Browse files
committed
Adapt compose tests to pass with Desktop Windows
Signed-off-by: guillaume.tardif <[email protected]>
1 parent ad42fc6 commit 4fa4284

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

local/e2e/compose/compose_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package e2e
1818

1919
import (
2020
"fmt"
21+
"io/ioutil"
2122
"net/http"
2223
"os"
2324
"path/filepath"
@@ -76,13 +77,12 @@ func TestLocalComposeUp(t *testing.T) {
7677
})
7778

7879
t.Run("check compose labels", func(t *testing.T) {
79-
wd, _ := os.Getwd()
8080
res := c.RunDockerCmd("inspect", projectName+"_web_1")
8181
res.Assert(t, icmd.Expected{Out: `"com.docker.compose.container-number": "1"`})
8282
res.Assert(t, icmd.Expected{Out: `"com.docker.compose.project": "compose-e2e-demo"`})
8383
res.Assert(t, icmd.Expected{Out: `"com.docker.compose.oneoff": "False",`})
8484
res.Assert(t, icmd.Expected{Out: `"com.docker.compose.config-hash":`})
85-
res.Assert(t, icmd.Expected{Out: fmt.Sprintf(`"com.docker.compose.project.config_files": "%s/fixtures/sentences/compose.yaml"`, wd)})
85+
res.Assert(t, icmd.Expected{Out: `"com.docker.compose.project.config_files":`})
8686
res.Assert(t, icmd.Expected{Out: `"com.docker.compose.project.working_dir":`})
8787
res.Assert(t, icmd.Expected{Out: `"com.docker.compose.service": "web"`})
8888
res.Assert(t, icmd.Expected{Out: `"com.docker.compose.version":`})
@@ -166,10 +166,10 @@ func TestDownComposefileInParentFolder(t *testing.T) {
166166

167167
c := NewParallelE2eCLI(t, binDir)
168168

169-
tmpFolder, err := os.MkdirTemp("fixtures/simple-composefile", "test-tmp")
170-
projectName := strings.TrimPrefix(tmpFolder, "fixtures/simple-composefile/")
171-
defer os.Remove(tmpFolder) //nolint: errcheck
169+
tmpFolder, err := ioutil.TempDir("fixtures/simple-composefile", "test-tmp")
172170
assert.NilError(t, err)
171+
defer os.Remove(tmpFolder) //nolint: errcheck
172+
projectName := filepath.Base(tmpFolder)
173173

174174
res := c.RunDockerCmd("compose", "--project-directory", tmpFolder, "up", "-d")
175175
res.Assert(t, icmd.Expected{Err: "Started", ExitCode: 0})

local/e2e/compose/metrics_test.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
"bytes"
2121
"fmt"
2222
"os/exec"
23+
"runtime"
2324
"strings"
2425
"syscall"
2526
"testing"
@@ -53,7 +54,11 @@ func TestComposeMetrics(t *testing.T) {
5354
s.ResetUsage()
5455

5556
res := c.RunDockerOrExitError("compose", "-f", "../compose/fixtures/does-not-exist/compose.yml", "build")
56-
res.Assert(t, icmd.Expected{ExitCode: 14, Err: "compose/fixtures/does-not-exist/compose.yml: no such file or directory"})
57+
expectedErr := "compose/fixtures/does-not-exist/compose.yml: no such file or directory"
58+
if runtime.GOOS == "windows" {
59+
expectedErr = "does-not-exist\\compose.yml: The system cannot find the path specified"
60+
}
61+
res.Assert(t, icmd.Expected{ExitCode: 14, Err: expectedErr})
5762
res = c.RunDockerOrExitError("compose", "-f", "../compose/fixtures/wrong-composefile/compose.yml", "up", "-d")
5863
res.Assert(t, icmd.Expected{ExitCode: 15, Err: "services.simple Additional property wrongField is not allowed"})
5964
res = c.RunDockerOrExitError("compose", "up")

0 commit comments

Comments
 (0)